Patch : Show station coverage areas [v1 r17250]

[bcmpinc]

I updated the patch to trunk (r25578), based on the version Station_Coverage_r23919M.diff by ST2.

Furthermore, I fixed indentation errors and made the coverage disappear when closing the station dialog.

[MasterMeNL]

Has the bug with realistically sized catchment areas been fixed or does it still exist?

Regards,

Melvin.

[Eddi]

i don't think anything has changed in that area

[R2dical]

Updated to r26109, once trunk 1.3.3 comes out ill post a version for that too.

I looked at fixing the bug:

- if using "more realistic catchment size" for station, adding or removing tiles to a station with different catchment size can crash the game (on remove). Will be fixed in v2

But as far as I can tell this was already fixed, and this version works fine with no crash.

I also changed the "acceptance" area from red to white, once I figure out how to add a new colour (not red) I'd like to change this again and add in highlighting of the station tiles. Added some comments.

Was there any interested to add this to trunk? It seems a pretty straightforward and useful patch...

[frabac]

Hello!

First of all thank you so much for this patch: it is just great.
Today I tried to apply it to r26156.
3 files were missing, and I found them in the patchpack on github (https://github.com/bcmpinc/openttd).
Was it the right way? Or was there anything else I should have done instead?
BTW: it works, smooth!

[R2dical]

My bad, I left those 3 files out of the patch by mistake, they are not included in the selection by default in TortoiseSVN

Attached is the correct one updated to latest nightly.

[pi1985]

Last patch doesn't make changes to source.list.

[R2dical]

Last patch doesn't make changes to source.list.

What do you mean by this?

[pi1985]

You added new files (src/overlay*), but configure doesn't know about them and they do not compile. You should add new file names into source.list to generate right makefile by configure. See this for example.

[R2dical]

Oh I see (I use MSVC to compile).

[Eddi]

generally, you change source.list to add the files and then run projects/generate(.vbs) to change the msvc files accordingly.

[mtm2207946034]

I updated the patch to current trunk.

station_coverage.r27210.patch

(33.12 KiB) Downloaded 361 times

[Patagonicus]

Got a little lazy, having to remove coverage areas manually. So made a small change to remove coverage areas with the windows when using the delete key.

Sorry, were too lazy to make a setting for it - but hey, it's upgraded for r27728 for free

Minor update: Refreshed screen on clear.

[mtm2207946034]

Again, updated the patch to current trunk.

Behavior is same as before, including Patagonicus modification:

• * displays acceptance/catchment areas within the map
  * toggle catchment area by button in station gui and Ctrl click to station
  * hide all catchment areas by delete key

station_coverage-671a310d219cb0e12270578d0e63cd66701eae02.diff

Station Coverage Patch

(40.64 KiB) Downloaded 236 times

The update mainly covers updates to the project files. There have been only minor modifications to affected source files.

[jfs]

How does this compare to the changes in PR #7446 "Show coverage area for existing stations and towns"? It looks like your patch might be wrong after the recent changes to catchment area rules.

[mtm2207946034]

How does this compare to the changes in PR #7446 "Show coverage area for existing stations and towns"? It looks like your patch might be wrong after the recent changes to catchment area rules.

Thanks for the hint.

I was not aware of the recent behavioral changes (PR #7235). As I understand, a station does not have an overall rectangular acceptance area any more. Acceptance tiles are equal to productivity tiles now in meaning of this patch.

Thus the patch of this forums thread won't provide correct catchment areas after release 1.9 any more.
PR #7446 should be applied instead.