GS Documentation

[idioty]

I found the following in the documentation:
INVALID_EXPENSES
Why this name?
Why do not more: EXPENSES_INVALID, like others INVALID type?

And in GSCompany:
static uint32 GetAutoRenewMoney (CompanyID company)
Why static uint32? Why do not more: static Money, like others Money methodes?

[Zuu]

I found the following in the documentation:
INVALID_EXPENSES
Why this name?
Why do not more: EXPENSES_INVALID, like others INVALID type?

Because the internal Enum uses the name EXPENSES_INVALID and among all things to think about, I didn't remember to take a look at the other API methods for the possibility that the INVALID constant use a different naming pattern than the internal constants. Sorry about that.

I can 'fix' this and render the few scripts that rely on EXPENSES_INVALID broken for a short while before they get fixed.

And in GSCompany:
static uint32 GetAutoRenewMoney (CompanyID company)
Why static uint32? Why do not more: static Money, like others Money methodes?

I don't know the reason behind this. It may be historic or the same as above that the internal data type is uint32.

[R2dical]

For "static int32 GSTown::GetGrowthRate"

Code: Select all

Returns:
    True if the action succeeded. 

Doesn't this function actually return the days between growth?

[Zuu]

I found the following in the documentation:
INVALID_EXPENSES

Fixed in r25788 (changed to EXPENSES_INVALID)

[idioty]

I found the following in the documentation:
INVALID_EXPENSES

Fixed in r25788 (changed to EXPENSES_INVALID)

Thx!