JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Auge
Director
Director
Posts: 636
Joined: 23 Oct 2006 02:07
Location: Berlin

Re: JGR's Patch Pack

Post by Auge »

Hello JGR

I started to translate the strings for a few patches to german language. First one was the zoning toolbar, followed by additional infos in the vehicle window and the group window.

Most of the patches in your pack was developed by other people. Otherwise your pack is the simplest way (for me) to contribute. Are you interested in the translation(s)?

Tschö, Auge
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Auge wrote:Hello JGR

I started to translate the strings for a few patches to german language. First one was the zoning toolbar, followed by additional infos in the vehicle window and the group window.

Most of the patches in your pack was developed by other people. Otherwise your pack is the simplest way (for me) to contribute. Are you interested in the translation(s)?

Tschö, Auge
Yes, I'd be very happy to merge any translations.

Edit: I've gone ahead and merged your translations so far, they're in v0.7.1, many thanks :).
Ex TTDPatch Coder
Patch Pack, Github
bu-forums.org
Engineer
Engineer
Posts: 1
Joined: 05 Nov 2015 16:53
Contact:

Re: JGR's Patch Pack

Post by bu-forums.org »

Perfect. :bow:
sunshare
Transport Coordinator
Transport Coordinator
Posts: 279
Joined: 10 Oct 2014 00:43

Re: JGR's Patch Pack

Post by sunshare »

User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

sunshare wrote:Look!! next version please !!!

http://www.tt-forums.net/viewtopic.php?f=33&t=73976
This looks quite interesting, and I've had a quick skim through the code.
I'd be inclined to wait a bit for bugs to be shaken out and issues with the code resolved before considering merging it though.
I'll keep an eye on it in future.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

I find the graphics on that to be a little bit too bright and hard on the eyes compared to the defaults. So eeeh.
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
User avatar
kamnet
Moderator
Moderator
Posts: 8589
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: JGR's Patch Pack

Post by kamnet »

Redirect Left wrote:I find the graphics on that to be a little bit too bright and hard on the eyes compared to the defaults. So eeeh.
It's just the custom NewGRF sprites that Vetteman06 created. If you don't activate it then it will use the default OpenGFX sprites.
User avatar
Xaxa
Engineer
Engineer
Posts: 42
Joined: 18 Sep 2008 15:03
Location: Zaanstad, The Netherlands
Contact:

Re: JGR's Patch Pack

Post by Xaxa »

Can't wait to have this pushed to a stable OpenTTD version. Lots of these patches are exactly what I've been waiting for and weeped about dying out. Thanks for all the efforts. :)
User avatar
kamnet
Moderator
Moderator
Posts: 8589
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: JGR's Patch Pack

Post by kamnet »

Xaxa wrote:Can't wait to have this pushed to a stable OpenTTD version. Lots of these patches are exactly what I've been waiting for and weeped about dying out. Thanks for all the efforts. :)
Patch packs typically are not based on stable OpenTTD versions, but nightly revisions that contain the newest features and bug fixes.
jamvanderloeff
Engineer
Engineer
Posts: 2
Joined: 28 Sep 2012 04:16

Re: JGR's Patch Pack

Post by jamvanderloeff »

Thanks for the patchpack 8)

If anyone cares, I have compiled a binary for OS X 10.4+ (PowerPC only) http://a.pomf.hummingbird.moe/yoasex.dmg
willsym22
Engineer
Engineer
Posts: 118
Joined: 03 Mar 2014 23:14
Location: Essex

Re: JGR's Patch Pack

Post by willsym22 »

Haven't looked at the forum for a while, the bits I've skimmed through look good :)

Is there a list of the things that are planned to be included in the latest update?

Really good so far!

:)
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

willsym22 wrote:Haven't looked at the forum for a while, the bits I've skimmed through look good :)

Is there a list of the things that are planned to be included in the latest update?

Really good so far!

:)
Thanks :)

Generally, commits will appear on Github as and when they're implemented. I don't have a plan for what will go in any particular release, it depends how development goes and what bugs I find.
When a release is done the first post will be updated with what's changed.
Ex TTDPatch Coder
Patch Pack, Github
KingJ
Engineer
Engineer
Posts: 6
Joined: 06 Oct 2007 12:32

Re: JGR's Patch Pack

Post by KingJ »

First off, many thanks JGR for creating this patch pack - i've been playing a game with it for several months now and have been thoroughly enjoying it!

I'm coming up against a small issue with automated timetabling and separation however. For the most part, it works pretty well, but on high-frequency routes with many stops and long distances, trains can sometimes bunch up. They will then wait at the station as they're running early, causing a tailback of trains entering the station. This then compounds the problem as trains update their timetable with the new, delayed, time it took for them to enter the station which causes them to wait at the station as they're running early and so on and so forth.

At the moment, i'm manually fixing this by either resetting the late counter or skipping trains to the next order, but at the moment i'm spending most of my time moving around the network doing this. I've tried adjusting the "Auto timetable vehicle separation factor" to compensate, but even all the way down at 5% i'll often see trains that are running early with 30-50% of their overall timetable duration as the early time.

Any suggestions on how to work around this?

Thanks again :)
User avatar
openbu.org
Engineer
Engineer
Posts: 74
Joined: 14 Nov 2014 07:40
Location: USA
Contact:

./configure

Post by openbu.org »

root@iZu1fwxfw6fZ:~/Downloads/OpenTTD-patches-jgrpp# ./configure
checking awk... awk
detecting OS... UNIX
checking build system type... x86_64-linux-gnu
checking host system type... x86_64-linux-gnu
checking universal build... no
checking build cc... gcc
checking host cc... gcc
checking build c++... g++
checking host c++... g++
checking strip... disabled
checking builtin depend... yes
checking makedepend... disabled
detecting cpu-type... 64 bits
detecting SSE... found
checking static... no
checking unicode... no
using debug level... no
using desync debug level... no
using link time optimization... no
checking OSX sysroot... not OSX, skipping
checking allegro... not found
checking sdl... found
checking COCOA... not OSX, skipping
checking GDI video driver... not Windows, skipping
checking dedicated... not selected
checking console application... not Windows, skipping
checking network... found
checking squirrel... found
checking translator... no
checking assert... enabled
checking zlib... found
checking liblzma... found
checking lzo2... found
checking libxdg-basedir... not found
checking libpng... found
checking freetype2... found
checking fontconfig... found
checking icu-lx... found
checking icu-i18n... found
checking psp-config... not PSP, skipping
checking libtimidity... not found
checking direct-music... not Windows, skipping
checking sort... sort
checking endianness... AUTO
suppress language errors... no
checking stripping... skipped
checking distcc... no (only used when forced)
checking ccache... no (only used when forced)
checking grfcodec... not found
checking nforenum... not found
checking OSX application bundle... not OSX, skipping
checking revision... no detection
WARNING: there is no means to determine the version.
WARNING: please use a subversion, mercurial, or git checkout of OpenTTD.
WARNING: you can only join game servers that have been compiled without
WARNING: version detection.
WARNING: there is a great chance you desync.
WARNING: USE WITH CAUTION!
checking iconv... not OSX, skipping
personal home directory... .openttd
shared data directory... none
installation directory... /
icon theme directory... share/icons/hicolor
manual page directory... share/man/man6
menu item directory... share/applications
checking libdl... found
checking libbfd... no
checking abi::__cxa_demangle... found
using CFLAGS_BUILD... -Wall -Wno-multichar -Wsign-compare -Wundef -Wwrite-strings -Wpointer-arith -W -Wno-unused-parameter -Wredundant-decls -Wformat=2 -Wformat-security -Winit-self -fno-strict-aliasing -Wcast-qual -fno-strict-overflow -Wnon-virtual-dtor -Wno-free-nonheap-object -rdynamic -DUNIX -D_FORTIFY_SOURCE=2 -O1
using CXXFLAGS_BUILD... -std=gnu++0x -Wno-narrowing
using LDFLAGS_BUILD... -rdynamic
using CFLAGS... -O2 -fomit-frame-pointer -Wall -Wno-multichar -Wsign-compare -Wundef -Wwrite-strings -Wpointer-arith -W -Wno-unused-parameter -Wredundant-decls -Wformat=2 -Wformat-security -Winit-self -fno-strict-aliasing -Wcast-qual -fno-strict-overflow -Wnon-virtual-dtor -Wno-free-nonheap-object -rdynamic -DUNIX -D_FORTIFY_SOURCE=2 -DWITH_SSE -DWITH_DL -DWITH_DEMANGLE -DWITH_SDL -D_REENTRANT -I/usr/include/SDL -DWITH_ZLIB -DWITH_LZMA -DWITH_LZO -D_SQ64 -I/root/Downloads/OpenTTD-patches-jgrpp/src/3rdparty/squirrel/include -DWITH_PNG -I/usr/include/libpng12 -DWITH_FONTCONFIG -I/usr/include/freetype2 -DWITH_FREETYPE -I/usr/include/freetype2 -DWITH_ICU_LAYOUT -I/usr/include/x86_64-linux-gnu -DWITH_ICU_SORT -I/usr/include/x86_64-linux-gnu -DENABLE_NETWORK -DWITH_PERSONAL_DIR -DPERSONAL_DIR=\".openttd\" -DGLOBAL_DATA_DIR=\"/usr/local/share/games/openttd\"
using CXXFLAGS... -std=gnu++0x -Wno-narrowing
using LDFLAGS... -lstdc++ -lpthread -ldl -lc -lSDL -lz -llzma -llzo2 -lpng12 -lfontconfig -lfreetype -lfreetype -liculx -licule -licuuc -licudata -licui18n -licuuc -licudata -rdynamic
Generating Makefile...
Generating menu item...
Generating lang/Makefile...
Generating setting/Makefile...
Generating grf/Makefile...
Generating objs/Makefile...
root@iZu1fwxfw6fZ:~/Downloads/OpenTTD-patches-jgrpp#
User avatar
openbu.org
Engineer
Engineer
Posts: 74
Joined: 14 Nov 2014 07:40
Location: USA
Contact:

make --jobs=5

Post by openbu.org »

root@iZu1fwxfw6fZ:~/Downloads/OpenTTD-patches-jgrpp# make --jobs=5
sha256sum: src/rev.cpp: No such file or directory
make[1]: Entering directory `/root/Downloads/OpenTTD-patches-jgrpp/objs/lang'
[LANG] Compiling and Linking endian_check
[LANG] Compiling getoptdata.cpp
[LANG] Testing endianness for host
[LANG] Compiling core/alloc_func.cpp
[LANG] Compiling string.cpp
[LANG] Compiling strgen/strgen_base.cpp
[LANG] Compiling strgen/strgen.cpp
[LANG] Compiling and Linking strgen
[LANG] Generating table/strings.h
[LANG] Compiling language afrikaans
[LANG] Compiling language arabic_egypt
[LANG] Compiling language basque
[LANG] Compiling language belarusian
[LANG] Compiling language brazilian_portuguese
[LANG] Compiling language bulgarian
[LANG] Compiling language catalan
[LANG] Compiling language croatian
[LANG] Compiling language czech
[LANG] Compiling language danish
[LANG] Compiling language dutch
[LANG] Compiling language english_AU
[LANG] Compiling language english
[LANG] Compiling language english_US
[LANG] Compiling language esperanto
[LANG] Compiling language estonian
[LANG] Compiling language faroese
[LANG] Compiling language finnish
[LANG] Compiling language french
[LANG] Compiling language gaelic
[LANG] Compiling language galician
[LANG] Compiling language german
[LANG] Compiling language greek
[LANG] Compiling language hebrew
[LANG] Compiling language hungarian
[LANG] Compiling language icelandic
[LANG] Compiling language indonesian
[LANG] Compiling language irish
[LANG] Compiling language italian
[LANG] Compiling language japanese
[LANG] Compiling language korean
[LANG] Compiling language latin
[LANG] Compiling language latvian
[LANG] Compiling language lithuanian
[LANG] Compiling language luxembourgish
[LANG] Compiling language malay
[LANG] Compiling language norwegian_bokmal
[LANG] Compiling language norwegian_nynorsk
[LANG] Compiling language polish
[LANG] Compiling language portuguese
[LANG] Compiling language romanian
[LANG] Compiling language russian
[LANG] Compiling language serbian
[LANG] Compiling language simplified_chinese
[LANG] Compiling language slovak
[LANG] Compiling language slovenian
[LANG] Compiling language spanish
[LANG] Compiling language swedish
[LANG] Compiling language tamil
[LANG] Compiling language thai
[LANG] Compiling language traditional_chinese
[LANG] Compiling language turkish
[LANG] Compiling language ukrainian
[LANG] Compiling language vietnamese
[LANG] Compiling language welsh
make[1]: Leaving directory `/root/Downloads/OpenTTD-patches-jgrpp/objs/lang'
make[1]: Entering directory `/root/Downloads/OpenTTD-patches-jgrpp/objs/setting'
[SETTING] Compiling and Linking endian_check
[SETTING] Compiling ini_load.cpp
[SETTING] Compiling settingsgen/settingsgen.cpp
[SETTING] Compiling getoptdata.cpp
[SETTING] Testing endianness for host
[SETTING] Compiling core/alloc_func.cpp
[SETTING] Compiling string.cpp
[SETTING] Compiling and Linking settings_gen
[SETTING] Generating table/settings.h
make[1]: Leaving directory `/root/Downloads/OpenTTD-patches-jgrpp/objs/setting'
make[1]: Entering directory `/root/Downloads/OpenTTD-patches-jgrpp/objs/extra_grf'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/root/Downloads/OpenTTD-patches-jgrpp/objs/extra_grf'
sha256sum: src/rev.cpp: No such file or directory
make[1]: Entering directory `/root/Downloads/OpenTTD-patches-jgrpp/objs/release'
[SRC] Compiling and Linking endian_check
[SRC] Compiling and linking depend
[SRC] Testing endianness for target
[SRC] DEP CHECK (all files)
make[1]: Leaving directory `/root/Downloads/OpenTTD-patches-jgrpp/objs/release'
make[1]: Entering directory `/root/Downloads/OpenTTD-patches-jgrpp/objs/release'
[SRC] DEP CHECK (all files)
Alberth
OpenTTD Developer
OpenTTD Developer
Posts: 4763
Joined: 09 Sep 2007 05:03
Location: home

Re: JGR's Patch Pack

Post by Alberth »

Looks like you need to check out the source using a revision control system and/or install such tools at your system. "rev.cpp" is generated using information from the checked out source using the revision control tools. (I think JGR uses git.)
Being a retired OpenTTD developer does not mean I know what I am doing.
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

KingJ wrote:First off, many thanks JGR for creating this patch pack - i've been playing a game with it for several months now and have been thoroughly enjoying it!

I'm coming up against a small issue with automated timetabling and separation however. For the most part, it works pretty well, but on high-frequency routes with many stops and long distances, trains can sometimes bunch up. They will then wait at the station as they're running early, causing a tailback of trains entering the station. This then compounds the problem as trains update their timetable with the new, delayed, time it took for them to enter the station which causes them to wait at the station as they're running early and so on and so forth.

At the moment, i'm manually fixing this by either resetting the late counter or skipping trains to the next order, but at the moment i'm spending most of my time moving around the network doing this. I've adjusting the "Auto timetable vehicle separation factor" to compensate, but even all the way down at 5% i'll often see trains that are running early with 30-50% of their overall timetable duration as the early time.

Any suggestions on how to work around this?

Thanks again :)
You'll need at least a little slack in the timetable for auto timetables to work effectively.
If you've got multiple order groups running through a congested single platform this makes the problem worse, as different routes end up delaying each other.
When I first started using auto timetables on a busy game I ended up building more platforms at the busiest stations.

If you're running the route at maximum capacity already you might be better off turning auto-timetables off for that route as trains will be spread out anyway by the bottlenecks.
openbu.org wrote:...
Can you check that your source directory matches the repository including the files outside the src/ directory, in particular .ottdrev-vc and findversion.sh. If in doubt please clone the git repository.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
openbu.org
Engineer
Engineer
Posts: 74
Joined: 14 Nov 2014 07:40
Location: USA
Contact:

Re: JGR's Patch Pack

Post by openbu.org »

thanks to @Alberth
thanks to @JGR

Code: Select all

# git clone https://github.com/JGRennison/OpenTTD-patches
# ./configure 
# make --jobs=5 
it works.
thanks.
Attachments
20151130003235.png
20151130003235.png (94.32 KiB) Viewed 3957 times
Last edited by openbu.org on 30 Nov 2015 09:35, edited 1 time in total.
User avatar
openbu.org
Engineer
Engineer
Posts: 74
Joined: 14 Nov 2014 07:40
Location: USA
Contact:

Re: JGR's Patch Pack

Post by openbu.org »

Testing Server,We are testing.......
Attachments
testingServer.png
testingServer.png (19.41 KiB) Viewed 2071 times
KingJ
Engineer
Engineer
Posts: 6
Joined: 06 Oct 2007 12:32

Re: JGR's Patch Pack

Post by KingJ »

JGR wrote: You'll need at least a little slack in the timetable for auto timetables to work effectively.
If you've got multiple order groups running through a congested single platform this makes the problem worse, as different routes end up delaying each other.
When I first started using auto timetables on a busy game I ended up building more platforms at the busiest stations.

If you're running the route at maximum capacity already you might be better off turning auto-timetables off for that route as trains will be spread out anyway by the bottlenecks.
I've tried massively increasing capacity as well as turning off automated timetabling for certain train groups, but to no avail - they still seem to bunch up and become very early.

Interestingly, if I toggle automatic separation off in the options, wait ~30s and then turn it on again, the game crashes. I've posted the crash information at http://pastebin.com/E2BjhEzw if that's any help.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 48 guests