Gremnon's Patch Pack (GPP, r18413)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by Gremnon »

Also our friend Isaac who's apparantly given up trying to merge GPP and CargoDist has pestered me into telling you it doesn't compile for him on Debian Lenny or Windows XP.
I've yet to try patching or compiling myself.
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by 2007Alain2007 »

but dose work on Vista :( but with out being able to open the Setiings window but this can be hacked by


changing

Code: Select all

extern const uint16 SAVEGAME_VERSION = 127;

to

extern const uint16 SAVEGAME_VERSION = 211;
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by Gremnon »

Wouldn't that break the trunk-loadable saving capability?
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by 2007Alain2007 »

yer but at less were got a patch pack we can change settings on with out the crash

if any one knows were SAVEGAME_VERSION would be looked for it might help fix the settings proble

If there is any better way to get it to work please say

Also dose this have the tree grow patch i added in
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by Gremnon »

Probably not.
What you could do is take a copy of trunk, patch it with GPP6, then try to apply the tree growth patch, and if you get a ton of prompts asking if you want to revert, then it's probably already included. And if not, well, you might have a few failed hunks to fix, but you'll have it in there.
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by 2007Alain2007 »

That will be the easy bit to do

just wish there was a diff for the save to trunk thing
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by Gremnon »

Well, it's an interesting little feature, I don't think it's ever been done before.
Maybe, for others who want to use it in the own pack/patch, it could be provided?
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by 2007Alain2007 »

The error line is in settings_gui.cpp

Code: Select all

assert(this->d.entry.setting != NULL);
any ideas why
For Community Integrated Version http://code.google.com/p/civopenttd/
sulai
Traffic Manager
Traffic Manager
Posts: 159
Joined: 24 Sep 2004 18:23

Re: Gremnon's Patch Pack (GPP, r17736)

Post by sulai »

Fixed that, thank you for investigation. Hope everything is fine now :)

Tree growth patch is not yet in there, sorry. I was working on top of GPP_17680.
Attachments
GPP7.diff
(550.43 KiB) Downloaded 116 times
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by Gremnon »

I can confirm it compiles on Ubuntu Jaunty once more, at least.
However, there's a lot of warnings in the language files, and hunk 15 of smallmap_gui.cpp didn't patch correctly.

Time permitting, I might be returning to work on the pack soon, and some new additions will be the tree growth patch, the new version of autoload face, no reliability loss for trains not moving, and possibly also the Grass growth on unused tracks too.

That's if I get time to find those patches, and fix any issues.
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by 2007Alain2007 »

dont add in Grass growth on unused tracks becuse last i know it cant be turned off

Also what autoload face is in your pack if any on GPP7
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by Gremnon »

Autoload face used to be in, but I removed it because all players, even AI companies that started up used the same face.
The new version fixes this, so it may be returning.

As to grass growth, yes you can't turn it off, but you don't really need to. It's just a graphic effect, if your tracks aren't used much, they get a little grass on them, growing more unless trains start using it. It doesn't change anything.
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by 2007Alain2007 »

It will if you dont mind be adding it in myself and uploading the patch file :) give you a bit more of a break

autoload_face_r17744 + r17765_reduced_tree_growth is now added to GPP

HINT More To Come but theres are what Gremnon fort of adding in

hope you dont mind

GPP8 removed
Last edited by 2007Alain2007 on 24 Oct 2009 22:20, edited 1 time in total.
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by Gremnon »

Eeh.... I guess I don't mind much. I was going to do it myself so I could add to my list of notes about what needed to be changed if any parts didn't apply...
Anyway, that list isn't concrete yet. I'm still going through patches and seeing what I might add/remove/update/change
petert
Tycoon
Tycoon
Posts: 3008
Joined: 02 Apr 2009 22:43
Location: Massachusetts, USA

Re: Gremnon's Patch Pack (GPP, r17736)

Post by petert »

Could you please add me to the project on google code, then I can include win32 binaires?
User avatar
zar_igor
Engineer
Engineer
Posts: 32
Joined: 24 May 2006 17:26
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by zar_igor »

2007Alain2007 wrote:It will if you dont mind be adding it in myself and uploading the patch file :) give you a bit more of a break
autoload_face_r17744 + r17765_reduced_tree_growth is now added to GPP
Where can I find the file? The GoogleGroup does not host it yet, or?
Playing Transport Tycoon since 25+ years.
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by Gremnon »

Alain chose to remove it.
I didn't have a problem with his uploading it, but I did mention that I hadn't set the list of patches to update etc in stone.
If you can point out the thread with the patch for the trees, I'll put up a quick update shortly.

So far, the patches definatly coming as well are the autoload face, reliability for stopped vehicles, tree growth and an update for the additional airports, which brings Dubai world Central into the pack.

However, as said before - this list is subject to change, depending on what patches decide to be annoying today.
Requests are, of course, welcome, with the exception of IS and CargoDist, as those will take quite some time to manage.
User avatar
zar_igor
Engineer
Engineer
Posts: 32
Joined: 24 May 2006 17:26
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by zar_igor »

Great news, thank you! Another interesting patch might be diagonal crossing over roads, but I don't know how that would work. I've seen it as a part of the MiniIn years before.
Playing Transport Tycoon since 25+ years.
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by Gremnon »

That's a terribly old, and outdated patch... I agree it would be nice, but there's all kinds of issues with that, not least of which is that there's no graphics available for most road/rail types.

Wishful thinking, but you never know, maybe someone will surprise us all and update it sometime.
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Gremnon's Patch Pack (GPP, r17736)

Post by 2007Alain2007 »

This is the GPP8 that gremnon has been working on and me a lil bit
For Community Integrated Version http://code.google.com/p/civopenttd/
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: Bing [Bot] and 9 guests