Page 4 of 6
tunnel building broken
Posted: 22 Jun 2007 22:54
by benc
Ev wrote:*fix for destructive tunnel's end bug;
Can you elaborate on what this bug is? I can't find it on
http://bugs.openttd.org/
If you're just referring to ability to build the tunnel below without having to manually excavate the other end: that's a usability
feature, not a bug! Please don't break it.
Posted: 23 Jun 2007 02:37
by Ev
----------
Posted: 23 Jun 2007 03:06
by DaleStan
FFS!!! Just fix put an appropriate is-tile-clear check before the terraforming.
Don't disable it because it's broken. FIX IT!
Posted: 23 Jun 2007 05:23
by Ev
----------
Posted: 24 Jun 2007 01:46
by benc
Cool. Did you ever request re-open for FS#890? New-feature patches shouldn't be fixing bugs. The trunk needs the fix regardless of whether the feature is accepted.
Posted: 24 Jun 2007 07:06
by peter1138
Huh? FS#890 was fixed...
Posted: 24 Jun 2007 13:21
by benc
It was marked as fixed but r10219 didn't actually fix the problem. Not sure why Ev didn't re-report it earlier.
Attached is a bugfix patch, extracted from the main build-under-slopes patch. All credit to Ev of course.
Posted: 24 Jun 2007 13:35
by Rubidium
benc wrote:It was marked as fixed but r10219 didn't actually fix the problem.
How do I reproduce that, because the bug reported in FS#890 is fixed in trunk, i.e. I cannot reproduce it anymore.
Posted: 24 Jun 2007 14:34
by Ev
----------
Posted: 24 Jun 2007 14:48
by Ev
----------
Posted: 24 Jun 2007 14:58
by kaan
Rubidium wrote:benc wrote:It was marked as fixed but r10219 didn't actually fix the problem.
How do I reproduce that, because the bug reported in FS#890 is fixed in trunk, i.e. I cannot reproduce it anymore.
I just reproduced the bug, pictured in tunnel.png above, with trunk r10304.
Posted: 24 Jun 2007 17:39
by Rubidium
Now it should be fixed (again).
With one note: half road tiles get *always* removed when you are terraforming, building train depots, building diagonal rail etc. Therefor half road tiles *will* get removed when they are at the to be excavated tile. The patch in this thread did not obey to this "rule", so that's not the one that is used to fix this bug.
Posted: 24 Jun 2007 18:51
by madman2003
Ev wrote:I would like to request to include patch into trunk.
I suggest you post to flyspray.
Posted: 24 Jun 2007 22:16
by Ev
----------
Posted: 25 Jun 2007 16:28
by Digitalfox
Ev wrote:Thanks for recommendation, i have already.
Ev look at the comment Rubidium made in flyspray about your patch, if you haven't already
http://bugs.openttd.org/task/928
Posted: 25 Jun 2007 21:36
by csuke
Rubidium wrote:...With one note: half road tiles get *always* removed when you are terraforming, building train depots, building diagonal rail etc. Therefor half road tiles *will* get removed when they are at the to be excavated tile. The patch in this thread did not obey to this "rule", so that's not the one that is used to fix this bug.
Could you point me to the thread which discusses this (if there is one), i would be quite interested to see the discussion on how this became a feature rather than a bug
Posted: 25 Jun 2007 21:48
by rav
csuke wrote:
Could you point me to the thread which discusses this (if there is one), i would be quite interested to see the discussion on how this became a feature rather than a bug
here you go:
http://www.tt-forums.net/viewtopic.php?t=30878
Posted: 25 Jun 2007 21:52
by Rubidium
csuke wrote:Could you point me to the thread which discusses this (if there is one), i would be quite interested to see the discussion on how this became a feature rather than a bug
It is also in TTD and half road tiles are absolutely useless in games; vehicles do not even drive on them. So removing them should be possible.
Posted: 25 Jun 2007 22:44
by benc
Makes good sense for buses and lorries, but trams need half road tiles to turn around.
Posted: 26 Jun 2007 01:35
by Ev
----------