Patch: New passenger destinations

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

dasy2k1
Transport Coordinator
Transport Coordinator
Posts: 344
Joined: 20 Sep 2006 23:43
Location: UK
Contact:

Re: Patch: New passenger destinations

Post by dasy2k1 »

sounds like you may be having the same issue as me....

if you have 2 ways of getting from A to B all the passengers will wait for the fastest way regardles of the fact that it takes 4 times longer counting waiting times.
Stefanouz
Engineer
Engineer
Posts: 25
Joined: 11 Jul 2004 17:40
Location: The Netherlands, Hilversum

Re: Patch: New passenger destinations

Post by Stefanouz »

The patch is working, because at other trajects it work, but some trajects it don't.
That the passengers want to take an other route is also not possible, because there isn't.
Gekko
Engineer
Engineer
Posts: 8
Joined: 13 Apr 2008 10:30

Re: Patch: New passenger destinations

Post by Gekko »

Can we get this patch updated to the latest trunk please?
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: Patch: New passenger destinations

Post by Roest »

Ok i updated it. It seems to work. I just tested it with 4 bus stations. No guarantees if it really works.
Attachments
paxdest_r12836.patch
(160.71 KiB) Downloaded 321 times
jub
Engineer
Engineer
Posts: 67
Joined: 17 Jul 2003 13:46
Location: Sudice, Czech Republic
Contact:

Re: Patch: New passenger destinations

Post by jub »

Does anybody encounter following behaviour: the connection between two stations is created asymetrical - A has B as a next station, but B doesn't have A as a one?
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: Patch: New passenger destinations

Post by Roest »

A connection is established when a vehicle goes from A to B. So if you don't have a route B to A, there wont be a connection.
User avatar
trainmaster611
Traffic Manager
Traffic Manager
Posts: 222
Joined: 21 Dec 2007 16:33

Re: Patch: New passenger destinations

Post by trainmaster611 »

I'm having a little trouble with this patch. I'm running trains on an ABCD style route (and reverse). I have about 4 trains with identical orders. However, when a train arrives at Station A, and there are about 15 people headed for Station B, only about 2 or 3 will get on the train, and the rest stay in the station.

I don't understand. Why will they not board a train that lists there destination in its orders? All the trains follow the same route and have the same engine, so it should be the same speed. :?
Yexo
Tycoon
Tycoon
Posts: 3663
Joined: 20 Dec 2007 12:49

Re: Patch: New passenger destinations

Post by Yexo »

trainmaster611 wrote:I'm having a little trouble with this patch. I'm running trains on an ABCD style route (and reverse). I have about 4 trains with identical orders. However, when a train arrives at Station A, and there are about 15 people headed for Station B, only about 2 or 3 will get on the train, and the rest stay in the station.

I don't understand. Why will they not board a train that lists there destination in its orders? All the trains follow the same route and have the same engine, so it should be the same speed. :?
Do your trains have shared orders? If not, the patch will detect is as 4 different routes, and thus only 1/4 of the passengers goes on your train.
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: Patch: New passenger destinations

Post by Roest »

Also i doubt it makes much sense to report any errors/bugs. The original author of this patch has gone missing and i have no clue what's going on deep inside it. The code has changed quite a bit since the last released version of this patch and honestly i'm surprised it still compiled and does what it does.
User avatar
BlueEagle_nl
Transport Coordinator
Transport Coordinator
Posts: 352
Joined: 28 Jan 2006 09:44
Skype: tilly5014
Location: Tillywood, The Netherlands

Re: Patch: New passenger destinations

Post by BlueEagle_nl »

Is it possible to get this up to trunk again? Compiling on r12904 gave some errors in station.cmd.cpp, also read the post in your Patchpack for that...
MJS
Director
Director
Posts: 540
Joined: 28 Jul 2005 09:31

Re: Patch: New passenger destinations

Post by MJS »

How is the performance of this patch, generally? On my singlecore Pentium at 3 GHz with just 1GB of RAM, I am experiencing jolts at the start of every new day. They last up to 4 seconds. My guess is that's due to recalculation of the passenger destinations. It also occurs with passengers off but mail on, but not with both off. (By the way, I have the daylength patch on as well - would that influence the amount of time needed for calculations?)

Does anyone have suggestions to improve performance? Enabling or disabling the walking passengers helps only a bit, unfortunately.
PhilSophus
Chairman
Chairman
Posts: 776
Joined: 20 Jan 2007 12:08
Location: Germany

Re: Patch: New passenger destinations

Post by PhilSophus »

MJS wrote:(By the way, I have the daylength patch on as well - would that influence the amount of time needed for calculations?)
With daylength patch applied the autosave interval defaults to daily instead of monthly (which is not a good idea for low daylength factors). Maybe what you're noticing is the delay due to the autosave?
"The bigger the island of our knowledge, the longer the shore of our ignorance" - John A. Wheeler, Physicist, 1911-2008
MJS
Director
Director
Posts: 540
Joined: 28 Jul 2005 09:31

Re: Patch: New passenger destinations

Post by MJS »

I don't think so - the delay disappears when I turn paxdest off. Besides, I have manually set autosave to a lower interval, and it displays a message in the statusbar when saving, which isn't there during the daily delays... But thanks for your suggestion.
Touqen
Engineer
Engineer
Posts: 21
Joined: 09 May 2007 13:50
Location: Boston, MA, US

Re: Patch: New passenger destinations

Post by Touqen »

I'm working on bringing the patch back up to trunk. It's mostly there just ironing out a few kinks. It should be available in a day or two.

I know that there were some outstanding issues with the patch, but I haven't read through all the posts in this thread so if those could be summarized I could get to work on fixing/implementing them after the patch is up to trunk.
User avatar
prissi
Chief Executive
Chief Executive
Posts: 648
Joined: 15 Nov 2004 19:46
Location: Berlin, Germany
Contact:

Re: Patch: New passenger destinations

Post by prissi »

I honestly doubt that this patch will make it into the trunk, since it is even larger, eats more CPU and creates more questions than the last two attempts on this subject. Worse of all are the desync in multiplayer, which were also a show stopper for the last patch.

NB: The patch was updated by keeping obselete stuff alive. I have the impression, currently a major overhaul would be needed.
I like to look at great maps and see how things flow. A little like a finished model railway, but it is evolving and actually never finished. http://www.simutrans.com
User avatar
XeryusTC
Tycoon
Tycoon
Posts: 15415
Joined: 02 May 2005 11:05
Skype: XeryusTC
Location: localhost

Re: Patch: New passenger destinations

Post by XeryusTC »

I think this patch needs a complete rewrite for it to get even a remote chance to be included in trunk.
Don't panic - My YouTube channel - Follow me on twitter (@XeryusTC) - Play Tribes: Ascend - Tired of Dropbox? Try SpiderOak (use this link and we both get 1GB extra space)
Image
OpenTTD: manual #openttdcoop: blog | wiki | public server | NewGRF pack | DevZone
Image Image Image Image Image Image Image
Touqen
Engineer
Engineer
Posts: 21
Joined: 09 May 2007 13:50
Location: Boston, MA, US

Re: Patch: New passenger destinations

Post by Touqen »

Yea. It definitely needs a lot of help to get it trunk worthy. I'm just getting it up to trunk so that people can enjoy it and then will embark on the task of overhauling it so that it performs better and actually adheres to the coding guidelines.
User avatar
PouncingAnt
Transport Coordinator
Transport Coordinator
Posts: 357
Joined: 09 Nov 2004 22:33

Re: Patch: New passenger destinations

Post by PouncingAnt »

Personally I think if people stopped updating this patch, it would give everyone more motivation to create it again from scratch. :wink:
NB: the below challenges are still open for submission, so feel free to perform necromancy on them!
Try the PouncingAnt National Monopoly Challenge
Or even better, the PouncingAnt National Monopoly Challenge 2
Or better still, the PouncingAnt National Monopoly Challenge 3
Or, the PouncingAnt National Monopoly Challenge 4

Or try my scenario instead!

-(A lazy) OpenTTD Japanese Translator-
-(A lazy) PNGcodec user-
"You get what you pay for, so pay attention!"

Patches:
Company Station Stats
Touqen
Engineer
Engineer
Posts: 21
Joined: 09 May 2007 13:50
Location: Boston, MA, US

Re: Patch: New passenger destinations

Post by Touqen »

PouncingAnt wrote:Personally I think if people stopped updating this patch, it would give everyone more motivation to create it again from scratch. :wink:
In that case, I'll just do that.
bokkie
Transport Coordinator
Transport Coordinator
Posts: 327
Joined: 19 Jan 2007 19:26

Re: Patch: New passenger destinations

Post by bokkie »

I do like the walking passengers from the last attempt, because in this way it's possible to connect networks from different competitors. On the other hand, it should have a lower priority than getting a working and trunk-ready paxdestpatch and it can always be added later on.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 9 guests