[Patchpack] r24122 + some patches v0.04a

[bremerjoe]

Hi Handrake,
Thanks again for providing this patchpack and also binaries for noobs like me. One thing I was wondering whetehr it could be included but not sure whether any up to date patch exists for that. Could the amount of NewGRFs be increased? Not sure whether this would be interesting for you at all but considering the amazing stuff so many people are releasing for eyecandy, new vehicles, stations,... I always run into the limit.
I will search the forum and see whether I can find anything that could be helpful...


Actually found a thread about this very quickly and in the sixth posting even a patch was provided by Muzzly for exactly this function (singleplayer only to avoid problems in multiplayer).
http://www.tt-forums.net/viewtopic.php?f=31&t=37435

[Supercheese]

I would like to second the above request.

[bwong]

Excellent mate!
Can't wait to play around

EDIT: Is there an already compiled version of this?

And, point of inquiry, when you say "Listed in Order of inclusion" (first page), those patches are already included yes?

[handrake]

Hi Handrake,
Thanks again for providing this patchpack and also binaries for noobs like me. One thing I was wondering whetehr it could be included but not sure whether any up to date patch exists for that. Could the amount of NewGRFs be increased? Not sure whether this would be interesting for you at all but considering the amazing stuff so many people are releasing for eyecandy, new vehicles, stations,... I always run into the limit.
I will search the forum and see whether I can find anything that could be helpful...


Actually found a thread about this very quickly and in the sixth posting even a patch was provided by Muzzly for exactly this function (singleplayer only to avoid problems in multiplayer).
http://www.tt-forums.net/viewtopic.php?f=31&t=37435

If for SP only, it can be added. I'll take a look at it and see what I can do.

[handrake]

Excellent mate!
Can't wait to play around

EDIT: Is there an already compiled version of this?

And, point of inquiry, when you say "Listed in Order of inclusion" (first page), those patches are already included yes?

Thank you and yes. All the patches in the list are included. (except for ones in the 'to-do' list)

[Ottomobeale]

Can anyone re- post the win binary from 2b? (For the daylength patch)

I have been wanting to start a long with longer days game for quite some time now. After wasting hours trying to compile using the WIKI I guess I just stink at programming.

[handrake]

Can anyone re- post the win binary from 2b? (For the daylength patch)

I have been wanting to start a long with longer days game for quite some time now. After wasting hours trying to compile using the WIKI I guess I just stink at programming.

2b is still there in the download section. You just have to search for "all downloads". Nevertheless, I wouldn't recommend using it since some things just fall apart...

[Boye]

Hi!

I've discovered a bug in the timetables. When enabling the activate automatic timetable separation, my trains don't wait for timetables to start, when I have a start date set. I should also mention that I have turned off the automatic separation for that specific group of vehicles.

Another problem is that when setting a specific number of vehicles it sometimes automagically doubles.

If anything is unclear, please say!

[AndiK]

Hi Boye, thanks for reporting the start date bug. Handrake appears to have fixed it for his patch pack. I've noted it on my list for my own code.

Can you give an example of when and how the specific number of vehicles doubles? I accept savegames of handrake's pack, if neccessary.

Edit: Typo

[bwong]

Hi,
I'm not sure if this is the right place to say this, but the timetable patch doesn't seem to work for me.

When I go into the timetabling of the train, the drop down menu for the separation is greyed out (always on auto, I speculate). Furthermore, the schedule has been initializing for more than 5 game years..... Is that normal?

Thanks,

[handrake]

Hi,
I'm not sure if this is the right place to say this, but the timetable patch doesn't seem to work for me.

When I go into the timetabling of the train, the drop down menu for the separation is greyed out (always on auto, I speculate). Furthermore, the schedule has been initializing for more than 5 game years..... Is that normal?

Thanks,

Do you have at least 2 vehicles on a shared order with timetable autofilled?

[handrake]

Hi!

I've discovered a bug in the timetables. When enabling the activate automatic timetable separation, my trains don't wait for timetables to start, when I have a start date set. I should also mention that I have turned off the automatic separation for that specific group of vehicles.

Another problem is that when setting a specific number of vehicles it sometimes automagically doubles.

If anything is unclear, please say!

First, thank you for reporting. As for the first bug, I've confirmed, fixed and pushed to the repo. It will be included in the next version. However, I don't quite understand the second question because setting a number of vehicles is just there to help you calculate the approximate intervals between orders. For details, refer to the original post.

[Boye]

Hi!

I've discovered a bug in the timetables. When enabling the activate automatic timetable separation, my trains don't wait for timetables to start, when I have a start date set. I should also mention that I have turned off the automatic separation for that specific group of vehicles.

Another problem is that when setting a specific number of vehicles it sometimes automagically doubles.

If anything is unclear, please say!

First, thank you for reporting. As for the first bug, I've confirmed, fixed and pushed to the repo. It will be included in the next version. However, I don't quite understand the second question because setting a number of vehicles is just there to help you calculate the approximate intervals between orders. For details, refer to the original post.

The way I understood it is that you can set a number of vehicles, 6 for example, and the vehicles will be separated as if it were 6 (so the vehicles will be separated by 30 minutes on a 180 minute timetable, even if you have only 2). But sometimes the number will suddenly change to 12. I've never seen it changing, I only saw it had changed, so I don't know what causes it. I will try upload a savegame when I'm on my PC (I'm on a laptop now).

[bwong]

Hi,
I'm not sure if this is the right place to say this, but the timetable patch doesn't seem to work for me.

When I go into the timetabling of the train, the drop down menu for the separation is greyed out (always on auto, I speculate). Furthermore, the schedule has been initializing for more than 5 game years..... Is that normal?

Thanks,

Do you have at least 2 vehicles on a shared order with timetable autofilled?

Oh fail. Let me try that, and i'll update you really quickly

[handrake]

Updated to r24122 and added a few more patches. See the first post for details.

[Eisenbaehr]

Good Morning!

I had run an AI Test over night with r24122M (Patched r24122 with hpp-r24122-v0.04.diff compiled on MinGW/Windows XP) with many NewGRFs on a single player game (created from a relief).

First I had trouble to compile on MinGW. I added the following to the src/stdafx.h (see attachment).

Second I have two one assertion-failed errors.

In my environment the failure is not reproduceable (maybe through of the randomized behavior of the AIs).
The last autosave is from 06:02. I have seen the assertion-failed-error at 06:40. I have no idea when it was happend.
Autosaves creates OpenTTD every 1-3 minutes (3 months in game time, with fast forward).

It could also be possible this error was made by an AI or a NewGRF.

Thanks,
Robert

[Eisenbaehr]

Part3 and 4 and the needed newgrfs (because of board limitations).

[handrake]

Good Morning!

I had run an AI Test over night with r24122M (Patched r24122 with hpp-r24122-v0.04.diff compiled on MinGW/Windows XP) with many NewGRFs on a single player game (created from a relief).

First I had trouble to compile on MinGW. I added the following to the src/stdafx.h (see attachment).

Second I have two assertion-failed errors.

In my environment the failure is not reproduceable (maybe through of the randomized behavior of the AIs).
The last autosave is from 06:02. I have seen the assertion-failed-error at 06:40. I have no idea when it was happend.
Autosaves creates OpenTTD every 1-3 minutes (3 months in game time, with fast forward).

It could also be possible this error made an AI or a NewGRF.

Thanks,
Robert

Thank you for reporting. However, would you be so kind as to make sure that the errors occurred with my patch set applied? The attached crash.log tells me

Code: Select all

*** OpenTTD Crash Report ***
Date: 2009-08-29 00:34:21
Build: r15447M built on Feb 11 2009 23:10:31

which makes me wonder if there's a possibility you are actually playing r15447M which is ancient compared to the trunk...

[Eisenbaehr]

Oh yes. I attached an old crash.log-file. I have corrected the attachments.

> However, would you be so kind as to make sure that the errors occurred with my patch set applied?

I'm not sure. Take a notice to this comment.

> It could also be possible this error was made by an AI or a NewGRF.

You can estimate the problem better than me certainly.

[Dewin]

I can reproducibly crash this build of OpenTTD with this sequence of events:

1. Create a vehicle
2. Autofill its timetable and wait for the autofilling to complete
3. Ctrl-clone the vehicle to make 1 or more copies with shared orders and have the clones running.
4. Clone (without shared orders) the vehicle -- OTTD crashes.

I created a small 128x128 map with no newGRFs to make a quick test case, attached here.

Vehicle type appears to be irrelevant (I've had this happen with both trains and roadvehs). I suspect the issue is something in Slim Timetable Separation not being reinitialized correctly in the case of clone and orders lists being duplicated (as opposed to shared).

[Edits: I can't seem to upload the crash.log file, so copy/pasted here]

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Mon Apr 30 18:27:45 2012
In game date: 1930-07-24 (60)

Crash reason:
 Exception: C0000005
 Location:  004F978D
 Message:   <none>

OpenTTD version:
 Version:    h9a46f565 (0)
 NewGRF ver: 13005e3a
 Bits:       32
 Endian:     little
 Dedicated:  no
 Build date: Apr 23 2012 17:13:47

Registers:
 EAX: 00000000 EBX: 00000001 ECX: 04ED0D01 EDX: 02657361
 ESI: 04ED0DB8 EDI: 02694250 EBP: 0018F55C ESP: 0018F52C
 EIP: 004F978D EFLAGS: 00210206

 Bytes at instruction pointer:
 8B 58 0C 8B C6 E8 4E FF FF FF 84 C0 74 05 8B 4E 14 EB 03 83 C9 FF 8B 47

Stack trace:
 04ED0DB8 00000001 00000003 004F9875 00000003 04EF5C28 004F91AD 04ED0DB8
 00000000 02694250 00000001 02000001 0018F5A8 004FB6D1 02694250 40000005
 026948B0 00000000 02694250 0018F634 04ED0DB8 04DBF1E8 000000FF 00000000
 00000000 0001FFFF 00000000 00000004 0018F6D0 006F4DEC 00000000 0018F648
 0053D74A 00000001 40000005 00000001 00000000 00000000 00BF47D4 0D7C005A
 0018F6A0 0018F670 02694250 02694250 026948B0 00000001 026948B0 004FB391
 00000001 000033B3 026948B8 00000004 00000003 00000000 00000000 00000004
 000000FF 00000000 00000000 0001FFFF 00000000 00000001 0000136A 00000000
 0001FFFF 00000000 000000FF 00000000 00000000 0201FFFF 00000000 0018F6DC
 0040E031 00000001 00000001 00000000 00000000 00000670 00000330 00000000
 0000000C 0018F6A0 6F726A78 02DC4940 00000000 02DC477C 00000001 0000136A
 00000000 0001FFFF 00000000 00000001 0000136A 00000000 0001FFFF 00000000
 00C941C0 02DC0001 00BF47D4 00000280 00000020 00000084 0053CD38 00000000
 0001DD36 0018F874 006F4A2F 00000000 0018F884 0040DC39 0018F714 000033B3
 00000001 00000000 004DDFCA 00000000 00000000 000003CC 026948B0 026948B0
 00000000 00000000 00000000 00000001 00000016 00000000 00000000 0000001C
 00000011 0000000D 0000000D 9A101EBC 018504AB C910A73B 00000000 00000017
 0000000C 00381528 747D72B9 747D74BB 00381528 00000020 00381528 02010001
 00000000 0000029E 00000000 00381528 00000020 00000000 6F710B49 00381528
 00000084 00000000 020103CC 0018F7E0 00000000 00000000 00000084 00000000
 00381528 00000084 00000000 020103CC 00000004 000004B0 747D6A62 00000000
 00000001 00000001 00000000 00000000 00381528 0018F800 747D6A8C 012FE430
 00000000 00000020 00381528 02010001 0018F80C 747D6210 74840230 1DF30000
 0018F848 747D6B34 747D6B00 757FAA61 00381528 00000020 00000000 00000001

Operating system:
 Name:     Windows
 Release:  6.1.7601 (Service Pack 1)
 Compiler: MSVC 1600

Configuration:
 Blitter:      8bpp-optimized
 Graphics set: OpenGFX (974)
 Language:     D:\Openttd-Handrake\lang\english_US.lng
 Music driver: dmusic
 Music set:    OpenMSX (96)
 Network:      no
 Sound driver: win32
 Sound set:    NoSound (2)
 Video driver: win32

AI Configuration (local: 0):
  0: Human

Libraries:
 FreeType:   2.4.5
 ICU:        4.4.2
 LZMA:       5.0.3
 LZO:        2.05
 PNG:        1.5.4
 Zlib:       1.2.5

Module information:
 D:\Openttd-Handrake\openttd.exe handle: 00400000 size: 8917504 crc: B328E148 date: 2012-04-24 01:21:30
 C:\Windows\SysWOW64\ntdll.dll handle: 77080000 size: 1292080 crc: 00BA27E8 date: 2011-11-17 05:38:39
 C:\Windows\syswow64\kernel32.dll handle: 75A20000 size: 1114112 crc: 2FE5E9D5 date: 2011-07-16 04:24:22
 C:\Windows\syswow64\KERNELBASE.dll handle: 75D70000 size: 272384 crc: 145EBDEB date: 2011-07-16 04:24:22
 C:\Windows\system32\WINMM.dll handle: 724A0000 size: 194048 crc: 849223C7 date: 2010-11-20 12:21:36
 C:\Windows\syswow64\msvcrt.dll handle: 76430000 size: 690688 crc: DAB48B3A date: 2011-12-16 07:52:58
 C:\Windows\syswow64\USER32.dll handle: 747C0000 size: 833024 crc: 9EFE504D date: 2010-11-20 12:08:57
 C:\Windows\syswow64\GDI32.dll handle: 75DC0000 size: 311296 crc: 5F06BCCF date: 2010-11-20 12:08:51
 C:\Windows\syswow64\LPK.dll handle: 75A10000 size: 25600 crc: 3C6CC57C date: 2009-07-14 01:11:23
 C:\Windows\syswow64\USP10.dll handle: 75920000 size: 626176 crc: A5ECB486 date: 2010-11-20 12:21:33
 C:\Windows\syswow64\ADVAPI32.dll handle: 76270000 size: 640512 crc: 34D5363F date: 2010-11-20 12:18:02
 C:\Windows\SysWOW64\sechost.dll handle: 75890000 size: 92160 crc: B624B29A date: 2009-07-14 01:16:13
 C:\Windows\syswow64\RPCRT4.dll handle: 76180000 size: 663040 crc: D136A44D date: 2010-11-20 12:08:57
 C:\Windows\syswow64\SspiCli.dll handle: 74760000 size: 96768 crc: 996396FA date: 2011-11-17 05:28:48
 C:\Windows\syswow64\CRYPTBASE.dll handle: 74750000 size: 36864 crc: 00308E17 date: 2009-07-14 01:15:07
 C:\Windows\syswow64\WS2_32.dll handle: 74B80000 size: 206848 crc: FD00A753 date: 2010-11-20 12:21:38
 C:\Windows\syswow64\NSI.dll handle: 75C90000 size: 8704 crc: 2ACE9671 date: 2009-07-14 01:16:11
 C:\Windows\syswow64\SHELL32.dll handle: 74C40000 size: 12872704 crc: 21573EDA date: 2012-01-04 08:59:38
 C:\Windows\syswow64\SHLWAPI.dll handle: 758B0000 size: 350208 crc: 23E05F73 date: 2010-11-20 12:21:19
 C:\Windows\system32\IMM32.DLL handle: 76310000 size: 119808 crc: 38DB5163 date: 2010-11-20 12:08:51
 C:\Windows\syswow64\MSCTF.dll handle: 75CA0000 size: 828928 crc: DFE09EEB date: 2009-07-14 01:15:43
 C:\Windows\system32\SHFolder.dll handle: 71F80000 size: 7168 crc: 683AAC32 date: 2009-07-14 01:16:14
 C:\Windows\syswow64\ole32.dll handle: 75B30000 size: 1414144 crc: 74A1E844 date: 2010-11-20 12:20:49
 C:\Windows\system32\uxtheme.dll handle: 6F700000 size: 245760 crc: 60C5C746 date: 2009-07-14 01:11:24
 C:\Windows\system32\dwmapi.dll handle: 71050000 size: 67072 crc: FC7CA4B8 date: 2009-07-14 01:15:13
 C:\Windows\system32\mswsock.dll handle: 72670000 size: 232448 crc: 47C95B42 date: 2010-11-20 12:19:56
 C:\Windows\System32\wshtcpip.dll handle: 72050000 size: 9216 crc: BA963A19 date: 2009-07-14 01:16:20
 C:\Windows\system32\MMDevAPI.DLL handle: 6FED0000 size: 213504 crc: 93C0AA4F date: 2010-11-20 12:19:39
 C:\Windows\system32\PROPSYS.dll handle: 6C800000 size: 988160 crc: 888D0BCB date: 2010-11-20 12:20:57
 C:\Windows\syswow64\OLEAUT32.dll handle: 75E70000 size: 571904 crc: 2B85E126 date: 2011-08-27 04:26:27
 C:\Windows\system32\wdmaud.drv handle: 6FEA0000 size: 172032 crc: D5B9F5FA date: 2010-11-20 12:16:50
 C:\Windows\system32\ksuser.dll handle: 6FE90000 size: 4608 crc: EBE07232 date: 2009-07-14 01:15:35
 C:\Windows\system32\AVRT.dll handle: 6FE80000 size: 14336 crc: 9818237B date: 2009-07-14 01:14:58
 C:\Windows\syswow64\SETUPAPI.dll handle: 749E0000 size: 1667584 crc: 1D0104E8 date: 2010-11-20 12:21:14
 C:\Windows\syswow64\CFGMGR32.dll handle: 76090000 size: 145920 crc: 377B5190 date: 2011-05-24 10:39:38
 C:\Windows\syswow64\DEVOBJ.dll handle: 75E50000 size: 64512 crc: 66B02A5A date: 2011-05-24 10:40:05
 C:\Windows\system32\AUDIOSES.DLL handle: 6FE40000 size: 195584 crc: 0A7E52B1 date: 2010-11-20 12:18:05
 C:\Windows\system32\msacm32.drv handle: 6FE30000 size: 20992 crc: 73923147 date: 2009-07-14 01:14:08
 C:\Windows\system32\MSACM32.dll handle: 70C50000 size: 72192 crc: ABA25814 date: 2009-07-14 01:15:42
 C:\Windows\system32\midimap.dll handle: 6FE20000 size: 16896 crc: C000494C date: 2009-07-14 01:15:40
 C:\Windows\syswow64\CLBCatQ.DLL handle: 760C0000 size: 522240 crc: 6C130B8A date: 2009-07-14 01:15:03
 C:\Windows\System32\dmime.dll handle: 657A0000 size: 179712 crc: 179D7CFB date: 2009-07-14 01:15:12
 C:\Windows\System32\DSOUND.dll handle: 6C1C0000 size: 453632 crc: EC24F2F8 date: 2009-07-14 01:15:13
 C:\Windows\System32\POWRPROF.dll handle: 70C70000 size: 145408 crc: 9957ABF4 date: 2009-07-14 01:16:12
 C:\Windows\System32\dmusic.dll handle: 65670000 size: 101376 crc: F5D0AA6B date: 2009-07-14 01:15:12
 C:\Windows\syswow64\WINTRUST.dll handle: 76370000 size: 172544 crc: 739BA3AD date: 2012-03-01 05:37:41
 C:\Windows\syswow64\CRYPT32.dll handle: 75F70000 size: 1154048 crc: 61BB81F2 date: 2010-11-20 12:18:24
 C:\Windows\syswow64\MSASN1.dll handle: 77050000 size: 34304 crc: BE7DA129 date: 2010-11-20 12:19:45
 C:\Windows\System32\dmsynth.dll handle: 64CA0000 size: 105472 crc: 3B102040 date: 2009-07-14 01:15:12
 C:\Windows\System32\dmloader.dll handle: 65660000 size: 38400 crc: 8A3F45D2 date: 2009-07-14 01:15:12
 C:\Windows\syswow64\psapi.dll handle: 75910000 size: 6144 crc: 25B988F9 date: 2009-07-14 01:16:12

---- gamelog start ----
Tick 0: new game started
     Revision text changed to h9a46f565, savegame version 187, not modified, _openttd_newgrf_version = 0x13005e3a
     New game mode: 1 landscape: 0
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] openttd              0x004F978D
[01] openttd              0x004FB6D1
[02] openttd              0x0053D74A
[03] openttd              0x0040E031
[04] openttd              0x0040DC39
[05] openttd              0x0048A7DF
[06] openttd              0x004741C5
[07] openttd              0x00474485
[08] openttd              0x005FBAF8

*** End of additional info ***