Signal Auto-completion (no Signal GUI) Latest build: r5435

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Moriarty
Tycoon
Tycoon
Posts: 1395
Joined: 12 Jun 2004 00:37
Location: United Kingdom of Great Britain and Northern Ireland
Contact:

Post by Moriarty »

Ah. But this one just duplicates whatever the original signal is doesn't it? Thus gui free.
So is this in an condition to be added to the trunk?
PhilSophus
Chairman
Chairman
Posts: 776
Joined: 20 Jan 2007 12:08
Location: Germany

Post by PhilSophus »

Is anyone working on this?

Otherwise I would try to grab this out of MiniIN and to prepare a patch to the current trunk (just the auto-complete features, not the GUI). I am not, yet, very familiar with the OpenTTD sources, so I can not promise anything.

What would be the conditions to get it into trunk in near future, or is there no chance?
"The bigger the island of our knowledge, the longer the shore of our ignorance" - John A. Wheeler, Physicist, 1911-2008
User avatar
Aracirion
Traffic Manager
Traffic Manager
Posts: 241
Joined: 15 Jan 2006 15:15
Contact:

Post by Aracirion »

PhilSophus wrote:Is anyone working on this?

Otherwise I would try to grab this out of MiniIN and to prepare a patch to the current trunk (just the auto-complete features, not the GUI). I am not, yet, very familiar with the OpenTTD sources, so I can not promise anything.

What would be the conditions to get it into trunk in near future, or is there no chance?
ooh that would be very cool
PhilSophus
Chairman
Chairman
Posts: 776
Joined: 20 Jan 2007 12:08
Location: Germany

Post by PhilSophus »

So, that was easier than I thought.

I tested it only very shortly, but AFAICS it works including follow-up across tunnels and bridges and building under bridges.

Have fun.

EDIT: Updated to trunk revision 9054
EDIT: Updated to trunk revision 9579
Attachments
signal_autocomplete_r9579.diff
This is meant to be applied to a trunk version.
(22.73 KiB) Downloaded 300 times
"The bigger the island of our knowledge, the longer the shore of our ignorance" - John A. Wheeler, Physicist, 1911-2008
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

I have an other rediff against trunk r9796, but with 2 other Patches

link
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

Update to r9920

Edit 19. June 2007: update to r10213
Attachments
new_signal-auto-completion_r10213.patch
(17.31 KiB) Downloaded 228 times
new_signal-auto-completion_r10215.7z
Win32 executable
(905.02 KiB) Downloaded 197 times
Last edited by BamBam on 19 Jun 2007 13:56, edited 1 time in total.
doghousedean
Traffic Manager
Traffic Manager
Posts: 141
Joined: 30 Apr 2007 10:26

Post by doghousedean »

any chance of an updated diff please (r10115 is it?), i miss this feature a lot.

Thanks in advance

Dean
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

Here you are.

Regards,
BamBam

Edit 19. June 2007: download removed, new one see my post above
Last edited by BamBam on 19 Jun 2007 13:58, edited 1 time in total.
doghousedean
Traffic Manager
Traffic Manager
Posts: 141
Joined: 30 Apr 2007 10:26

Post by doghousedean »

BamBam=god :D

thanks
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

update, download see my post above
User avatar
rav
Traffic Manager
Traffic Manager
Posts: 253
Joined: 17 May 2007 13:36
Location: Netherlands
Contact:

Post by rav »

I seem to have noticed a bug/missing feature

when you have a piece of track without signals, which directly (without junctions) connects to a piece with signals, you used to be able to just 'auto complete' the part without signals, but now it gives an error: "No suitable railway track".. see screenshot
Attachments
commented screenshot.png
commented screenshot.png (275.55 KiB) Viewed 1143 times
narthollis
Engineer
Engineer
Posts: 2
Joined: 22 Jun 2006 07:33
Location: Adelaide, Australia
Contact:

Re: Signal Auto-completion (no Signal GUI) Latest build: r5435

Post by narthollis »

doesn't seam to be a problem with the in trunk version

on that, if your anything like me, you will probably not sure how to use autosignaling in the nightly/trunk builds - its quite simple realy, you need to ctrl+drag :) thats it :D
User avatar
rav
Traffic Manager
Traffic Manager
Posts: 253
Joined: 17 May 2007 13:36
Location: Netherlands
Contact:

Re: Signal Auto-completion (no Signal GUI) Latest build: r5435

Post by rav »

see the date on my post?
Thu Jun 28, 2007 8:48 am
before autocompletion got into trunk.. :)
chrissicom
Route Supervisor
Route Supervisor
Posts: 415
Joined: 07 Oct 2004 10:05

Re: Signal Auto-completion (no Signal GUI) Latest build: r5435

Post by chrissicom »

There are "missing features" with the trunk version though. An extreme example: You have a 100 tiles long track and set the patch option to place a signal every 4 tiles. Now imagine that you have RRRBBRRBBRRBB.... so the 4th tile is always a bridge while the rest is rail then the in trunk version won't place a single signal because the place where it should be is blocked by a bridge. This old patch would detect such things or for example when there are only 3 tiles left before a junction it will detect it and place a signal on the last tile as well. This feature is even more important when the drag singal option is set to let's say 8 or more tiles. I assume that this requires a lot of code and therefore isn't in the trunk version. But maybe an "enhancing patch" could fix that. When I have some time I look at the old and new code and see if I can cook a good menu :D
narthollis
Engineer
Engineer
Posts: 2
Joined: 22 Jun 2006 07:33
Location: Adelaide, Australia
Contact:

Re: Signal Auto-completion (no Signal GUI) Latest build: r5435

Post by narthollis »

rav wrote:see the date on my post?
Thu Jun 28, 2007 8:48 am
before autocompletion got into trunk.. :)
hehehe, yeah - didnt look that closely :p
chrissicom wrote:There are "missing features" with the trunk version though. <snip> But maybe an "enhancing patch" could fix that. When I have some time I look at the old and new code and see if I can cook a good menu :D
Hehehe, good point, and good idea :) - looking forward to seeing your work :D
might look into that myself
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 7 guests