Daylength Patch [12/09/2008] Compatibility: r14293

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Which daylength are you playing at?

1-5
53
41%
6-15
27
21%
15+
50
38%
 
Total votes: 130

User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

Here, a windows binary with daylength, r14661.
I can get a linux one if anyone needs that one too.

Also attached, .diff file against r14661.... not tested though, so no guarantees it'll patch alright.

Edit: files removed due to mistake on my part, see updated files a few posts on
Last edited by Gremnon on 08 Dec 2008 17:15, edited 1 time in total.
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

Thanks, but when i open the advanced settings this error comes up:
Attachments
error1.PNG
error1.PNG (16.39 KiB) Viewed 3433 times
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

Odd. Could just be the way I patched, it, I'll re-patch and make sure of it...
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

New version of windows binary and diff, both untested.
It *should* work this time, but can't say for sure on the diff.
Attachments
r14660-daypatch.diff
Diff against r14660
(9.6 KiB) Downloaded 144 times
r14660-daypatch.zip
r14660 with daylength
(3.42 MiB) Downloaded 146 times
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

At the moment it works fine, thank you very much!!! Will keep you update if any failure comes up.
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

When i try to save it give's the next error:
Attachments
error2.PNG
error2.PNG (15.26 KiB) Viewed 3392 times
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

Now that one's strange, since I didn't need to change anything in saveload.cpp, and I don't have any trouble.
I'll experiment a bit more, but I can't guarantee a fix for this one, because I'm not entirely certain what's gone wrong this time.
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

If i choose ignore in the error he saves it, but loading again is unpossible, savegame broken unknown chunk type is the message then.
SmatZ
OpenTTD Developer
OpenTTD Developer
Posts: 351
Joined: 03 Oct 2006 18:26
Location: Prague, Czech Republic
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by SmatZ »

Attached patch includes the fix for your asserts, but it is based on Gremnon's patch, so it may be broken.
(of course it is broken, the patch misses many places that should be tweaked... and it doesn't fix other problems I mentioned in http://www.tt-forums.net/viewtopic.php?p=748441#p748441 - so expect strange behaviour regarding for example vehicle running costs, AI starting at "random" moments, ... )
Attachments
r14662-daypatch.diff
(10.76 KiB) Downloaded 146 times
Image
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

Ok, i right click SVN map on computer and choose aplly patch, then in the merge window choose patch all and then you see this pic, all file nicelay in black (first time), but then what ???

Sorry, but understand really nothing about this patching...
Attachments
nowwhat.PNG
nowwhat.PNG (78.35 KiB) Viewed 1415 times
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

Then you need to compile it... the OpenTTD wiki can tell you everything you need to know about that for any system...
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

Ok i'm gonna try with cygwin, but what do i need to compile? Do i need to save the file in tortoisemerge and the compile, or do i need to compile the files in my SVN map that have a red icon in stead of a green one ????
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

Ok im halfway point number 9 of the wiki page of cygwin. i made the dir and opened it, but then the commands won't work ???
Attachments
sofarsogoodbutthen.PNG
sofarsogoodbutthen.PNG (34.22 KiB) Viewed 1415 times
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

hm... I think you need to get the subversion files, but I'm not sure, I don't use cygwin, I use the msys that comes with BOTTD... updated with a few additions of my own, because I compile other programs with it sometimes too.
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

Still not got patching working, not with cygwin and not with Visual CC+ ...

Somebody with a recent working bin with this patch included ?
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

I'll compile one against the current nightly in a moment, check back in 10 and I should have posted it here...
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

Windows binary against r14665
Untested, but patched and compiled with no troubles with SmatZ's (hopefully) fixed version of the .diff.
Attachments
r14665-daypatch.zip
(3.42 MiB) Downloaded 177 times
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

It works! It works! It works! Thank you :bow: :bow: :bow:


(I mean, no error when opening advances settings, no error when saving or loading, like the previous try's)(keeping my fingers crossed) :)
User avatar
Hamilton2007
Transport Coordinator
Transport Coordinator
Posts: 289
Joined: 16 Nov 2008 10:57
Location: Belgium

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Hamilton2007 »

I got the following errors when playing. Most of the time it happens when i zoom out maximum and look around then. I save my game every month now, so i can play the savegame, the errors come from time to time, not everytime on the same point in the savegame.
Attachments
error1.PNG
error1.PNG (15.3 KiB) Viewed 3030 times
error2.PNG
error2.PNG (15.35 KiB) Viewed 3034 times
error3.PNG
error3.PNG (7.16 KiB) Viewed 3035 times
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [12/09/2008] Compatibility: r14293

Post by Gremnon »

I solved that one - at least for the moment - by increasing the sprite cache in the openttd.cfg
I'm not entirely certain that's the best fix though, but I'll look into it when I have some time
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 16 guests