Gonozal_VIII patchpack r12180

[chrissicom]

- I can't click on an intercontinental Airport without a hard crash of openttd.

That sounds very similar to my clicking on train station crash. I couldn't figure out yet what's the cause because I can't get the .diff from here to compile to a clean debug build.

[PhilSophus]

Bugs on Multiplayer Session:
- I can't click on an intercontinental Airport without a hard crash of openttd.

Maybe this can help you.

[chrissicom]

Could you post a pre-built version with this patch built-in? That would be awesome!

[Indiana]

Don't need to be prebuild, just include the new PAXDest

[broodje]

I'm trying to build a version of my own, including only Daylenght, YAPBS, Timetable separation and distant join stations. For some reason Visual express 2008 keeps trowing up errors when I try to build:

Code: Select all

..\src\economy.cpp(1224) : error C2666: 'OverflowSafeInt::operator /' : 4 overloads have similar conversions
        with
        [
            T=int64,
            T_MAX=0x7fffffffffffffff,
            T_MIN=0x800000000
        ]
        e:\source\src\core/overflowsafe_type.hpp(92): could be 'OverflowSafeInt OverflowSafeInt::operator /(const uint) const'
        with
        [
            T=int64,
            T_MAX=0x7fffffffffffffff,
            T_MIN=0x800000000
        ]
        e:\source\src\core/overflowsafe_type.hpp(91): or       'OverflowSafeInt OverflowSafeInt::operator /(const int) const'
        with
        [
            T=int64,
            T_MAX=0x7fffffffffffffff,
            T_MIN=0x800000000
        ]
        e:\source\src\core/overflowsafe_type.hpp(90): or       'OverflowSafeInt OverflowSafeInt::operator /(const OverflowSafeInt &) const'
        with
        [
            T=int64,
            T_MAX=0x7fffffffffffffff,
            T_MIN=0x800000000
        ]
        or       'built-in C++ operator/(int64, byte)'
        while trying to match the argument list '(Money, byte)'

Is there a way I can find out what is causing this problem?

[PhilSophus]

Is there a way I can find out what is causing this problem?

The compiler does not find a division operator matching exactly the types given, but 4 operators it can reach by a conversion, but it doesn't know which of them to take. Try casting the second argument of the division (i.e. the divisor) to either uint, int or Money. All of them should work. The fourth (which would require casting the first argument to int64) is no good choice. I wonder why gcc can resolve it and whether VE2008 or gcc is right according to the C++ standard.

[trainmaster611]

Is it possible that someone could release the full r12180 package with this patch already applied, or is there something that prevents that from happening?

[leno4]

Is it possible that someone could release the full r12180 package with this patch already applied, or is there something that prevents that from happening?

It is possible, i would love that too.

[Trond]

what patch? The patchpack have already a win32 binary fro r12180 on page 1... Or did you want just one patch of the lot or?

[Two5Kid]

I need to ask this, if I were to add one of the nightlies onto this patch, (in order to play with the Canadian Set for OTTD), would I remove any of Gonozal's features, most importantly the PBS and dynamic engines?

[trainmaster611]

what patch? The patchpack have already a win32 binary fro r12180 on page 1... Or did you want just one patch of the lot or?

Ok, I'm a little confused. Are you saying that that link that says r12180 built with BOTTD, already has the patch applied to it?

[Trond]

Ok, I'm a little confused. Are you saying that that link that says r12180 built with BOTTD, already has the patch applied to it?

Yes. All the patches listed in the 1st page.

[Tekky]

I need to ask this, if I were to add one of the nightlies onto this patch, (in order to play with the Canadian Set for OTTD), would I remove any of Gonozal's features, most importantly the PBS and dynamic engines?

I'm afraid it won't be easy to apply the patch to the latest nightly build, because I'm afraid automatic patching will fail in several places so you will have to patch these places manually, which requires programming knowledge and is a lot of work.

[sickie]

...I'm afraid automatic patching will fail in several places so you will have to patch these places manually,...

It's time that Gonzal_VIII would do it, apply his patchpack to fresh nightlies and update patches that has been updataded in the meantime.

[broodje]

Thanks PhilSophus, unfortunately I can't code in c++. I guess I will try out GCC someday to apply the patches.

[zypa]

Will new patches be integrated in this patchpack? I'd love to see the grassgrowth patch in here

[Tekky]

...I'm afraid automatic patching will fail in several places so you will have to patch these places manually,...

It's time that Gonzal_VIII would do it, apply his patchpack to fresh nightlies and update patches that has been updataded in the meantime.

I don't consider your tone appropriate. Instead of demanding that Gonozal should invest more work into his patchpack ("It's time that..."), it would be more meaningful that you thank him for his previous work and kindly ask if he or someone else could update the patchpack, or do it yourself if you have the programming knowledge.

[leno4]

Downloaded the already compiled rar. Got this error.

[glx]

Easy to fix. Modify difficulty settings in intro, and exit openttd. It will be ok on next start.

[el koeno]

...I'm afraid automatic patching will fail in several places so you will have to patch these places manually,...

It's time that Gonzal_VIII would do it, apply his patchpack to fresh nightlies and update patches that has been updataded in the meantime.

I don't consider your tone appropriate. Instead of demanding that Gonozal should invest more work into his patchpack ("It's time that..."), it would be more meaningful that you thank him for his previous work and kindly ask if he or someone else could update the patchpack, or do it yourself if you have the programming knowledge.

Well, non-native speakers sometimes get the intonation wrong, perhaps that was the problem. And of course he's thankful for Gonozal's work, other wise he wouldn't be back for a new version!

I do sort of agree with sicky though; I would like to see new versions of several patches (PAXdest and YAPP) to be included. But I guess I can wait, as it would only break my current savegame which I would like to continue playing a bit more. I could of course use that time to learn to code and do it myself, but I get distracted from uni by playing ttd, I don't think learning to code would work any differently.