Patch: Industry budgets

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
antichaos
Engineer
Engineer
Posts: 42
Joined: 13 Feb 2007 21:51
Location: UK

Post by antichaos »

First post updated with new patch and binary version 0.4

Please note that due to a bug with the save info in the previous version, saved games will cause asserts with the new version. Sorry.

Spreading passengers between nearby industries isn't in this version. I'll probably do it as a separate patch, as it might be useful in trunk.

Update: now 0.4.1. Sorting out the passenger acceptance when using budgets has been a real pain, and there are still problems. If there is another industry within the catchment area of your station with a positive budget, then the station will always accept and pay you for passengers, regardless of the budget of the industry you are trying to deliver to. The passengers won't go into the industry workforce though, you're just getting paid when you shouldn't. Smarter handling of industries near stations should solve this, so that will be the next project.

I've also had a request that the workforce be allowed to return home after their hard work. I will add this in, probably with a patch option, as long as you promise to deliver them back to a town, rather than just moving them from one industry to the next to the next. That feels to me like a cheat, but I can't think of any way to prevent it (until we have newcargos).
User avatar
antichaos
Engineer
Engineer
Posts: 42
Joined: 13 Feb 2007 21:51
Location: UK

Post by antichaos »

Patch updated to version 0.5. Now includes cargo sharing between industries within (and only in) a station's catchment area. There's a patch option for this if you prefer the old behavior. If you don't like all the text telling what has been accepted and rejected at industries, you can turn it off in the interface patch settings.

It's getting late, but tomorrow I'll update the first post with a binary, full list of changes, and more explanation of the sharing behavior (as it can appear odd).

Edit: First post now updated.
Attachments
industry_budgets_0.5_9580.diff
Industry budgets and workforce v0.5 built against r9580
(59.25 KiB) Downloaded 212 times
Last edited by antichaos on 10 Apr 2007 10:25, edited 1 time in total.
User avatar
CMircea
Chairman
Chairman
Posts: 887
Joined: 29 Dec 2006 14:05

Post by CMircea »

I'll compile the binary for you.

EDIT: Here it is.
Attachments
Industry Budgets.zip
Win32 Binary
(1.87 MiB) Downloaded 233 times
User avatar
antichaos
Engineer
Engineer
Posts: 42
Joined: 13 Feb 2007 21:51
Location: UK

Post by antichaos »

First post updated with a bugfix. The diff also resolves merging problems caused by the recent savegame bump in trunk.
Elves
Engineer
Engineer
Posts: 16
Joined: 27 Jul 2003 19:33

Post by Elves »

Very nice idea, but I don't get one thing.

I have one train route, it's pretty long. My train is transporting coal (160 tonnes) and it's earning very little - only 3914$ per ride. Running costs are high so the train actually brings loses.

Do I do something wrong, is this a bug?

Thank you.
Attachments
Funby Bridge Transport, 16th Feb 1941.png
Funby Bridge Transport, 16th Feb 1941.png (208.41 KiB) Viewed 1724 times
Elves
Engineer
Engineer
Posts: 16
Joined: 27 Jul 2003 19:33

Post by Elves »

I am using tha latest build (9621 + industry budgets 0.5.1).
User avatar
antichaos
Engineer
Engineer
Posts: 42
Joined: 13 Feb 2007 21:51
Location: UK

Post by antichaos »

Elves wrote:I have one train route, it's pretty long. My train is transporting coal (160 tonnes) and it's earning very little - only 3914$ per ride. Running costs are high so the train actually brings loses.

Do I do something wrong, is this a bug?
I'd need to see the finance windows for the coal mine and power station. Could you post a savegame?
Elves
Engineer
Engineer
Posts: 16
Joined: 27 Jul 2003 19:33

Post by Elves »

I have prepared another save game, because the first one uses a lot of grfs.

Here is similar situation. Running costs are much lower (6000$ a year), but the train barely earns any money.
Attachments
Windway Transport, 27th Jul 1941.zip
(82.74 KiB) Downloaded 218 times
fabca2
Transport Coordinator
Transport Coordinator
Posts: 312
Joined: 14 Apr 2004 15:18
Location: Fr

Post by fabca2 »

Elves wrote:I have prepared another save game, because the first one uses a lot of grfs.
by the way, I'm interrested to know which GRF you are using to have this grass ?

thank you.
Ps : sorry for off topic.
Leviath.NL
Traffic Manager
Traffic Manager
Posts: 152
Joined: 28 Jan 2006 15:00

Post by Leviath.NL »

fabca2 wrote:
Elves wrote:I have prepared another save game, because the first one uses a lot of grfs.
by the way, I'm interrested to know which GRF you are using to have this grass ?

thank you.
Ps : sorry for off topic.
http://tt-forums.net/viewtopic.php?t=31079
User avatar
antichaos
Engineer
Engineer
Posts: 42
Joined: 13 Feb 2007 21:51
Location: UK

Post by antichaos »

Ok, I'm an idiot. Seems I posted the old 0.5 version as 0.5.1. I've updated the first post with a new patch and binary.

Thanks for letting me know.
User avatar
antichaos
Engineer
Engineer
Posts: 42
Joined: 13 Feb 2007 21:51
Location: UK

Post by antichaos »

First post updated with version 0.5.3 patch and binary. Although this is numbered as a bugfix it contains some significant changes to the workforce behavior. Passengers now want to go home after their hard day's work, and you only get paid for those you deliver home. Remember that if you deliver far more passengers than can be used each month, some of them will disappear, which means that you won't be able to get income for taking those home. As with the rest of this patch, the challenge is to match your transport rates to the needs of the industry.
Ari Rahikkala
Engineer
Engineer
Posts: 3
Joined: 20 Apr 2007 16:41
Contact:

Post by Ari Rahikkala »

Hi. I'm using both patches, trying to make some profitable farms. I fed them workers with trains in one game, buses in another, and had a couple of trains with two or three grain and livestock cars waiting to get full loads and deliver them to factories. Now, firstly, it took absolutely forever to just fill the cars - having to use workforce really makes industry a very weak source of income early on - but worse, I couldn't really get the farm to profit for longer than a couple of months. It could profit pretty nicely at first, getting a balance in the 30,000 range and a bugdet somewhere around 20,000 at best, but eventually the costs would exceed the income seemingly no matter what I did and the budget would start going down (thus making it even more difficult to get any decent amount of employees in).

Am I doing something wrong or is there a reason why it's so difficult to actually get the normal production out of a farm?

Also, a bug: When I'm placing a station (i.e. the cursor is a station icon), the industries in the preview coverage area get some passengers, possibly those that are unloaded at stations with no industries around.
User avatar
antichaos
Engineer
Engineer
Posts: 42
Joined: 13 Feb 2007 21:51
Location: UK

Post by antichaos »

First post updated with a new version.
Ari Rahikkala wrote:Am I doing something wrong or is there a reason why it's so difficult to actually get the normal production out of a farm?
My bad sorry. My attempt to make income sharing a bit smarter was badly bugged. It should be fixed now. Bear in mind that an industry still has to have produced some cargo in the last year in order to receive income. Try the new version and if you're still having problems, post a savegame.

Those who are actually looking at the patch code might notice that 'wants_payment' industry property is now unused. I've left it in for now so as not to break savegame compatibility.
Ari Rahikkala wrote:Also, a bug: When I'm placing a station (i.e. the cursor is a station icon), the industries in the preview coverage area get some passengers, possibly those that are unloaded at stations with no industries around.
I've seen this, but haven't spent any time trying to understand why it happens. Is it causing problems, or can we just call it a bonus?

The attached scenario is for masochists only. Budget levels are set at their absolute minimum. You'll have to micromanage vehicle arrivals in order to get the budgets going at all. Good luck.
Attachments
Challenge.scn
Challenge scenario
(20.61 KiB) Downloaded 239 times
User avatar
antichaos
Engineer
Engineer
Posts: 42
Joined: 13 Feb 2007 21:51
Location: UK

Post by antichaos »

First post updated with new patch and binary. No new features, just bringing the patch up to date with recent changes in trunk.
User avatar
antichaos
Engineer
Engineer
Posts: 42
Joined: 13 Feb 2007 21:51
Location: UK

Post by antichaos »

Bad news Industry Budget & Workforce fans. The changes to industries in 9866, 9867, 9868 conflict pretty seriously with the industry budgets patch. The time it would take to recode the patch to take account of the changes is rather more than I have at the moment, so this patch is on hold for the time being.

I'll try and take another look at it once the industry code has settled down a bit.
User avatar
belugas
OpenTTD Developer
OpenTTD Developer
Posts: 1507
Joined: 05 Apr 2005 01:48
Location: Deep down the deepest blue
Contact:

Post by belugas »

I will let you know when newindustries will be completed. Really sorry for the mess...
If you are not ready to work a bit for your ideas, it means they don't count much for you.
OpenTTD and Realism? Well... Here are a few thoughs on the matter.
He he he he
------------------------------------------------------------
Music from the Bloody Time Zones
Eisenbaehr
Engineer
Engineer
Posts: 62
Joined: 29 May 2006 06:59
Location: Germany

Post by Eisenbaehr »

OffTopic:
Elves wrote:Very nice idea, but I don't get one thing.

I have one train route, it's pretty long. My train is transporting coal (160 tonnes) and it's earning very little - only 3914$ per ride. Running costs are high so the train actually brings loses.

Do I do something wrong, is this a bug?

Thank you.
Very nice scenario at the picture you have posted!
http://www.tt-forums.net/download.php?id=69052

It rember me to RollerCoaster Tycoon lol - green grass, many trees, and in the middle a little bus and a trainstation.



OnTopic:

To the autor of this patch: I will bring together your patch with the passenger patch. To get more informations about this you will see in the main-topic.

Because to the differents between revisions to OpenTTD I need a revision of your patch around r9739.
You have listed all your revisions at the first page and because of this.
It is possible to send me any revision of your patch?
It would be very useful for me.
User avatar
antichaos
Engineer
Engineer
Posts: 42
Joined: 13 Feb 2007 21:51
Location: UK

Post by antichaos »

Eisenbaehr wrote:Because to the differents between revisions to OpenTTD I need a revision of your patch around r9739.
You have listed all your revisions at the first page and because of this.
It is possible to send me any revision of your patch?
It would be very useful for me.
I have retained diffs off all the versions posted. Attached is the diff for version 0.5.4 against r9693. As mentioned in the first post the only change between that and the most recent is stuff to fix savegame compatibility. You should be able to bring that up to 9739 no problem.
Attachments
industry_budgets_0.5.4_9693.diff
(100.33 KiB) Downloaded 148 times
aepurniet
Engineer
Engineer
Posts: 9
Joined: 13 Nov 2007 14:42

Re: Patch: Industry budgets

Post by aepurniet »

is this patch still being worked on? i checked out the binary and it seems like a ton of fun. i ussually play chris's in distro, and would love to get a copy of this integrated. i haven't set up a build system, and im not sure this patch would still be applicable to the current builds. would it be worth doing that?
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 10 guests