NewGRF Livery Selection/Cargo Subtypes (GRF Callback 19)

bobingabout · Post by **bobingabout** » 19 May 2006 10:45

also, this doesn't let players have different sets of engines or carages, just paint them differently...

and instead of real liveries, i'd like to see more alternate combinations of the 2 colours, unfortunatly, OTTD players won't see the effect yet.

and, 1 more thing, is it possable to add a preview window in the refit screen? so we can see what our train looks like BEFORE we refit it?

Bjarni · Post by **Bjarni** » 19 May 2006 11:00

bobingabout wrote:also, this doesn't let players have different sets of engines or carages, just paint them differently...

and instead of real liveries, i'd like to see more alternate combinations of the 2 colours, unfortunatly, OTTD players won't see the effect yet.

planned feature, that might not be that far into the future. Note: might. I didn't promis anything about time here.

bobingabout wrote:and, 1 more thing, is it possable to add a preview window in the refit screen? so we can see what our train looks like BEFORE we refit it?

that should be possible

bobingabout · Post by **bobingabout** » 19 May 2006 11:08

Bjarni wrote:
bobingabout wrote:also, this doesn't let players have different sets of engines or carages, just paint them differently...

and instead of real liveries, i'd like to see more alternate combinations of the 2 colours, unfortunatly, OTTD players won't see the effect yet.
planned feature, that might not be that far into the future. Note: might. I didn't promis anything about time here.

which one? multiple GRFs with different engines for different players, or 2 colours instead of liveries?

because i already know peter(i think its peter) is working on the 2 colours thing. thats why i used the word "Yet".

Bjarni · Post by **Bjarni** » 19 May 2006 11:11

bobingabout wrote:
Bjarni wrote:
bobingabout wrote:also, this doesn't let players have different sets of engines or carages, just paint them differently...

and instead of real liveries, i'd like to see more alternate combinations of the 2 colours, unfortunatly, OTTD players won't see the effect yet.
planned feature, that might not be that far into the future. Note: might. I didn't promis anything about time here.
which one? multiple GRFs with different engines for different players, or 2 colours instead of liveries?

because i already know peter(i think its peter) is working on the 2 colours thing. thats why i used the word "Yet".

2 company colours

mart3p · Post by **mart3p** » 19 May 2006 11:23

bobingabout wrote:1 more thing, is it possable to add a preview window in the refit screen? so we can see what our train looks like BEFORE we refit it?

That would be useful but of course would need a complete redesign of the refit window. My intention with this patch was to give OTTD the same functionality as TTDPatch, enhancements can be added later.

mart3p · Post by **mart3p** » 19 May 2006 22:13

Another update, new patch against r4916 is in the first post.

Fixed: I found that the cargo subtype wasn't being set for cloned vehicles. This has now been corrected.

Added: Cargo subtype suffixes are now displayed in the vehicle details window (see screenshot).

Wolf01 · Post by **Wolf01** » 20 May 2006 07:30

is possible to automatically refit wagons like TTDPatch?
when you buy wagons and the engine is already present on the same line (do you know that if there are two engines the wagons are placed on an empty line) the wagons are refitted with the engine's correct liverie automatically

DaleStan · Post by **DaleStan** » 20 May 2006 07:55

That's a function of type 82 varactions and/or livery overrides, not CB19.

If the engine supports CB19, the wagons can be caused to change according to the engine's refit, but this is a result of the wagons' use of type 82 varactions, not the engine's use of CB19.

mart3p · Post by **mart3p** » 20 May 2006 08:14

Wolf01 wrote:is possible to automatically refit wagons like TTDPatch?

As DaleStan points out, what you are asking for is controlled by type 82 varactions, this should already work in OTTD.

As an example, with Born Acorn's IC125 (see first post), when a livery refit is selected for the engine, any passenger carriages change to the same livery. Any further carriages that are then added will also change to the engine's livery.

Grigory1 · Post by **Grigory1** » 22 May 2006 13:21

At me in the list of purchases OpenTTD (above) and TTDP are (below) visible different sprites.
In what a problem?

mart3p · Post by **mart3p** » 22 May 2006 14:01

Hi Grigory, this is a bug in the trunk code, not in my patch. I have already mentioned the problem to peter1138 and he has some code that fixes it. We just need to wait until his code is added to the trunk.

Please let me know if you find any other problems with your planes in OTTD.

Born Acorn · Post by **Born Acorn** » 22 May 2006 20:48

Lets poke peter1138 to merge this patch with trunk!

Grigory1 · Post by **Grigory1** » 23 May 2006 12:22

mart3p wrote:Hi Grigory, this is a bug in the trunk code, not in my patch. I have already mentioned the problem to peter1138 and he has some code that fixes it. We just need to wait until his code is added to the trunk.

Please let me know if you find any other problems with your planes in OTTD.

OK! We shall wait

Gratitude for patches that enables to use my planes written for TTDP, and also at me (partially there is no button refit

) have earned some versions George's Long vehicles!!!

Post by **peter1138** » 23 May 2006 12:44

Yeah, I've been toying with two ideas on this:

1) Make yet another copy of the refit command and gui, to implement road vehicle refitting.

2) Merge all refit commands and gui parts into one super-mega-refit-command & gui.

I'm edging for the latter, as it reduces code duplication, although there will then be special cases for aircraft.

mart3p · Post by **mart3p** » 23 May 2006 19:27

Grigory1 wrote:Gratitude for patches that enables to use my planes written for TTDP

Thanks...

Your aircraft were one of my reasons for making the patch.

mart3p · Post by **mart3p** » 24 May 2006 12:06

Grigory1 wrote:
mart3p wrote:Hi Grigory, this is a bug in the trunk code, not in my patch. I have already mentioned the problem to peter1138 and he has some code that fixes it. We just need to wait until his code is added to the trunk.
OK! We shall wait

Grigory, the bug in the vehicle purchase list was fixed at r4960. Thanks peter1138.

gkirilov · Post by **gkirilov** » 24 May 2006 13:25

Is it me ..or those planes are not placed correctly (a little shifted)? I mean on the airport.

mart3p · Post by **mart3p** » 24 May 2006 20:09

gkirilov wrote:Is it me ..or those planes are not placed correctly (a little shifted)? I mean on the airport.

Yes your right but they're also shifted in TTDPatch (see screenshot) although (strangely), not by quite the same amount.

I've found another problem though: Grigory, do you know that your 777_gr_107.grf and Tu-154_gr.grf are both using the same GRF ID - 47540610. In OTTD this causes both planes to use the same strings in the livery refit list.

Grigory1 · Post by **Grigory1** » 24 May 2006 20:12

Thanks mart3p! Thanks peter1138!
Good work

gkirilov
Is it me ..or those planes are not placed correctly (a little shifted)? I mean on the airport.

I coded it for airports TTD, in Open TTD planes are placed a little on another, and at the different airports on a miscellaneous

mart3p
I've found another problem though: Grigory, do you know that your 777_gr_107.grf and Tu-154_gr.grf are both using the same GRF ID - 47540610. In OTTD this causes both planes to use the same strings in the livery refit list.

I shall correct in file Tu-154_gr.grf

bobingabout · Post by **bobingabout** » 25 May 2006 08:40

that reminds me... the build new vehicle windows need the text part extending a few lines, in OTTD with UKRS there are a few vehicles where the text uses 1 too many lines, and overlaps with the buttons so you can't read what it says, also adding that "refitable to:" line would be usefull, because unless you've played before, its hard to tell what cargo types each vehicle can carry.

Transport Tycoon Forums

NewGRF Livery Selection/Cargo Subtypes (GRF Callback 19)

Who is online