Clone vehicle patch (version 14)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Bjarni
Tycoon
Tycoon
Posts: 2088
Joined: 08 Mar 2004 13:10

Post by Bjarni »

StarLite wrote:Well, I patched my 2130 build with it and tried it in a multiplayer game;
"a protocol error was made and the connection was closed"
I guess that will have to be fixed [or the server has to be patched as well?]
I will say this only once: this is a modified client, which will not be able to play in multiplayer games with unmodified clients/servers.
If you want to play in multiplayer, you will have to use this patch on all computers
Bjarni
Tycoon
Tycoon
Posts: 2088
Joined: 08 Mar 2004 13:10

Post by Bjarni »

version 5 uploaded
now it works for all kinds of vehicles and should be compatible with lng files from the nightly build
User avatar
Emeric Pro
Engineer
Engineer
Posts: 107
Joined: 23 Feb 2003 23:42
Location: Toulouse, France
Contact:

Post by Emeric Pro »

Bjarni wrote:version 5 uploaded
now it works for all kinds of vehicles and should be compatible with lng files from the nightly build
hmmm... i just tested it (r2144 with this exe file), and i found out that it does not work for all kinds of vehicles...
for trains and boats, it works exactly as intended, perfect, great work, thanks and even :bow: , i really needed that feature
but for trucks - and as i saw after also for planes - it has two small bugs :
- orders are not copied (which is the most important piece when it comes to make a truck route with 10 trucks)
- the vehicke window does not pop up as it does for trains & boats (useful to start them quickly)
It would be better if i was gliding
Image
Bjarni
Tycoon
Tycoon
Posts: 2088
Joined: 08 Mar 2004 13:10

Post by Bjarni »

Emeric Pro wrote:
Bjarni wrote:version 5 uploaded
now it works for all kinds of vehicles and should be compatible with lng files from the nightly build
hmmm... i just tested it (r2144 with this exe file), and i found out that it does not work for all kinds of vehicles...
for trains and boats, it works exactly as intended, perfect, great work, thanks and even :bow: , i really needed that feature
but for trucks - and as i saw after also for planes - it has two small bugs :
- orders are not copied (which is the most important piece when it comes to make a truck route with 10 trucks)
- the vehicke window does not pop up as it does for trains & boats (useful to start them quickly)
I know about the window issue and is working on it. I'm a bit surprised that shared orders stopped working. It's the same code for all vehicle types and it used to work. I will investigate why it do not work as entended
User avatar
Maverick
Traffic Manager
Traffic Manager
Posts: 175
Joined: 08 Dec 2002 15:20
Location: West Ryde, Australia.
Contact:

Post by Maverick »

Bjarni wrote:version 5 uploaded
now it works for all kinds of vehicles and should be compatible with lng files from the nightly build
Thank You! :)
User avatar
acidd_uk
Traffic Manager
Traffic Manager
Posts: 194
Joined: 08 Sep 2004 14:38

Post by acidd_uk »

Merge merge merge!
StarLite
Engineer
Engineer
Posts: 52
Joined: 02 Apr 2004 14:27
Contact:

Post by StarLite »

BTW, that build in the OP runs really s*** because its a debug build :)
Just so you know that :)
Bjarni
Tycoon
Tycoon
Posts: 2088
Joined: 08 Mar 2004 13:10

Post by Bjarni »

acidd_uk wrote:Merge merge merge!
bad idea. It's buggy right now. That's the whole idea of placing it here is to locate them before it's merged. After a merge, any critical bugs are more severe if they are in the trunk
User avatar
acidd_uk
Traffic Manager
Traffic Manager
Posts: 194
Joined: 08 Sep 2004 14:38

Post by acidd_uk »

Yeah I know, just that I've wanted this feature for a long time and so now it's here it makes me happy. As long as it gets merged when it's relatively bug free then I'm happy :-)
pitt2
Engineer
Engineer
Posts: 5
Joined: 07 Jan 2005 23:19

Post by pitt2 »

Patch works against 2164, but then exits after a while with

Assertion failed: item < 10 && ((_news_display_opt >> (item * 2)) & 0x3) <= 2, file news_gui.c, line 351
User avatar
Darkvater
Tycoon
Tycoon
Posts: 3053
Joined: 24 Feb 2003 18:45
Location: Hong Kong

Post by Darkvater »

pitt2 wrote:Patch works against 2164, but then exits after a while with

Assertion failed: item < 10 && ((_news_display_opt >> (item * 2)) & 0x3) <= 2, file news_gui.c, line 351
good job pitt2, you forgot to say that you had my patch applied and that was what was causing it :roll:
TrueLight: "Did you bother to read any of the replies, or you just pressed 'Reply' and started typing?"
<@[R-Dk]FoRbiDDeN> "HELP, this litte arrow thing keeps following my mouse, and I can't make it go away."
Bjarni
Tycoon
Tycoon
Posts: 2088
Joined: 08 Mar 2004 13:10

Post by Bjarni »

version 6 uploaded
changes:
  • fixed a bug, which prevented copying/cloning orders for road vehicles and aircrafts. This bug also prevented the new vehicles from opening their view windows
  • added option to copy orders instread of always sharing. Now it shares the orders if you hold down control
  • ships and aircrafts are refitted if the original one is
Bjarni
Tycoon
Tycoon
Posts: 2088
Joined: 08 Mar 2004 13:10

Post by Bjarni »

version 7 released

fewer changes this time. I realised a possible network desync right after uploading. It have been fixed now (introduced in v6)
User avatar
Maverick
Traffic Manager
Traffic Manager
Posts: 175
Joined: 08 Dec 2002 15:20
Location: West Ryde, Australia.
Contact:

Post by Maverick »

Thanks Bjarni, I thought you may have lost interest in this patch.
I hope this fixes some of the bugs :)

Unfortunately b2173 is'nt out yet.

By the way, with version 5 I've been getting heaps of these sort of errors, all the time whenever I try to save, or an auto-save point comes up. I use the clone exe to quickly duck away from the normal b2160+ exe game and clone some trains/ships/whatevers, then return to the normal builds. The clone exe is just too darn slow, as you know.
Attachments
I could supply a savegame if needed, but for now, here's the png.
I could supply a savegame if needed, but for now, here's the png.
Clipboard01.png (7.51 KiB) Viewed 4692 times
Bjarni
Tycoon
Tycoon
Posts: 2088
Joined: 08 Mar 2004 13:10

Post by Bjarni »

Maverick wrote:Thanks Bjarni, I thought you may have lost interest in this patch.
get real. I just had some other stuff to do, like a real life
Maverick wrote:I hope this fixes some of the bugs :)
it fixes all the bugs I was aware of when I uploaded it

Maverick wrote:By the way, with version 5 I've been getting heaps of these sort of errors, all the time whenever I try to save, or an auto-save point comes up. I use the clone exe to quickly duck away from the normal b2160+ exe game and clone some trains/ships/whatevers, then return to the normal builds. The clone exe is just too darn slow, as you know.
I would like a savegame. I haven't got a clue to what went wrong there. Maybe it would have been fixed now if you had posted it here when you noticed the problem
User avatar
Maverick
Traffic Manager
Traffic Manager
Posts: 175
Joined: 08 Dec 2002 15:20
Location: West Ryde, Australia.
Contact:

Post by Maverick »

Bjarni wrote:get real. I just had some other stuff to do, like a real life
Relax man. If there's anything to get angry at, it's not me.
Bjarni wrote:I would like a savegame. I haven't got a clue to what went wrong there. Maybe it would have been fixed now if you had posted it here when you noticed the problem
I'll PM a save to you now.
Bjarni
Tycoon
Tycoon
Posts: 2088
Joined: 08 Mar 2004 13:10

Post by Bjarni »

Maverick wrote:I'll PM a save to you now.
why PM. Just post it here
User avatar
Maverick
Traffic Manager
Traffic Manager
Posts: 175
Joined: 08 Dec 2002 15:20
Location: West Ryde, Australia.
Contact:

Post by Maverick »

Cause it's a problem I'm having, not a problem everyone else is.
Keeps the thread clean.
Bjarni
Tycoon
Tycoon
Posts: 2088
Joined: 08 Mar 2004 13:10

Post by Bjarni »

version 8 uploaded
changes:
  • fixed cost for multiheade engines
  • added error message if you don't have enough money
The error message is reusing the can't build message from the buy window. That way we do not have to translate 4 new strings. Tell me if you think it sounds lame, since I can't check every translation.

It is compiled against 2174, but it should be able to use lng files from 2173, which is the nightly build from yesterday
User avatar
acidd_uk
Traffic Manager
Traffic Manager
Posts: 194
Joined: 08 Sep 2004 14:38

Post by acidd_uk »

Woo - good stuff Bjarni!
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 9 guests