Gonozal_VIII patchpack r12180

[el koeno]

it's 4.3

The latest. Hmm.... shouldn't behave as strangely as it did.

By the way, thanks for your work, I'm really enjoying the patches. I don't have any clue how I should have merged all the useful patches into one build, some of them I even found out about their usefulness after apllying your patch (like auto seperate, a god-send). Good job!

[mpettitt]

Few issues with the pack that I've spotted (using version 120180 on Ubuntu Gutsy) - I've tried to identify ones which only occur due to interactions in this bundle:

Copy-paste patch doesn't understand advanced signals, and resets them to standard ones (YAPP signals). Ideally it would preserve them, but removing signals completely would be better than resetting them - one way standard signals cause massive blockages in YAPP networks, and are a pain to spot!

Inconsistent levels of support in train dialogs: you can click to clone a train from a depot, but not from the groupings list, or from a trains calling at station dialog. Not a massive issue, just a bit frustrating sometimes.


Still, in general it all seems to work really well - see attached (requires ECS town, basic, machinery, wood, agriculture, chemicals, construction vectors, UKRTS, av8, Stolen Trees and Long Vehicles...) There are a few acceptance issues that arise from ECS grfs not behaving as they should according to the vector diagrams - not sure if this is an OTTD issue or a grf issue.

[DanMacK]

May I suggest StevenH's Catenary on third rail type patch?

[jaybud4]

Also an update to a new revision if possible?

[DanMacK]

Can we gat a compiled Win32 version w/the new Beta please

[MagicBuzz]

Hello, I have a quite strange issue with the pack r12180...

In fact, I found 3 bugs, and I'm not sure what they are related to.

1/ When I do a screenshot, it says the file was saved... with the UKRS GRF name ("UK trainset renewal ...") but it's correctly saved with my company name and the date.
2/ Everytime I stop OTTD, I get a win32 error.
3/ And the engine pool seems to be completely stuck : it says I use trains I don't use, and the vehicles counts are completely wrong and not related to anything.

On the screen shot below, you can see an example of the bug #3.

All my trains are of the same model. I use only 111 engines. I'm in 1936, and it proposes me to replace more than 200 engines that I actually don't use, and that are still not designed (designed in 1950 but the current date is 1936...). The two other engines are wrong, as I use only one of those, and the sum of the two types of engines doesn't match my actual count of engines I use. So I can't use the auto-replace feature :/

strange.PNG (56.74 KiB) Viewed 1456 times

I use those GRFs :

Code: Select all

newgrf\pikkindw.grf
newgrf\ttrs3w.GRF
newgrf\stolentreesw_162.grf
newgrf\brickfreightw.GRF
newgrf\ae_cityw.GRF
newgrf\harbourw.grf
newgrf\indstatrw.grf
newgrf\modernsuburbanw.GRF
newgrf\platformsw.GRF
newgrf\ae_ruraw.GRF
newgrf\ae_subuw.GRF
newgrf\pb_hovs_bus.grf
newgrf\pb_ukrs.grf
newgrf\ukrsap1w.grf
newgrf\pb_av8w.grf
newgrf\pikbrikw.grf
newgrf\dbsetxlw.grf

[Trond]

For those that didnt notice, there are a link in the first post now that will leaf to updated patches that are in this pack. I tried to build a win32 version with all those tp put here, but there are a few conflicts in tortoise when I apply them, so its just a bit over my current skill level Anyways, the patches are there, updated by Gonozal, so it should be possible to make your own build with those using tortoise and BOTTD
I get into conflicts with the engine pool patch, and since I dont use that myself, I cba to try figure it out

I have used some of them myself to make my own build (daylenght, mid stop, station supplies etc) and it works like a charm.

Just tought I'd let you know, because I didnt notice that link to updated patches untill a couple of days ago myself

[Smoky555]

hi
This patch-pack make something with game...

I select EASY level, 7 AI players, 512x512 map with standart graphics, start the game but...
AI players build only headquartes... No trains, aircrafts, ships, road vehicles etc.
Is it bug or ... ?

[MagicBuzz]

hi
This patch-pack make something with game...

I select EASY level, 7 AI players, 512x512 map with standart graphics, start the game but...
AI players build only headquartes... No trains, aircrafts, ships, road vehicles etc.
Is it bug or ... ?

Same bug here.

And worst of all, may be because of the combination of UKRS and BDXL, I must play with daylength=5 and no economy impact if I want toget a chance to gain a few money with passengers trains (starting in 1920).
And the daylength = 2 for industries lines (same settings).

With a normal build, with UKRS or DBXL, I don't need to change the daylength patch, it's hard to start but it works.

Also, I noticed a bug with the DBXL wagons refit : I can't refit them to new industries cargos, only basic cargos. On a normal build there is not problem with this GRF. Althought, I don't have problem with UKRS.


But I still play with this pack, as I think engine pool and PBS are really cool. I'd just love if chissicom and gonozal work together to create a ChrisGonIN, as ChrisIN patchs are very cool too

[MagicBuzz]

Small update about this bug :

3/ And the engine pool seems to be completely stuck : it says I use trains I don't use, and the vehicles counts are completely wrong and not related to anything.

If I use the autoreplace window from the "all vehicle" group, it works fine. Well, not really fine, the GUI is 100% ok, but not all the trains can replace, several just enter the depot then got out without any change while they should be updated.

If I use the autoreplace windows from a vehicles group, it procude the screenshot I posted.

[peter1138]

If I use the autoreplace windows from a vehicles group, it procude the screenshot I posted.

That's the key, and it's now fixed.

[PhilSophus]

Also, I noticed a bug with the DBXL wagons refit : I can't refit them to new industries cargos, only basic cargos. On a normal build there is not problem with this GRF. Althought, I don't have problem with UKRS.

There is an additional grf dbxl_ecs.grf to be installed after dbsetxlw.grf which modifies the vehicles of the DBXL set. Assuming that you did install this, maybe dbxl_ecs.grf doesn't find its vehicle due to the engine pool. I'm not sure how this (grfs changing vehicles of another grf) is supposed to work with the engine pool anyway.

[Exelor]

thx for this great patched version...there's just a little thing:

trucks trying to hit the same station even there are no free slots and other free stations are available - how can i fix this?

[MagicBuzz]

Also, I noticed a bug with the DBXL wagons refit : I can't refit them to new industries cargos, only basic cargos. On a normal build there is not problem with this GRF. Althought, I don't have problem with UKRS.

There is an additional grf dbxl_ecs.grf to be installed after dbsetxlw.grf which modifies the vehicles of the DBXL set. Assuming that you did install this, maybe dbxl_ecs.grf doesn't find its vehicle due to the engine pool. I'm not sure how this (grfs changing vehicles of another grf) is supposed to work with the engine pool anyway.

Well, I didn't, but... Without this, the DBXL works fine on the ChrisIN that doesn't use the engine pool (so DBXL is alone) and I can see gravel or plastic as refit options (??)
I'll take a closer look at this this evening.

[chrissicom]

I've just come to this thread the first time and find it cool to see someone else maintained a patch pack while I was gone! Also that PBS, passenger destinations and engine pools is added now rocks!! These were 3 of my most anticipated patches. I am not too up to date right now but are these 3 complete or are there still bugs in them?

When I made the new ChrisIN thread I didn't know we have another patchpack floating around already so maybe it's better if I just help out here or something. I actually had an idea for a new ChrisIN which I don't know yet would be possible.
I intended to mostly use "external" files for adding patches, i.e. not modify the original OpenTTD files but at seperate header files and sources for the ChrisIN patches to be less intrusive and have an easier job when updating patch code, because it's not mixed up with a whole bunch of original code. Only problem is that some patches are not adding something but modify trunk code so I thought I would only add them if they are really very good and up to a high standard already. I know that this would require a lot of rewriting when implementing patches but on the other hand it's a lot easier to update patch code and sync trunk without mixing up too much code. For example the copy & paste patch is pretty huge and gives a good example of "external" files although it's not quite to the degree where I wanted to push it. Well I will just play around on my PC a little and see if this idea is actually realisable.

[MagicBuzz]

I've just come to this thread the first time and find it cool to see someone else maintained a patch pack while I was gone! Also that PBS, passenger destinations and engine pools is added now rocks!!

I have to admit I want to remain faithful to ChrisIN, but I was quite balanced between both the ChrisIN and the Gonozal Pack, as both adds incredibly cool patches

These were 3 of my most anticipated patches. I am not too up to date right now but are these 3 complete or are there still bugs in them?

PBS : In the current Gonozal Pack, there are a few bugs with the signals auto-build tool (sometime is doesn't build the right signals), but the main problem with PBS is the difference with classic signals. The firsts tentatives of use often result in many trains crashs, as PBS doesn't like the traks layout to be updated while a train is on the same area.
Engine Pool : I detected an error in the Gonozal Pack (see a few posts ago) and it looks like Peter did a fix about it. This patch is mostly bug free, but still need some work as told in the dedicated thread (3rd/4th tracks types, etc.)
PaxDests : I didn't noticed any problem except economy balancing (very hard to stard, and absolutely too easy when started). All features seems to work fine. The only problem is that new station screens are undocumented and some people like me just can't have any idea of what are some of the numbers displayed)

When I made the new ChrisIN thread I didn't know we have another patchpack floating around already so maybe it's better if I just help out here or something. I actually had an idea for a new ChrisIN which I don't know yet would be possible.

That's something I just would like to suggest : work together to maintain a unique version, so I can remain faithful to the ChrisIN, and get advantage of the new Gonozal's Pack patches

I intended to mostly use "external" files for adding patches, i.e. not modify the original OpenTTD files but at seperate header files and sources for the ChrisIN patches to be less intrusive and have an easier job when updating patch code, because it's not mixed up with a whole bunch of original code. Only problem is that some patches are not adding something but modify trunk code so I thought I would only add them if they are really very good and up to a high standard already. I know that this would require a lot of rewriting when implementing patches but on the other hand it's a lot easier to update patch code and sync trunk without mixing up too much code. For example the copy & paste patch is pretty huge and gives a good example of "external" files although it's not quite to the degree where I wanted to push it. Well I will just play around on my PC a little and see if this idea is actually realisable.

The dangerous thing with this approach is that you might get a lot of code duplication : each time a patch author wants to update the basic behaviour, he might duplicate the current trunk function, then update this copy, with a new name. Then updates to the trunk won't be in the duplicated functions, and it might become unmaintainable as well.
But I don't have better suggestions about this problem, let's try and prey

A suggestion should be opening a SVN repository for ChrisIN, then ask authors to sync themselves their patchs with the ChrisIN like we do with the trunk. But this might result in another problem the MiniIN had : the code will progressively become totally impossible to sync with the trunk.

[chrissicom]

Well a problem with patch syncing to SVN is that most patch authors are by far not as active as the developers of trunk itself and therefor a patch pack like we are doing is better imho. My idea behind the external files is that it should be easy to add or remove a function to/from the game without modifying a lot of the original code if not really necessary.

Hmmm from what you see it seems that these 3 patches are still not really perfect, I will download a .diff from here and see how it works haven't played any new versions in a while.


Edit:
Hmm I seem to have quite some difficulties compiling this patchpack with MSVC 2008. Especially in economy.cpp there are a lot of errors. Is this patch pack MSVC compatible or can it be only compile with GCC?

Edit:
Ok, so the prebuilt version of this patchpack works on my machine, but I am unable to build it using the .diff on my checkout. Also I have quite some problems in multiplayer games. In the attached savegame when my brother (JR) clicks on "Brenington Iron Ore" station his game crashes while it works fine for me when clicking it in multiplayer, although it crashes for me when I am in singleplayer. I don't really understand what is the cause for the error.

[chrissicom]

Ok, here is some more info, the dynamic engine pool seems to have serious problems with some sets in multiplayer. I am currently playing with the DB Set and Japan Set so my brother can build different engines than me. The game can't really decide wether to use the modified Shinkansen track from the .grf though. The GUI shows the Shinkansen track while on the map I see the default maglev track (which actually happens with current trunk and Japan set only as well).

Then after a while of playing the game start to crash when the 2nd player clicks on any newly build station. It also crashes when I take the multiplayer game and load it in singleplayer and then the player clicks on an affected station. Unfortunately I cannot build a debug build to see what causes this or if there is an assert or something, because the game simply quits without any message (prebuilt version).

Here is the error I get when compiling with the .diff supplied here (MSVC 2008 and Trunk/ChrisIN compilation works fine)

Code: Select all

3>c:\openttd\openttd-dev\src\economy.cpp(1239) : error C2666: 'OverflowSafeInt<T,T_MAX,T_MIN>::operator /' : 4 overloads have similar conversions
3>        with
3>        [
3>            T=int64,
3>            T_MAX=0x7fffffffffffffff,
3>            T_MIN=0x800000000
3>        ]
3>        c:\openttd\openttd-dev\src\core\overflowsafe_type.hpp(92): could be 'OverflowSafeInt<T,T_MAX,T_MIN> OverflowSafeInt<T,T_MAX,T_MIN>::operator /(const uint) const'
3>        with
3>        [
3>            T=int64,
3>            T_MAX=0x7fffffffffffffff,
3>            T_MIN=0x800000000
3>        ]
3>        c:\openttd\openttd-dev\src\core\overflowsafe_type.hpp(91): or       'OverflowSafeInt<T,T_MAX,T_MIN> OverflowSafeInt<T,T_MAX,T_MIN>::operator /(const int) const'
3>        with
3>        [
3>            T=int64,
3>            T_MAX=0x7fffffffffffffff,
3>            T_MIN=0x800000000
3>        ]
3>        c:\openttd\openttd-dev\src\core\overflowsafe_type.hpp(90): or       'OverflowSafeInt<T,T_MAX,T_MIN> OverflowSafeInt<T,T_MAX,T_MIN>::operator /(const OverflowSafeInt<T,T_MAX,T_MIN> &) const'
3>        with
3>        [
3>            T=int64,
3>            T_MAX=0x7fffffffffffffff,
3>            T_MIN=0x800000000
3>        ]
3>        or       'built-in C++ operator/(int64, byte)'
3>        while trying to match the argument list '(Money, byte)'

I don't quite get what this all means unfortunatey. Also there are quite a few warnings in cargopacket.cpp caused by the Pax Patch and one wrong include in station.cpp where strings.h should be strings_type.h I assume.

I will try to implement the patches step by step and see if I can find the one causing these errors (except for Pax causing the warnings).

Edit: Ok, the error in economy.cpp is caused by the extended daypatch

Edit 2: Also min/max interest patch is showing a similar error, it seems none of the patches from this pack modifying economy.cpp work for me

[PhilSophus]

Gonozal, are you sure, that patchpack r12180 contains YAPP 4.3?

I can easily reproduce this flooding of "Train X can't find a free path to continue" messages as described here with your patchpack but not with a clean trunk 12187 plus only YAPP 4.3.

[Indiana]

Bugs on Multiplayer Session:
- I can't click on an intercontinental Airport without a hard crash of openttd.
- YAPP sometimes reserve a block infront of train so the train will wait for a free path forever.