Some said it wasn't possible because the 74 was too hardcoded but yet the core change was done quickly and the game was still functional. Most work is in scaling other aspects and tweaking settings.
Unlike other day lengthening patches, this does not insert an extra loop between two original day ticks but it actually increases the amount of available ticks in a day (with factors aligning to real time). Estimated tile distance at factor 1440 (86400 ticks per day) is 1.73 kilometres and would make it about 50 metres at the highest setting (roughly measured with train and road vehicle).
Currently both vanilla and JGR patch seem fully functional (with exception of scheduled dispatch).
Changes in patch (depending on OpenTTD branch):
- modified and added time related variables and definitions
- modified timetable variables for timing
- setting for selecting the time factor (removed old day length option)
- scaled industry production (non-linear)
- automatic enabling of status bar clock
- extended the command functions from 2 to 8 parameters and currently exchanging the row of variables with the CommandContainer struct.
(as of TTD-1.6, modified it to use the CommandContainer at its core, which is easily expanded with useful variables (see timetable files for example)
This means that there's essentially unlimited flags available as well)
- enabled timetable arrival and departure times permanently, they're useful and times are filled in automatically anyway
Not time related:
- added the slightly modified core code of the patch to slow down fast trains behind slow ones and lessen them constantly stopping and starting;
. viewtopic.php?f=33&t=52085
- replaced monthly with daily autosave
- added time to the ISO version of savegame filenames
- tweaks in duration of loading/unloading trains (dependent on train length, not overhang at a station)
- alternative station catchment radius set higher for bus and 1 for other stations
- changed station rating modifiers, vehicle age factor changes only slightly over 10 years and speed is no longer a factor so the small and slower vehicles have a use
- default order settings are no load and no unload, and clicking on the button will open the cargo by type selection list
- switched the unload and load buttons to align with the actual order text
Recommended settings (depending on OpenTTD branch):
Interface - Wall clock:
- Show time in minutes: on
- Enter timetable times as text: on
- Ticks per minute: is set to a fixed 1800 ticks because of the fixed length in ticks in a day
- Show date: full date
Possible issues (the ones seen so far, depending on OpwnTTD branch, not all confirmed fixed yet by me):
The JGR patch is not savegame compatible yet, you might get an ocean background at the intro screen but saving and loading new games works so far.
Production rate might be set higher for testing purposes, eventually to be set to once a day by default and a scaling option.
Town label is red even though attitude is good. (seems caused by loading of previous test games and disappears after saving/reloading game)
Planned additions:
- scale town size
- scale acceleration
- scale catchment area for bus station (other stations can be scaled by combining with bus station when it makes sense for covering populated areas, like mail, goods)
- park depot order to park vehicles while waiting, without triggering the service function
- loopback to station/waypoint similar to the depot code which calls enter depot when target tile is the same as current tile (to let the vehicle stay at the station while processing concitional orders)
- dummy order to act as placeholder/jump target in order list, current workaround is using maximum speed is 0
- need to look at the code more closely but I think it should be possible to extend the search for industries receiving the same cargo instead of stopping at the first one detected
- when starting the scenario editor, open with a 64x64 map to avoid waiting when the last map created was large
Notes:
Some quirks I ran into (might not be related to the patch, will look into later when there's time):
- YAPF processes signal routing differently coming from the back or the front of the signal, most obvious by deny rules
- sometimes a slot is not released when a train passes
- YAPF can reserve next path when the signal is directly behind a waypoint and the train has waiting time scheduled there
- various other situations where YAPF and routing signals don't work, the whole process needs to be traced and checked
- refit craps out when one or more cargos at station are above an x amount (at one point 40000+ BM), or available cargo list can't be read anymore? -> discovered it's the Vixen TFB flatbed truck that won't refit back to wood after it had loaded some other cargo, other trucks might be affected as well because I thiink I had the same trouble with goods cargo before
refit still ceases to work on other occasions though
- conditional order percent of time set to 0 might still be triggered
- road vehicle must have one order going directly to any station otherwise the cargo links it should have are deleted (one can't create an orderlist avoiding any visit to a station without cargo, workaround is first order to a dummy station directly in front of depot where vehicle is waiting)
Had some thoughts about getting a demand based economy using most of the current functionality. All industries get an order list, towns begin by placing an order for goods and food at available industries (FIRS shops, hotel do the same). Those will create orders for required supplies and so on up to the raw industries. Normal production will create cargo packets based on the order list and drop them at the local station where they'll wait for a transportation connection.
No station or production resources simply means the orders are on hold, orders older than a certain age could be automatically deleted from the list, the older the order, the less payment on delivery.
This is something to mull over after I'm done with the realtime work and refactoring of the code unless someone's inclined to give it a shot in the meantime.
---
Diff for JGR patch branch (0.31.2): Diff for vanilla TTD branch (1.9.2), core modifications done, status: bug hunting: The diff for JGR patch 0.31.3 that I use to work in and which has various junk code in it to test things (for the curious, the only requirement is that the game runs): PS: Diff files are made from local directories, not the git repositories.
Time factor selection list in settings:
Status bar clock in 1.9.1:
