Busstop Picture / Dev Topic

[wallyweb]

can somebody give me the link, cause I havn't seen it anywhere

The link to what?

[iranair777]

can somebody give me the link, cause I havn't seen it anywhere

The link to what?

to the drive through bus stop

[wallyweb]

can somebody give me the link, cause I haven't seen it anywhere

The link to what?

to the drive through bus stop

Drive Through Bus Stop (And Drive Through Truck Stop too) graphics are part of the patch and do not require additional grf's. Just open the Bus Stop Construction tool and you will see drive through bus stops as one of the options.
Which version of the patch are you using? You might need to upgrade.
If you are using OTTD instead of the patch then you should ask your question in the OTTD section as they are more qualified to respond to OTTD question.

[iranair777]

The link to what?

to the drive through bus stop

Drive Through Bus Stop (And Drive Through Truck Stop too) graphics are part of the patch and do not require additional grf's. Just open the Bus Stop Construction tool and you will see drive through bus stops as one of the options.
Which version of the patch are you using? You might need to upgrade.
If you are using OTTD instead of the patch then you should ask your question in the OTTD section as they are more qualified to respond to OTTD question.

thanks, but which patch? ive searched the post and havnt found anything

[wallyweb]

to the drive through bus stop

Drive Through Bus Stop (And Drive Through Truck Stop too) graphics are part of the patch and do not require additional grf's. Just open the Bus Stop Construction tool and you will see drive through bus stops as one of the options.
Which version of the patch are you using? You might need to upgrade.
If you are using OTTD instead of the patch then you should ask your question in the OTTD section as they are more qualified to respond to OTTD question.

thanks, but which patch? ive searched the post and havnt found anything

Are you serious? The patch that you use to play the game of course. The patch that is available here.

EDIT: Just in case you are not familiar with the availability of Beta versions of the patch, you will need to click on "source code" in the menu on the left where I recommend reading EVERYTHING so that you can get all the latest and greatest features available.

[iranair777]

yeah im using OTTD

[wallyweb]

yeah im using OTTD

Then try your question in the OTTD section here

[iranair777]

yeah im using OTTD

Then try your question in the OTTD section here

k thanks

[minime]

I've played around a little with the current bus stop implementation and after getting some inspiration from Steven's trams, I've succeeded in implementing Action 5 support for road side RV stops (type 0x11).

This should be mostly compatible with the OTTD implementation. I've used the same order of sprites as can be found in roadstops.grf, however, they require somewhat modified offsets due to the way I've defined the station layouts.

I've bumped the base graphics file version and updated the file to contain the necessary basic sprites. While I was doing this, I also took the chance to fix a small problem with sprite 1027 in those files (sprite size was incorrect).

Attached is a diff of the relevant changes against trunk (r1584). Please let me know if there's anything more that needs to be do done with that, or whether it's ok to commit.

Regards,
minime

EDIT: Removed TTDPBASE[W] archive from this post, for updated version see this post.

[peter1138]

Hmm, doesn't modifying the offsets mean the feature is essentially incompatible between OTTD and Patch?

[minime]

I believe the reason for the offsets requiring some manipulation is the way I've defined bounding boxes for the layout. The way I have them defined, they allow the graphics to span the entire length of the tile, as opposed to what I assume are tighter bounding boxes in OTTD (I haven't check the code there yet), which seem to be specifically tuned for the standard OTTD graphics. In my opinion it is better to be a little more generous when specifying the bounding box, especially considering that the real purpose of this feature is to allow customization.

I do realize that this makes the two implementations somewhat incompatible, but considering that there are many subtle differences between the requirements of the two games, I don't consider it that much of a problem for this first implementation (as long as it is accurately documented).

In my defence, I'd like to point out that a similar issue exists with OTTD's support of railroad catenary. I remember that when I was working on CSRailSet, I had to adjust the offsets by several pixels in order to achieve the same graphical result in OTTD as I got in TTDP.

[peter1138]

The catenary is buggy, yes, and I need to fix that. Don't rely on this misbehaviour.

But for drive through stops, it probably would make sense to apply your changes to the offsets to OpenTTD.

[minime]

Alright, I'll have a look at the code OTTD and let you know when I've got it working in the same way.

[minime]

I've adjusted the offsets in OTTD as you requested and corrected the default GRF (attached). Now both games produce the same result with identical graphics and code.

P.S.: I'm posting this here, since it's directly related to the TTDP patch. If someone feels this should go somewhere else, let me know.

[DaleStan]

Attached is a diff of the relevant changes against trunk (r1584). Please let me know if there's anything more that needs to be do done with that, or whether it's ok to commit.

Especially for single-line additions, you don't need to add "by <name>" comments. Subversion keeps track of who made what change, and svn blame/TortoiseBlame will give line-by-line listings of who changed each line most recently, and when.
On the other hand, they won't hurt anything, and it's easier to check the source comments than to svn blame.

Other than that, it looks fine; I trust that it actually does what it is supposed to do.

[m3henry]

Now which ttdpbase grf did you change, there are new ones churned out recently

[minime]

On the other hand, they won't hurt anything, and it's easier to check the source comments than to svn blame.

I'll try to cut down on that in the future. Part of the reason I was so thorough was to make navigating the code while I was working on it a bit easier. I suppose I could even clean it up a bit before I commit it.

Other than that, it looks fine...

OK, I'll commit it in that case. Thanks.

Now which ttdpbase grf did you change, there are new ones churned out recently

The one relevant to r1584 - i.e. the one modified by Lakie on 15/6/2007 for r1583.

[Lakie]

Modified by Pikka? Pikka hasn't modified ttdpbase in quite some time, are you sure you don't mean modified by me?

~ Lakie

[minime]

Dooh - of course. Sorry

[minime]

Corrected version of ttdpbase[w].grf - accidentally, I've uploaded files that did not have the version number increased to 4.

Thanks to TrueSatan for letting me know about this.

minime