Patches: Close tool with middle click / persistent clone

[Terkhen]

This one is the penultimate of my patching spree. Don't worry about my sanity; it is very small and simple, but pretty handful. This feature allows to close any tool currently in use pressing the middle mouse button. This is specially useful with persistent tools and / or quick goto turned on. I know that you can already do the same with the ESC key, but it is so far from the rest of frequently used keys that I lose too much time using it. Try it once and you will never go back, I know I won't

The middle mouse button code (the complicated part) was created by erikjanp for the shade windows patch, which means that almost every line of this code was made by him.

Right now the behaviour is to close tools if there's a tool active, which lefts open the possibility of allowing it to do other things under different conditions. Do you think this behaviour for the middle button is consistent enough?. Is there any problem with using the middle button (besides that this feature can't be used in platforms without this button)?.

[Terkhen]

And the last one: persistent clone. While you are cloning, the clone tool stays active until you click on its button again or press ESC. To turn on / off this behaviour, it uses the same setting than the persistent building tool.

[petert]

I find close tools with middle mouse button very useful. I usually have to use del key, therefore my finger is on the del key almost all the time that I am building. The tool that is sort-of pesky is the Land Area Information, since that doesn't go away when you press del. I don't know what people will do without a middle mouse button though.

As for the persistant clone tool, as of now, that one didn't work for me. I tried making an aircraft, then clicked on clone and when I cloned it, I had to re-click clone vehicle again. I've a feeling I'm using this one wrong.

If you need me to post screenshots, video, I can do that.

Keep up the good work Terkhan and erikjanp

Me gusta como trabajas.

Peter

[Terkhen]

As for the persistant clone tool, as of now, that one didn't work for me. I tried making an aircraft, then clicked on clone and when I cloned it, I had to re-click clone vehicle again. I've a feeling I'm using this one wrong.

You probably have the setting for quick goto off; As stated, right now they are using the same setting. Turn it on and you will be able to enjoy persistent cloning.

[petert]

Like I said:

I've a feeling I'm using this one wrong.

Thanks for the help.

[Terkhen]

I just tested that these patches can apply to the 0.7 branch without rejects.

Edit: Persistent clone updated. I just made it use the existing "persistent building tools" settings: it is more correct in this way.

[petert]

Can you update the first post with the compiled binary of v2 of persistant clone?

[Terkhen]

The persistent clone binary and diff are at the second post. Why should I move the files?

[petert]

Edit: Removed ptMPP from here, check out

ptMPP's Google Code Page

[Terkhen]

If you are going to create a patch pack, you should start a new thread for it.

Edit: The download link is not correct: after clicking on the url I had to remove "Connection: close" from the end of the url to download it. Also, the zip file still has the .svn folders. If you export the files with svn after compiling and before packing (or delete the .svn folders manually) the zip file will be lighter.

[petert]

The url doesn't contain "Connection: Close" at the end. I don't know what caused that.

[Scautura]

MediaFire doesn't allow you to link directly to the file, you need to link here: http://www.mediafire.com/?o2dv1d5xey3

[petert]

Ok, I updated the link. Thank you Scatura.

[Ammler]

If you export the files with svn after compiling and before packing (or delete the .svn folders manually) the zip file will be lighter.

or just use "make bundle_*"

[Terkhen]

or just use "make bundle_*"

Sadly that's not possible for me since I use Visual Studio (or at least I wasn't able to find documentation about it).

[Yexo]

or just use "make bundle_*"

Sadly that's not possible for me since I use Visual Studio (or at least I wasn't able to find documentation about it).

I use Visual Studio too, but for making a bundle I use cygwin or msys.

[Terkhen]

I use gnuwin32 tools myself: I had to uninstall msys because it conflicted with devkitpro. Now that I finished my project involving devkitpro, I can give msys another chance when I finish my exams.

[DaleStan]

Right now the behaviour is to close tools if there's a tool active, which lefts open the possibility of allowing it to do other things under different conditions. Do you think this behaviour for the middle button is consistent enough?. Is there any problem with using the middle button (besides that this feature can't be used in platforms without this button)?.

If there's a tool active and you middle-click on the title-bar of a window, what happens? Does the window (un)shade, or does the tool get closed? (Or -- horror of horrors -- both?)

[Terkhen]

The planned behaviour is to close the the tool first, and another click would shade the window. When the shade windows patch gets updated to trunk, I will do a version of close tool with middle click compatible with it. Right now, if you just tried to solve the rejects between the two patches manually shading window with middle click could either not work at all or land in the horror of horrors, depending on how it was solved. These are the correct changes, if anyone wants to try it before shade windows is updated.

Without erikjamp's code for middle click, my patch is this single line (placed in the part of the code that handles middle clicking):

Code: Select all

if (_cursor.sprite != SPR_CURSOR_MOUSE) ResetObjectToPlace();

To have compatibility with shade windows, it needs to be like this:

Code: Select all

if (_cursor.sprite != SPR_CURSOR_MOUSE) {
	ResetObjectToPlace();
} else {
	click = MC_MIDDLE; //Constant that I currently don't use, as the middle click don't needs to be checked in the GUI in my patch.
}

[audigex]

How about clicking the middle mouse button again re-instates the previous tool?