FIRS Industry Replacement Set - Development

[andythenorth]

We currently don't support cheats

I wish we did When testing newgrf vehicles (especially 1000t ships) it's useful to use the production value cheat. Maybe I should fix that

[NekoMaster]

We currently don't support cheats

I wish we did When testing newgrf vehicles (especially 1000t ships) it's useful to use the production value cheat. Maybe I should fix that

the best you can do is try cheat engine or artmoney, and find the address for the industries production value, each industry has its own for each kind.

Also, the waste collection points and the recycling plants can have there values changed with the allow modifying production values cheat

[andythenorth]

I am working on production boosting cargos. If you haven't been part of the discussion on irc this week, stay away from this, thanks.

Writing the text for the industry window is a bit of a fine art...what do you guys make of this attempt?

the_pain.png (37.14 KiB) Viewed 3979 times

[FooBar]

Works for me, but I might be biased as I already know what the feature is about...

[Roujin]

Does it need to be written there? Wouldn't it suffice to include a description of how *exactly* the mechanism works in the donteverreadme.txt?
Maybe from your perspective, this information is interesting, but for the average user something like "the presence of engineering supplies boosts production" is all he needs. The rest is reading overhead

[andythenorth]

Maybe from your perspective, this information is interesting

...not so much I don't really think the player should have to bother with the internal workings...but nor do I want players bothering me with lots of forum questions. It's a balance...

but for the average user something like "the presence of engineering supplies boosts production" is all he needs.

I'm not totally convinced by that. The player could be thinking: how much is needed? Does more improve the chances? Are they needed every month?

However Pikka suggested I try this, which is better:

the_pain_2.png (33.53 KiB) Viewed 3904 times

If I can work out how to use registers, I can also improve the code so it actually *is* less complicated for the player (more complicated for me though!)

I much prefer shorter text. If I can trim down the cargo limit info that would be better too.

Personally, I go and read the readme instructions when I care about how the industries work, at least for PBI and CanSet anyways.

[DJ Nekkid]

i tend to agree with your approach, and it _WILL_ lead to less questions, but there is always the chance of a readme/wikipage/webpage... I mean, users are usually quite stupid

No offence users!

[LaDoncella]

I think that this is the exact place (ingame) where this info should be!
perhaps I would prefer a more concise description, something like: engineering supplies boost production (max 200/month)

[andythenorth]

Is this better?

the_pain_3.png (33.68 KiB) Viewed 3883 times

Or this? This is my preferred version so far:

the_pain_4.png (30.5 KiB) Viewed 3875 times

[George]

May I take part in the discussion?

http://bugs.openttd.org/task/1862

Thy not to pick up the old (over 3 years if I'm not mistaken) suggestion to allow writing max store size on the same line as amount of cargo waiting?

Code: Select all

Cargo waiting to be processed:
123 units of H2 (200 max)
321 units of 02 (250 max)

Yes, you can get more cargo than max, that is how TTD/OTTD works. But do not worry much about it, this overflow is allowed for shot -until next accepting callback, that means the next vehicle If I'm not mistaken.
Devs, you opinion?

Work has already begun on it.
It will not be part of the 0.6 betas nor RCs to come, tough, as we try to avoid as much as possible breaking the actual release process
If ever you already have a working grf based on the last proposal by Dalestan, it might be usefull for us to test it with

[andythenorth]

Thy not to pick up the old (over 3 years if I'm not mistaken) suggestion to allow writing max store size on the same line as amount of cargo waiting?

Code: Select all

Cargo waiting to be processed:[/quote]
Hey, nice suggestion.  I have tested using callback 37 to set a '(Max 200)' text this way.  

Two issues:
1. Is this a monster hack?  I don't want to set this up for 64 industries if it's a bad idea.
2. The string gets truncated if too long.  Can't see a way round this.  Wrapping to the next line will bounce down following cargo texts.  Keeping text short should help, but may not always be sufficient.
[attachment=0]the_pain_5.png[/attachment]

[CommanderZ]

I like the_pain_4.png most.

[andythenorth]

Using cb 37...

the_pain_6.png (31.8 KiB) Viewed 3804 times

[George]

Thy not to pick up the old (over 3 years if I'm not mistaken) suggestion to allow writing max store size on the same line as amount of cargo waiting?

Code: Select all

Cargo waiting to be processed:[/quote]
Hey, nice suggestion.  I have tested using callback 37 to set a '(Max 200)' text this way.  
Two issues:
1. Is this a monster hack?  I don't want to set this up for 64 industries if it's a bad idea.
2. The string gets truncated if too long.  Can't see a way round this.  Wrapping to the next line will bounce down following cargo texts.  Keeping text short should help, but may not always be sufficient.[/quote]That's why the FS 1862 is open. It would be much better to write a number in the stack and display it, rather than making strings for all the store place sizes. I hope if we would vote for this task, some dev would have a look into it. I hope someone could ask Belugas to finish the code he has started.

[Kogut]

Engineering supplies ideas:
- There are needed on high production levels (like 2k coal per month) to protect from high change of reducing production.
- Higher proceed speed on higher industry levels.
- Bigger stockpile on higher production level (maybe monthly production=maximum number of waiting crates)

[frosch]

Test patch has been added to FS#1862.

[George]

Test patch has been added to FS#1862.

Patch works as intended. All tests (3) passed.

[andythenorth]

Thanks to some kind help (frosch is owed a gift), I can now display whether an industry is accepting Engineering Supplies, or if the limit has been reached (final line of text changes to 'Not accepting Engineering Supplies', and is white to draw attention.

the_pain_7.png (45.24 KiB) Viewed 3554 times

I wonder if this would be a better place for the Accepting / Not Accepting text

the_pain_8.gif (17.49 KiB) Viewed 3554 times

the_pain_9.png (13.46 KiB) Viewed 3548 times

[CommanderZ]

Maybe you could colour the "(max 200)" text red if the industry doesn't accept ES?

[andythenorth]

This is my solution to showing acceptance in the text window.

Accepting Cargo (normal)

the_painless_1.png (31.08 KiB) Viewed 3512 times

Not Accepting Cargo (uh oh!)

the_painless_2.png (36.43 KiB) Viewed 3512 times

Andon theory - don't bother providing alerts about 'normal' condition...

Keen-eyed viewers will notice that it's possible to exceed the limit...just a little bit. This is known. I like it