Page 1 of 2

Download counters are broken

Posted: 15 Nov 2009 15:56
by Eddi
Over the past cople of weeks i encountered several attachments that said "not downloaded yet", while it was obvious that someone replied to contents of the attachment.

for example here: http://www.tt-forums.net/viewtopic.php?f=31&t=45857

Re: Download counters are broken

Posted: 15 Nov 2009 16:08
by orudge
Yep, that's been a known problem since the last phpBB update. phpBB 3.0.6 should in theory be out soonish, maybe it'll fix it.

Re: Download counters are broken

Posted: 15 Nov 2009 16:44
by petert
phpBB 3.0.6 seems to have some very interesting features.

Re: Download counters are broken

Posted: 17 Nov 2009 11:54
by Nawdic
I think that most people ust "opens" the attachment rather than "saving" it... That may be why as technically you arent downloading it.

Re: Download counters are broken

Posted: 17 Nov 2009 12:46
by Illegal_Alien
Sorry but with "open" you still are downloading...

Re: Download counters are broken

Posted: 09 Dec 2009 13:43
by Lord Aro
i think i should mention that now the forums have been upgraded the download counters still dont work! :(

just thought i should mention it,

Re: Download counters are broken

Posted: 09 Dec 2009 16:21
by orudge
That's peculiar. But as mentioned in another thread, I'm going to basically replace all the forum files and check if anything hasn't been updated at some point tonight. Repeated updates may have resulted in some glitches creeping in over the years.

Re: Download counters are broken

Posted: 10 Dec 2009 01:26
by orudge
Hmm. Well, having looked into it a bit more, it seems that it's only image attachments that aren't incrementing. Apparently due to this bug fix. Personally, I wouldn't have called it a bug myself, but it seems now to stop images incrementing *at all* - which DOES seem to be a bug. I've double-checked though, and all my phpBB files are up-to-date, so, hmm.

One thing I have done just now though is enable thumbnails for any images over 800x600. So that might be handy at least.

Re: Download counters are broken

Posted: 10 Dec 2009 01:29
by orudge
Yikes. It seems phpBB is being a bit too intelligent. It saw a .png image, so created a .png thumbnail... except that the thumbnail is 400KB larger than the original image. :?

Re: Download counters are broken

Posted: 10 Dec 2009 07:57
by jonty-comp
I'd say the benefits outweigh the doubts, as I am in that screenshot. :P

Re: Download counters are broken

Posted: 10 Dec 2009 13:15
by JamieLei
That's extremely useful - thank's Owen!

Re: Download counters are broken

Posted: 10 Dec 2009 17:23
by petert
orudge wrote:One thing I have done just now though is enable thumbnails for any images over 800x600. So that might be handy at least.
How much over? What is the maximum?

Re: Download counters are broken

Posted: 10 Dec 2009 19:21
by orudge
There is no maximum, as long as the image doesn't exceed the file size limit. Any image over 800x600 will be displayed as a link - the only difference that there's now a thumbnail of it too.

Re: Download counters are broken

Posted: 10 Dec 2009 20:00
by petert
orudge wrote:There is no maximum, as long as the image doesn't exceed the file size limit. Any image over 800x600 will be displayed as a link - the only difference that there's now a thumbnail of it too.
That raises the problem of images way over 800x600. What about very large screenshots? Will they be shrunk, and the full size image will be a link? Forgive me if I misunderstood you.

Re: Download counters are broken

Posted: 10 Dec 2009 20:08
by orudge
Yes, that's the point. Before, they would just not be displayed at all, and only linked to. Now they'll have a smaller thumbnail, but you can still link for the full version.

Re: Download counters are broken

Posted: 10 Dec 2009 20:15
by petert
I see now. Then why are these pictures not shown as a thumbnail? (http://www.tt-forums.net/viewtopic.php?p=839123#p839123)

Re: Download counters are broken

Posted: 10 Dec 2009 20:26
by orudge
Probably because they were posted before I turned the feature on. It won't affect old attachments.

Re: Download counters are broken

Posted: 10 Dec 2009 21:24
by jonty-comp
Imagine how much CPU time it would take to generate seven years' worth of thumbnails! :P

Re: Download counters are broken

Posted: 10 Dec 2009 21:28
by orudge
We have nearly 100,000 attachments now, by the way, taking up 8.3GB of space. Shiny.

Re: Download counters are broken

Posted: 10 Dec 2009 21:41
by petert
orudge wrote:We have nearly 100,000 attachments now, by the way, taking up 8.3GB of space. Shiny.
Only 8.3GB? I would imagine it would be more.

A bit OT but, can anybody attach files larger than 4MB (the new limit should be 6MB)? Or is this just for me?