Page 1 of 6

MiniIN patches and TODO list

Posted: 21 Jul 2006 14:50
by richk67
Hi All.

I thought it would be a good idea to separate out the patches and "things to be done" in MiniIN from the main discussion thread. I have already lost track of some patches earlier, just because by the time I did the next update, the patch was 5 pages back.

This thread is the home for all new versions of existing patches, copies or links to patches (by authors please) for new features you would like to see, and other assorted items that *need* to be done.

PLEASE DO NOT HAVE IDLE CHAT IN THIS THREAD. IT IS PRINCIPALLY FOR THE PATCH DEVELOPERS

To keep it sane, I need to have a neater clear list. At the moment (mid July), MiniIN has about 30 patches, and it is already getting to the point it is beyond simple organisation.

So please help and use this thread for patches, and new features.

For bugfixes: Please provide a one/two line summary of what the bug and fix do for the commit log.

When I have committed your patch to MiniIN, can you update your post to say "Edit DONE: committed at r????" so I can see at a glance that I have done the work.

IF YOU HAVE A BUG TO REPORT.... PLEASE USE THE MiniIN Problem Thread (sticky) in the OTTD Problems Forum.

Posted: 21 Jul 2006 17:39
by mart3p
Well, let me be the first to contribute to your new thread. :D

Here is the Drive-Through Road Stops patch for the MiniIN and roadstops.grf for the new graphics. The file roadstops.grf needs to be in the data folder, it does not require a config. file entry.

Note to those who download roadstops.grf: This is NOT a NewGRF file. If you use it without the drive-through road stops patch IT WILL NOT WORK.

Edit: DONE - committed at r5560 + r5567

Posted: 21 Jul 2006 20:18
by mart3p
Richk, are you aware that you didn't commit roadstops.grf at r 5562 (just in case you forgot ;) )

Here's a bugfix for a problem reported a while ago, refittable road vehicles not being refitted to the correct cargo when cloned. Essential for Long Vehicles GRFs. :)

Edit: Just seen your PM, I will look into it straight away.


Edit: DONE - committed at r5574

Posted: 21 Jul 2006 20:56
by mart3p
Sorry about the compile warnings. :oops: MSVC2005 didn’t complain, but I suppose that’s not a surprise. Anyway, this patch should fix it.

Edit: DONE - committed at r5573

Posted: 21 Jul 2006 21:10
by gigajum
Cause Richk overread it in the miniIN thread (imo) :)

Edit: DONE - committed at r5576

Posted: 22 Jul 2006 02:22
by Frostregen
Here's the update for the Copy&Paste Patch again.
Also a small update to patch cleanly again.
-> Now applies to MiniIN rev 5579.

Changes:
DONE-> Bugfix: Convert Depots/Tunnels/Bridges too
DONE-> Fix: Bridge end out of selection at "copy time"
DONE-> Fix: Tunnel end out of selection at "copy time"
DONE-> Feature: estimate Costs more exact(at all ;))
DONE-> Feature: Choose to _copy_: Own stuff
DONE-> Feature: Choose to _copy_: Road
DONE-> Feature: Choose to _copy_: Rail

The new copypaste.grf is linked, as it won't be included within the .patch file.
copypaste.grf v5

Edit: DONE - committed at r5587

Posted: 22 Jul 2006 02:50
by gigajum
i fixed the fix for the advanced autoreplace, which failed with an assert failure, if you replace only the engine and not the waggons and change the rail type.

Haukinger has not fixed it :(

note: this is the fixed update version, not a fix for his update, against MiniIN.

Edit: DONE - committed at r5717

Posted: 22 Jul 2006 11:37
by mart3p
Here’s the fix for the assert I’ve been getting with subsidiaries on, when selecting a road vehicle of a subsidiary company, from a station vehicle list.

Edit: DONE - committed at r5588

Posted: 26 Jul 2006 05:41
by gigajum
Ok here's the fix for percentile unloading at a station that not accepts this cargo.


Edit: DONE - committed at r5661

Posted: 26 Jul 2006 06:50
by gigajum
I don't know if that what i fixed caused that bug

If it not caused it, that fix changes the code to start/stop not ALL single waggons of EACH train. Only the engines of each train are enough. Saves some cpu time (imo).

Edit: DONE - committed at r5587

Posted: 30 Jul 2006 15:10
by Wolf01
Adjoin stations patch:
- you can place different stations adjacent (with CTRL)
- you can join stations if they fit in the station_spread
- you can do both these things at the same time (without CTRL)
- you can disable this in configure patches -> stations (join distance is set to 1 tile)

Credits:
Wolf01 (Idea,testing)
Frostregen (Coding)
#OpenTTD (Support)

Posted: 30 Jul 2006 19:01
by mart3p
This patch fixes a bug reported (by ddream) in the MiniIN problems thread. When building a drive-through road stop, a road connecting the stop to a road on the adjacent tile, was built on one side only. This patch disables the building of connecting roads for drive-through stops (same behaviour as TTDPatch).

Edit: DONE - committed at r5658

Posted: 31 Jul 2006 07:36
by gigajum
Ok here's a nice one :)

It prevents towns from builing bridges within two tiles to another bridge.
It should be an addition to the Town growth patch. So i did not make it optional.

@ richk: could you please say what's speaking against this to get included.

Edit: DONE - committed at r5826

Posted: 31 Jul 2006 07:41
by gigajum
A small update to the waypoint stats. It now counts trains over a year, too. On huge train networks one month is sometimes a bit low.

Edit: DONE - committed at r5720

Posted: 31 Jul 2006 08:35
by richk67
gigajum wrote:@ richk: could you please say what's speaking against this to get included.
Nothing... I just ran out of time last night... I think my last commit was at 1.30am or something. I'll add it tonight. (Normal service is nearly resumed ;) )

Posted: 02 Aug 2006 19:57
by SirkoZ
Rich - please - tell me - why don't you include my improved_vehicle names + speeds patch already - I think with the new physics patch, the real horse power of TGV (13600) and EuroStar (16000) will help rather nicely with hill trains (I PMed you, but I guess there's too much of everything...). :)

BTW - I have some new mini-in-size-maxi-in-functionality patches in the works. :)

Posted: 02 Aug 2006 20:33
by richk67
Much nicer variety than it was; good work. Last I looked it seemed all was TAM - a manufacturer I had never heard of. Perhaps we ought to consider having some Opels, and later trucks should be mainly Volvo and Mercedes who totally dominate the real world truck market.

OK. Good news and bad news. Good news - origveh looks good. Bad news is the changes to tables\engines.h dont compile cleanly as these have been recently added to by the physics patch. If you create a MiniIN version of this to integrate with the physics patch, I *will* add it.

Posted: 02 Aug 2006 21:55
by SirkoZ
richk67 wrote:Much nicer variety than it was; good work. Last I looked it seemed all was TAM - a manufacturer I had never heard of. Perhaps we ought to consider having some Opels, and later trucks should be mainly Volvo and Mercedes who totally dominate the real world truck market.

OK. Good news and bad news. Good news - origveh looks good. Bad news is the changes to tables\engines.h dont compile cleanly as these have been recently added to by the physics patch. If you create a MiniIN version of this to integrate with the physics patch, I *will* add it.
Indeed - perhaps I forgot to tell you that I have revised all the names. :)

I will update it immediatelly.

Thanks many times. ;)

Posted: 02 Aug 2006 22:36
by SirkoZ
There - I have posted it in its respective topic. Just follow the link in my signature.

Thanks. 8)

Posted: 02 Aug 2006 23:30
by richk67
Done at r5722 :)