Page 30 of 104

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 22 Mar 2008 18:13
by mart3p
Trond wrote:I do have the old industrial station v0.98 installed, maybe that can make this happen?
No, I don't think the old industrial stations could have anything to do with it. But why do you still have the old industrial stations installed? ISR now has all the stations that were in the old v0.98. If your game is still using stations from the old industrial stations, replace them with ISR stations and then remove the old GRF.
Trond wrote:I cannot put my finger on anything that would cause this bug to appear...
Nor can I, is anyone else having the same problem?
Trond wrote:Besides that, I LOVE these stations... Just hope there will be no more ID-swapping in the future :P
Well, if you want us to add more stations to ISR in the future, if afraid it means more ID changes.

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 22 Mar 2008 20:09
by OzTrans
Great set ... well done ...
mart3p wrote: ... train shed bug ... is anyone else having the same problem? ...
If the bug can be made to disappear by moving the map or other windows over and across it; it is most likely a sprite sorter problem. The train shed may not have enough height, as in 'zextent = size of sprite in z direction'; or a nearby sprite has too much height. Also the x-/y-offsets can be wrong too, even if the sprite is correctly positioned.

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 22 Mar 2008 20:38
by mart3p
Thanks OzTransLtd, :) yes I understand what can cause this to happen, but what I don't understand is why Trond is having this problem but I can't seem to reproduce it.

The bounding box of the sprite causing this problem is set a bit wider than it should be. The code for this station was taken from the old industrial stations with virtually no changes.

The other way it could be fixed is to make the light-blue area of the sprite transparent. The light-blue just indicates an area of the sprite that should never show.

It’s just a bit difficult to tell if I’ve fixed the problem if I can’t reproduce it. :?

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 22 Mar 2008 21:27
by OzTrans
mart3p wrote:... I don't understand is why Trond is having this problem but I can't seem to reproduce it. ...
It could be the coal mine station or the signal that triggers the redraw of one shed sprite but not the other. Try to build his set up ... or a save game would help here.

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 22 Mar 2008 22:14
by mart3p
Yes I’ve already tried building his set up and still didn’t have the problem. Anyway, I’ve sent Trond a test GRF that I’m hoping will fix the problem.

>Trond: check your PMs. :)

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 05:20
by Trond
It seems to be fixed in that test version :) :bow:

I havent played a lot with it yet (its early morning ;)) but I replaced my station with it and moved around and the bug did not show up.

I doubt a savegame would help very much, you probably wouldnt be able to load it; I use latest nightly with six patches applied to it, so you would probably need my OTTD version to load the savegame too :) (station supplies, daylenght, build & refit, distant join stations, middle stop and cityrating patches).

So I think you managed to fix it, but when I get to play it a bit more, I will focus on building some steelmill stations here and there and see if the problem occurs again.

Anyways, I still love the work you're all doing with this, and this little tiny bug would never stop me from using this AWESOME station set! Also I'm kinda sorry to 'ruin' the release with this bugreport, kinda feels wrong, but it had to be done :)

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 07:42
by mart3p
Trond wrote:It seems to be fixed in that test version :) :bow: ...
Good, I'm glad the fix seems to work. :)

I will probably do a bug-fix release of ISR at some stage, but will give it a while to see if any other little problems show up.
Trond wrote:Also I'm kinda sorry to 'ruin' the release with this bugreport, kinda feels wrong, but it had to be done :)
No no, bug reports are welcome, thanks for reporting it. It all helps towards making ISR even more AWESOME. :D

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 08:07
by Trond
The bug is gone. Cant seem to find it anywhere :lol:

I would find it strange if I'm the only one getting this bug, so i expect some more will post when easter is over and the people are back home.

Oh, and about the ID-changing, its definately worth it, it's just a bit sad that I cant use the newest for my major savegame... It have more than 700 stations (big map) and 1100 trains :P Would be a real pain to check all those to see wich ones need to be replaced for the game to run. I just look around in my smaller games and see wich stations have tiles without tracks and change those. With 700+ stations thats a LOT of work, hehe :P Oh well, thats what you get for building a lot of small routes with terminus and roro stations, hehe :D

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 08:22
by Sanchimaru
Hey, Trond, thanks for the report! never doubt to report one, as Mart says, you help the set being great! 8) I'm glad you could solve the problem. Also, I'd love to see some screenshots from that mega-game of yours with the stations activated! but I know what you mean about replacing all of them...

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 10:46
by Kickme93
This Is One Of My Favorite Station Additions, Thanks For Making It

Suggestion: Reckon You Could Rebuild The Industry's And Make A Built In Station In It?

Just A Quick Suggestion, Not Sure If It Is Possible.

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 11:33
by Sanchimaru
Hello and welcome!! >>THUDD<< (kick sound)
:P

Thanks, I'm glad you like the set! We are enjoying a lot creating it.

As for your suggestion, that would surely look well, but it has some problems:
  • It would limit too much the transport to trains, and there are other 3 means to transport in Transport Tycoon ;)
  • When multiple players are in a game, it would restrict the use to only one of them, causing a lot of problems.
So, basically your idea is achieved via this set itself: It provides you with hundreds of totally useless tiles :mrgreen: that help the industries look like they have a more complex infrastructure. You can also build facilities for harbors, and road vehicles, etc.

If you have some game running, you can share some pictures of it in the screenshots section of the forums!

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 12:02
by Kickme93
Well At The Minute With Myself Being New To The Game And The Forums I'm Still Learning.

I'm Experimenting A Lot With Your Station Renewal And Various Other Station Renewals.

Ill Post A Screenshot Of Later Of One Of My Experiments

And Thanks For The Kick XD

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 16:37
by Trond
Isnt it hard to hit shift for every word to get that capital letter kickme?? ;)

Anyways... I *think* I discovered another bug... On a pure mineral silo station. This one is constant, meaning it doesnt go away when moving around. I tried building another similar station at another mine, and the result is the same. only happen for that state (2-300tonns of coal?). It doesnt happen with Iron ore.

If this cannot be reproduced I'm guessing it have something to do with the fact that the station is replaced in a savegame from a station from ISR 0.5.0. I did try to re-replace it, but it didnt change anything...

Also the valuables shed stations have only rails, they dont change to maglevrail... This was the same in 0.5.0.
coalminebug.png
coalminebug.png (52.36 KiB) Viewed 3033 times

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 16:52
by broodje
I have the same bug as reported above on a brand new game.

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 17:21
by mart3p
>Trond and broodje: thanks for the report, it looks like a bugfix release will be needed sooner than I thought. ;) I will start looking into it.
Trond wrote:Also the valuables shed stations have only rails, they dont change to maglevrail... This was the same in 0.5.0.
Why didn't you report it in v0.5.0 then? :D I will look into this one as well.

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 17:42
by krtaylor
Yes, that is the exact same bug I reported previously via IM but couldn't catch a screenshot of.

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 18:44
by mart3p
>krtaylor: Well, we've found it now, a screenshot helps a lot.

I've fixed the coal platform bug. The valuables shed bug wasn't a code problem, when I checked the graphics I found the track was drawn on the sprite like this:
valuables track.png
valuables track.png (1.5 KiB) Viewed 2936 times
>Ben_K: Hope you don't mind, I had to edit your sprites. ;)

I will hopefully have a fixed version posted in the next few hours.

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 19:15
by Kickme93
Will There Be Any Additions In This Fixed Update Or Just The Bug Fix?

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 20:28
by mart3p
>Kickme93: It's just a bugfix release. You don't expect more new stuff in just two days do you? :roll:

I've posted the new version. I have updated the previous files rather than posting them here. That way Sanchimaru doesn't have to change his links again. ;) So, you can find v0.6.1 here.

Re: Industrial Stations Renewal (v 0.6.0 available!)

Posted: 23 Mar 2008 20:30
by Kickme93
mart3p wrote:>Kickme93: It's just a bugfix release. You don't expect more new stuff in just two days do you? :roll:
Sorry I'm New To The Graphics Creating And Making Etc..

Ill Get The Bugfix Now Shall I? :P