NFORenum v3.4.6 released (NFO renumberer and linter)

[George]

As you can see, props 0A, 10, 12 are not aligned correctly. Could you, please, make arrangement to take escapes into account?

Code: Select all

 2556 * 82	 00 07 15 02 FA
                 08 6D           6D          
                 09 24           00          
                 0A \b1930 \b2175
                 \b1930 \b2175
                 0B 0A           00          
                 0C 03           03          
                 0D 08           08          
                 0E 08           08          
                 0F 08           08          
                 10 \w1111        \w1111       
                 11 FF           FF          
                 12 \wx480E        \wx480E       
                 13 1F F8        00 00       
                 14 1F           1F          
                 18 20           20          
                 19 0A           0A          
                 1A FF           FF          
                 1B 02           02          
                 1C 07           07          
                 1D 06           06          
                 1E 05 0C 0D FF  05 0C 0D FF 
                 1F 0F           0F

[DaleStan]

You can add 80 to the operation number to make it apply only if the target is not defined yet.

NFO renum says

Code: Select all

//!!Error (117): Offset 2: Invalid operation 80.
   14 * 9	 0D 00 80 01 FE "VC" 00 01

What am I doing wrong?

I thought the wiki also said that the only valid operation for such action Ds is 00.

I can't find anything unambiguous now, though. I'll have to check the code and fix the wiki.

[Painy]

I just made a simple newgrf that makes all standard train engines available for all climates.

Code: Select all

  2 * 7		00			// action 00
		00			// feature 00 = trains
		01			// properties to change
		1B			// for 27 vehicles
		00			// ID of the first vehicle (Kirby Paul Tank)
		06 0F			// climate 1=Temperate, 2=Arctic, 4=Tropic, 8=Toyland

Compiling the nfo works allright, ingame testing of the compiled newgrf also works as intendet, but NFORenum tells me "Error on sprite 2.".
Looking up my nfo-file again shows this line above sprite 2: "//!!Error (65): Expected 26 more bytes for prop 06."

Am I doing something wrong in my nfo code or is it a glitch in NFORenum?

[Zephyris]

You need to specify the new value of the variable for each vehicle you are modifying, ie. you have to specify the climate availability 27 times for 27 vehicles...

Code: Select all

  2 * 33      00         // action 00
      00         // feature 00 = trains
      01         // properties to change
      1B         // for 27 vehicles
      00         // ID of the first vehicle (Kirby Paul Tank)
      06 0F         // train 1
         0F         // train 2
         0F         // train 3
         0F         // train 4
         0F         // train 5
         0F         // train 6
         0F         // train 7
         etc.
         0F         // train 27

Just a little comment: Toyland vehicles in all climates? Really!?

[Painy]

ok thanks mate NFORenum error is gone now.

Just a little comment: Toyland vehicles in all climates? Really!?

didn't think about toyland vehicles...I guess they will stay where they are then

[DaleStan]

Compiling the nfo works allright, ingame testing of the compiled newgrf also works as intendet

Is that TTDPatch or OpenTTD?

[Painy]

Compiling the nfo works allright, ingame testing of the compiled newgrf also works as intendet

Is that TTDPatch or OpenTTD?

OpenTTD r18867

[peter1138]

For your information, as of r18884 OpenTTD is more strict about this, and will disable a NewGRF if this problem occurs. In addition we removed the debug diagnostics regarding length checking as they were often incomplete or just wrong, and complicated the code somewhat. And of course NFORenum is a much better tool for validating NFO

[Rubidium]

There seems to be a reoccuring spelling mistake with precede; it is often written as preceed (or preceeding), which is according to Merriam-Websters and Oxford's dictionary incorrect. The attached patch fixes all instances of this error.

[DJ Nekkid]

renum r2300 do not seem to support new rails, and it also crashes when trying to do its job.

In the Action0 i get a "linter failure" - Unknown feature byte ... i.e. it dont support feature 10
The action1 crashes renum. I drive windows7 64bit on a Intel I7-820.
Action2 and 3 i dont know, as it crashes on Action1

More info can be provided if needed.

[DaleStan]

More information is needed.

What information is needed can be provided if needed.

[DJ Nekkid]

the .nfo and a screenshot ?

i'll fix it when i come home from work

[FooBar]

More information is needed.

Here's the specification:
- http://wiki.ttdpatch.net/tiki-index.php ... 0Railtypes
- http://wiki.ttdpatch.net/tiki-index.php ... 2Railtypes
- http://wiki.ttdpatch.net/tiki-index.php ... 2Railtypes
- http://wiki.ttdpatch.net/tiki-index.php ... pe_and_cid

And obviously feature 10 needs to be legalized for all actions 0 through 4.

[DJ Nekkid]

Here is a screenie of the error, plus the code, the action1 is line 66

Code: Select all

.....

-1 * 0  01 10 01 \b10
-1 sprites/pcx/hstr.pcx         01      01      1       64      32      -16     -32
-1 sprites/pcx/hstr.pcx         66      01      1       64      32      -16     -32
-1 sprites/pcx/hstr.pcx         131     01      1       64      32      -16     -32
-1 sprites/pcx/hstr.pcx         196     01      1       64      32      -16     -32
-1 sprites/pcx/hstr.pcx         261     01      1       64      32      -16     -32
-1 sprites/pcx/hstr.pcx         326     01      1       64      32      -16     -32
-1 sprites/pcx/hstr.pcx         391     01      1       64      39      -20     -32
-1 sprites/pcx/hstr.pcx         456     01      1       64      23      -12     -32
-1 sprites/pcx/hstr.pcx         521     01      1       64      23      -12     -32
-1 sprites/pcx/hstr.pcx        586     01      1       64      39      -20     -32
-1 * 0  02 10 60 01 00 \w0

[FooBar]

Here is a screenie of the error, plus the code, the action1 is line 66

The error specifies sprite numbers, not line numbers. If you have an empty line or a comment somewhere, line numbers and sprite numbers aren't equal anymore. I made that mistake once myself...

Not that you couldn't be right, but just that you could be wrong

[DaleStan]

FooBar: Sorry. I can find that information just fine. What I couldn't (everyone, please note tense) find was a demonstrating NFO.

George: Your issue with tabulating escapes should be fixed now. Mostly, it took me quite a while to muddle out how to fix it.

[DJ Nekkid]

you can try this one DaleStan?

The action 1-2-3 is a the bottom, currently commented out in sprites/nfo/nutracks.nfo

[George]

FooBar: Sorry. I can find that information just fine. What I couldn't (everyone, please note tense) find was a demonstrating NFO.
George: Your issue with tabulating escapes should be fixed now. Mostly, it took me quite a while to muddle out how to fix it.

What am I doing wrong?

Code: Select all

 1517 * 82	 00 07 15 02 E8
                 08 6D           6D          
                 09 24           00          
                 0A \b1930 \b2175
                 \b1930 \b2175
                 0B 0A           00          
                 0C 03           03          
                 0D 08           08          
                 0E 03           03          
                 0F 08           08          
                 10 \w450        \w450       
                 11 FF           FF          
                 12 \wxDCE7        \wxDCE7       
                 13 1E F8        00 00       
                 14 11           11          
                 18 20           20          
                 19 0C           0C          
                 1A FF           FF          
                 1B 02           02          
                 1C 08           08          
                 1D 06           06          
                 1E 01 02 00 FF  01 02 00 FF 
                 1F 0F           0F

[DaleStan]

Sorry. I misspoke. It should be fixed in r2304.

[George]

Sorry. I misspoke. It should be fixed in r2304.

Thank you, now it is fixed for prop 10 and 12. As for prop 0A, do I understand it right that you've decided not to change it?

Code: Select all

 1517 * 82	 00 07 15 02 E8
                 08 6D           6D
                 09 24           00
                 0A \b1930 \b2175
                 \b1930 \b2175
                 0B 0A           00
                 0C 03           03
                 0D 08           08
                 0E 03           03
                 0F 08           08
                 10 \w450        \w450
                 11 FF           FF
                 12 \wxDCE7      \wxDCE7
                 13 1E F8        00 00
                 14 11           11
                 18 20           20
                 19 0C           0C
                 1A FF           FF
                 1B 02           02
                 1C 08           08
                 1D 06           06
                 1E 01 02 00 FF  01 02 00 FF
                 1F 0F           0F