Community Integrated Version Build 1 (Test & Bug Fix)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
DeletedUser5
Transport Coordinator
Transport Coordinator
Posts: 277
Joined: 07 Oct 2007 15:10

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by DeletedUser5 »

About traffic lights: there are three different grfs so there should be a link to all grfs and note to rename the on you like to trafficlights.grf
I'll attach them in this post.
Attachments
trafficlights_dark.grf
(2.03 KiB) Downloaded 91 times
trafficlights_light.grf
(2.03 KiB) Downloaded 105 times
trafficlights_wooden.grf
(2.03 KiB) Downloaded 86 times
User avatar
Gedemon
Traffic Manager
Traffic Manager
Posts: 150
Joined: 29 Apr 2004 21:53

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by Gedemon »

Ammler wrote:We still have the desync issue to find. We like to have a MP safe CIV, won't we?
Yes, I'll like to play it in MP, but debugging desync on a patchpack will be difficult I guess... :mrgreen:

Do you have the ability to test a build with only the tracksharing patch ?

I've tried it quickly on my LAN and didn't notice problems, but not yet on a large game... Should we test on a big savegame from trunck ?
User avatar
Ammler
President
President
Posts: 953
Joined: 18 Jun 2006 18:18
Location: Switzerland
Contact:

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by Ammler »

Gedemon wrote: Do you have the ability to test a build with only the tracksharing patch ?
Have you IRC? join me at #openttdcoop.dev

I have setup the server as you see in my post and activated all sharing options, after about 10-20 mins, it desyncs. Then I deactivated Tracksharing and since then it runns, still. Viktor also had a visit yesterday and talked about his patch, he also mentioned some desyncs.
wleader wrote:The current downloads of the build are available for Windows and Linux.
I suggest to link to the Release posts, not the files directly, so we could replace them. As I did. :-)

Greets
Ammler
User avatar
Gedemon
Traffic Manager
Traffic Manager
Posts: 150
Joined: 29 Apr 2004 21:53

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by Gedemon »

Ammler wrote:
Gedemon wrote: Do you have the ability to test a build with only the tracksharing patch ?
Have you IRC? join me at #openttdcoop.dev

I have setup the server as you see in my post and activated all sharing options, after about 10-20 mins, it desyncs. Then I deactivated Tracksharing and since then it runns, still. Viktor also had a visit yesterday and talked about his patch, he also mentioned some desyncs.
right, tested more, and I've got desync on LAN too. :(

can you try with only railway tracks and stations shared and tontile paiement to 0 ?

seems more stable right now with these settings.

that would mean that the tontile calculation is ok, but paiement cause desync. ?(

I'll try to connect on IRC tomorrow...
User avatar
SirXavius
Transport Coordinator
Transport Coordinator
Posts: 302
Joined: 28 Jun 2006 18:25
Location: Florida

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by SirXavius »

I took out the .60 openttdw.grf, the OTTD .exe, and the .cfg file, and replaced it with yours. I got a message saying this version requires a windows version higher than 98/ME,etc. and even when i used this build's .grfs into my usual data folder, it didn't recognize them. I'm actually only interested in the traffic lights but not in de- and re-compiling. Any news?
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by Roujin »

Unfortunately my traffic lights v2 causes some bad CPU usage (only if traffic lights are actually used). I fixed the bug in v2.1 (post)

If you want to fix it manually in your build, open road_cmd.cpp, search for the function GetTLState, and remove the line MarkTileDirtyByTile(tile);
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
yorick
Engineer
Engineer
Posts: 80
Joined: 23 Mar 2008 08:53

Re: Community Integrated Version Build 1 (Accepting Submissions)

Post by yorick »

Ammler wrote:Hello

I played around with snow-in-temperate, but didn't test it well enough, so you shouldn't include it in final release, but maybe its worth to open a thread about, no idea. ;-)
or a CIV experimental?

The patch is based on WWOTTDGD/1 from Truelight.

Greets
Ammler
I noticed that this patch has quite a few bugs in it: some newindustries aren't drawn properly, newhouses doesn't have a snowline variable, trees make the snow disappear.
PhilSophus wrote:My More realistic loans system patch updated to current trunk.
The same for this one, there are a few drawing glitches on the finances window.
PhilSophus
Chairman
Chairman
Posts: 776
Joined: 20 Jan 2007 12:08
Location: Germany

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by PhilSophus »

yorick wrote:
PhilSophus wrote:My More realistic loans system patch updated to current trunk.
The same for this one, there are a few drawing glitches on the finances window.
There was a bug that I thought I fixed. Are you sure you are using the fixed version from here? [Edit: removed now obsolete link]

Edit: To avoid confusion: This release now contains the fix.
Last edited by PhilSophus on 29 Apr 2008 19:15, edited 2 times in total.
"The bigger the island of our knowledge, the longer the shore of our ignorance" - John A. Wheeler, Physicist, 1911-2008
wleader
Engineer
Engineer
Posts: 123
Joined: 18 May 2007 09:04

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by wleader »

PhilSophus wrote:[
There was a bug that I thought I fixed. Are you sure you are using the fixed version from here?
The code that was built before this update was uploaded so the fix hasn't made it into CIV1 yet. I'm hoping this afternoon, I can use your fix, and Roujin's traffic lights fix, as well as update to the current trunk again. We'll see how it goes.
wleader
Engineer
Engineer
Posts: 123
Joined: 18 May 2007 09:04

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by wleader »

Ammler wrote:
wleader wrote:The current downloads of the build are available for Windows and Linux.
I suggest to link to the Release posts, not the files directly, so we could replace them. As I did. :-)
Done. I've also updated the patch and windows build. The new code contains Roujin's performance fix for traffic lights, and PhilSophus's fix for the graphics glitch in the finances window.

Does anyone have any leads on the desyncs? I know that in game rivers can cause a desync.
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by Roujin »

wleader wrote:[...]
Does anyone have any leads on the desyncs? I know that in game rivers can cause a desync.

Oh, they do? Oh, you actually included it? [double surprise] I thought you wouldn't include it because it hasn't got an option.
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
User avatar
trainmaster611
Traffic Manager
Traffic Manager
Posts: 222
Joined: 21 Dec 2007 16:33

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by trainmaster611 »

Can you implement this patch for dynamic engine pooling? Its r12870

http://fuzzle.org/o/enginepool12870.diff
Vikthor
Engineer
Engineer
Posts: 69
Joined: 13 Jun 2004 16:57
Location: Prague, Czech republic

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by Vikthor »

Already implemented in trunk.
User avatar
trainmaster611
Traffic Manager
Traffic Manager
Posts: 222
Joined: 21 Dec 2007 16:33

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by trainmaster611 »

Vikthor wrote:Already implemented in trunk.
Are you sure? I've been looking around and I haven't seen any reference to it being in the trunk :?
User avatar
Maedhros
OpenTTD Developer
OpenTTD Developer
Posts: 603
Joined: 30 Mar 2006 18:24
Location: Durham, UK

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by Maedhros »

trainmaster611 wrote:Are you sure? I've been looking around and I haven't seen any reference to it being in the trunk :?
It was committed in r12924, about an hour ago.
No-one's more important than the earthworm.
User avatar
trainmaster611
Traffic Manager
Traffic Manager
Posts: 222
Joined: 21 Dec 2007 16:33

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by trainmaster611 »

What revision is this patch being made for? If its below 12924, then it should be added.
User avatar
athanasios
Tycoon
Tycoon
Posts: 3138
Joined: 23 Jun 2005 00:09
Contact:

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by athanasios »

Maedhros wrote:
trainmaster611 wrote:Are you sure? I've been looking around and I haven't seen any reference to it being in the trunk :?
It was committed in r12924, about an hour ago.
Very good news. :bow:
http://members.fortunecity.com/gamesart
"If no one is a fool I am also a fool." -The TTD maniac.


I prefer to be contacted through PMs. Thanks.
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by Roujin »

I guess wleader will update it to r12924 (at least).
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
Anunnaki
Engineer
Engineer
Posts: 64
Joined: 16 Aug 2005 16:09
Location: Prague, Czech Republic

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by Anunnaki »

Please,
why is not at the end of FIRST TOPIC of this thread attached file with LATEST CIV1 TEST BUILD (compiled for Win32, or maybe more) ? Or why is not there any information about:
a) which version/revision is actual LATEST CIV1 TEST BUILD
b) what exactly is integrated inside LATEST CIV1 TEST BUILD, i mean exact revision/version of every mod/addon integrated.
c) any information - changelog between TEST BUILDs
d) known BUGs in actual TEST BUILD

I think WIKI with all those necessary (basic) information about this would be great ...
Please, wleader, edit first post and paste there some information about it.

PS: Sorry for my bad english. I think this "MOD" would be great, i have dedicated server where i am playing first revision od test build CIV, but i wish to upgrade to the new version, but i am not developer and i am not able to compile latest working win32 CIV BUILD.

EIDT:
Latest (i hope) build for win32 from here http://www.tt-forums.net/viewtopic.php? ... 23#p685223 have problems, first, CFG is there with "customized" graphics, i deleted them, but than the game give me error message OPENTTDW.GRF file is corrupted or missing. But afther that all seems works. Any sollution what is wrong with error message ? I have tried that on "clean" 6.0.0 and 6.0.1 too, error message is still there.

Thanks for respond.
PhilSophus
Chairman
Chairman
Posts: 776
Joined: 20 Jan 2007 12:08
Location: Germany

Re: Community Integrated Version Build 1 (Test & Bug Fix)

Post by PhilSophus »

Anunnaki wrote:Please,
why is not at the end of FIRST TOPIC of this thread attached file with LATEST CIV1 TEST BUILD (compiled for Win32, or maybe more) ?
That would be nice (and the latest patch, of course). Although, there are links to the latest version.
Anunnaki wrote:I think WIKI with all those necessary (basic) information about this would be great ...
Please, wleader, edit first post and paste there some information about it.
Feel free, to add the missing information to the already existing Wiki page. That is what a Wiki is for, after all.
"The bigger the island of our knowledge, the longer the shore of our ignorance" - John A. Wheeler, Physicist, 1911-2008
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 3 guests