Passengers/Mail with Specific Destinations

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

T-Unit
Transport Coordinator
Transport Coordinator
Posts: 368
Joined: 03 Feb 2007 18:53
Location: Leeds, England

Post by T-Unit »

Isnt the patch for r10198 not the latest one revision? That will probably be your problem
User avatar
DJ Nekkid
Tycoon
Tycoon
Posts: 2141
Joined: 30 Nov 2006 20:33

Post by DJ Nekkid »

tydev417 wrote:I'm trying to use the destinations patch with the timetables of build 10261. I've tried it with BuildOTTD and SVN/TurtoiseMerge.
THAT wont work... patch diff rev need to be the same rev as the source u try to patch :)
User avatar
FooBar
Tycoon
Tycoon
Posts: 6553
Joined: 21 May 2007 11:47
Location: The Netherlands
Contact:

Post by FooBar »

tydev417 wrote:patch diff rev need to be the same rev as the source u try to patch
That's not always true. I've successfully compiled some older patch (not this one TBH) with a newer nightly than the patch revision a couple of times.

If the revisions match it's (almost) guaranteed that it will compile successfully.
If the revisions don't match you can try to compile. If it fails, too bad. If that's the case you can either rediff the patch yourself to match the latest nightly or wait till someone else does it.
User avatar
DJ Nekkid
Tycoon
Tycoon
Posts: 2141
Joined: 30 Nov 2006 20:33

Post by DJ Nekkid »

well, a general rule then ... but there are no rules w/o exeptions u know :)
griffin71
Traffic Manager
Traffic Manager
Posts: 142
Joined: 31 Mar 2007 13:11
Location: Amsterdam

missing cargo_entry.h

Post by griffin71 »

Hello,

I'm trying to apply patch 10198, and I downloaded rev. 10198 through svn.
Applying the patch goes without any errors, but compiling I get the error

Code: Select all

Cannot open include file: 'cargo_entry.h': No such file or directory
Where do I get the file from?
(I checked, the file does not come with rev.10198)
What have I overlooked?

Thanks for your help!
A game worth playing is a game worth modding :-)
User avatar
XeryusTC
Tycoon
Tycoon
Posts: 15415
Joined: 02 May 2005 11:05
Skype: XeryusTC
Location: localhost

Post by XeryusTC »

That file is only available in older versions of the patch, you can find a copy of it some pages back. My best guess is that prissi forgot to add it.
Don't panic - My YouTube channel - Follow me on twitter (@XeryusTC) - Play Tribes: Ascend - Tired of Dropbox? Try SpiderOak (use this link and we both get 1GB extra space)
Image
OpenTTD: manual #openttdcoop: blog | wiki | public server | NewGRF pack | DevZone
Image Image Image Image Image Image Image
User avatar
prissi
Chief Executive
Chief Executive
Posts: 648
Joined: 15 Nov 2004 19:46
Location: Berlin, Germany
Contact:

Post by prissi »

Since cargo_packets (in an incompatible format to this patch) made it to the trunk, I will not work further on this patch. It goes deep into the core, and since the new structure with the list it is even more incompatible to the current trunk, I do not see the point to further adapt things.

Cargo_packets could have been added to this patch quite easily, epscially since they were already there for passengers. However, it does not make sense to have two different (and incomaptible) implementations of cargo_packets. So I will stop.

However, on the bright side this can mean that passenger destinations are soon coming to the trunk in another way. (Although with the current implementation I wonder how this could be done in an efficient way. But maybe this is too old school, and when it is done, our computer will be again fast enough.)
kaan
Route Supervisor
Route Supervisor
Posts: 399
Joined: 02 Apr 2007 20:13
Location: Nørup, Denmark

Post by kaan »

prissi wrote:Since cargo_packets (in an incompatible format to this patch) made it to the trunk, I will not work further on this patch. It goes deep into the core, and since the new structure with the list it is even more incompatible to the current trunk, I do not see the point to further adapt things.

Cargo_packets could have been added to this patch quite easily, epscially since they were already there for passengers. However, it does not make sense to have two different (and incomaptible) implementations of cargo_packets. So I will stop.

However, on the bright side this can mean that passenger destinations are soon coming to the trunk in another way. (Although with the current implementation I wonder how this could be done in an efficient way. But maybe this is too old school, and when it is done, our computer will be again fast enough.)
I can understand why you give up.
Thanks for all the work you have put in to this patch, its not wasted :)

I hope someone else is going to take this idea and put it into code to go with the new cargo packets :)

Code: Select all

if (YouAreHappyAndYouKnowIt) {
    ClapYourHands();
}
Scarzzurs
Engineer
Engineer
Posts: 18
Joined: 14 Apr 2006 14:27
Location: Denmark
Contact:

Post by Scarzzurs »

What a shame. Right now i'm only playing openttd because of this patch. So unless someone come up with something VERY similar, i'm not gonna update my openttd :-)

Anyways: Thank you for your great work! :-)

- Scarzzurs
You are what you create.
griffin71
Traffic Manager
Traffic Manager
Posts: 142
Joined: 31 Mar 2007 13:11
Location: Amsterdam

Post by griffin71 »

A real shame work on this patch is discontinued.

@prissi:
I well understand your feelings, prissi. I agree that unless the patch is going to find its way into the trunk in another way, the choice to put cargo_packets into the trunk is not a good one.
Your work has set a standard to what value cargo/pass. destinations are able to add to the game. Thanks a lot for that!

--griffin71
A game worth playing is a game worth modding :-)
User avatar
prissi
Chief Executive
Chief Executive
Posts: 648
Joined: 15 Nov 2004 19:46
Location: Berlin, Germany
Contact:

Post by prissi »

I think it is not too difficult to adapt this to the trunk cargopackets. But I will not do this. Since its origin and stabilisation, most of the time I am spending in doing meaningless things, like hunting conflicts like the introduction of C++ and so on. I spent near four times more time on catching up than on development. Syncing this to a an extended version of the new cargopackets will most likely just finished, when the next incompatible change arrives.

It seems anybody, who is not developer or does not have very direct communication with them, cannot make some large patches. If they are not included fast (and most larger ones have not been aparently) they will never. In hindsight, when this thing was two weeks without error, but without reponse I should have given up. (Same was with the town growth patch or the season/day night support. I should have been warned.) If I am thinking back, also the subsidizes patch was such a thing, which was first rejected because too big. (Better reasons came later.)

Maybe a roadmap, when there would have been cargo_packets on it, would have been helpful. But there is not even a todo-list for orientation for patch developer.

If you want passengers with destinations use simutrans. If you want network games with passenger destinations, there are only two options: Somebody gets this to current version or somebody adds netowrk support to simutrans. Both some tasks ...
griffin71
Traffic Manager
Traffic Manager
Posts: 142
Joined: 31 Mar 2007 13:11
Location: Amsterdam

Post by griffin71 »

XeryusTC wrote:That file is only available in older versions of the patch, you can find a copy of it some pages back. My best guess is that prissi forgot to add it.
Thanks! I created a .diff in which it is added.
Attachments
destination_r10198_148_fix.diff
prissi's last patch including cargo_entry.h
(77.29 KiB) Downloaded 342 times
A game worth playing is a game worth modding :-)
griffin71
Traffic Manager
Traffic Manager
Posts: 142
Joined: 31 Mar 2007 13:11
Location: Amsterdam

Post by griffin71 »

@developers: As made clear in the above discussion, it is necessary that a thread will be added to the OpenTTD Development forum in which there is a list of the issues developers are currently working on.
Maybe a roadmap, when there would have been cargo_packets on it, would have been helpful. But there is not even a todo-list for orientation for patch developer.
It's really a waste of contributors' effort and programming intelligence, if contributors make their patches that will never make it into the trunk anyway. And I much agree with prissi that a list with things that are scheduled to be developed by the developers is the best contribution they can give at the moment.
I'm much looking forward to see it!
A game worth playing is a game worth modding :-)
User avatar
athanasios
Tycoon
Tycoon
Posts: 3138
Joined: 23 Jun 2005 00:09
Contact:

Post by athanasios »

I agree. Look what happened with blender thread. All those graphics cannot be used yet and we do not know how long it will take. Now we have graphics in wrong scale and so we are still using original 8bpp ones. It is great that we have support for 32bpp, but artists should have been informed earlier. Not that they were not informed at all, but it was a bit late.
With a roadmap coders can work on patches that will be soon implemented and not waste their time.

My suggestion to developers:

Come in contact with all coders that have made patches to see their plans and how they can assist.
Create a new thread and list all patches.
Set a priority (1 - 10) for them.
http://members.fortunecity.com/gamesart
"If no one is a fool I am also a fool." -The TTD maniac.


I prefer to be contacted through PMs. Thanks.
kaan
Route Supervisor
Route Supervisor
Posts: 399
Joined: 02 Apr 2007 20:13
Location: Nørup, Denmark

Post by kaan »

I think that it would be a better choice to go on IRC and speak with the developers when you have an idea for a patch, they do give great feedback and will not keep you in the dark about later changes they are planning.

The problem with a thread or an exact roadmap is that it would stop development in areas where the devs have half a patch lying around for an extended amount of time. I'm sure the devs really take notice and get inspired by the patches and ideas that we offer them.

Code: Select all

if (YouAreHappyAndYouKnowIt) {
    ClapYourHands();
}
Scarzzurs
Engineer
Engineer
Posts: 18
Joined: 14 Apr 2006 14:27
Location: Denmark
Contact:

Post by Scarzzurs »

Hmmm, i tried playing this patch in the lastest released version with a friend just before. Unfourtunatly it kept desyncing... Any ideas?
A fixed version of the older patch would be nice, even if it's not kept up to date with the current version of openttd...

Btw. it seemed that the desyncs appeared in the middle of a month... around 14th or something like that, although it could be randomness...

- Scarzzurs
You are what you create.
mathijsjansen
Engineer
Engineer
Posts: 5
Joined: 25 Jun 2007 23:24

Crash with revision 10198

Post by mathijsjansen »

Hello,

I really enjoy this new function and I hope it will be in the next official version. I've build an extensive network, but now when I try to optimize passenger flows I repeatedly get the same error message:

GB(st->goods{0].waiting_acceptance, 0, 12) == min(4095, total_pass)

The game crashes at the 31st of June 1984 every time. So it might have something to do with saving the game. Before I never experienced crashes of the game so I hope you can help me complete the game until 2050

Greetz, Mathijs Jansen

edit: Added is my latest autosavegame
Attachments
autosave1.sav
Save game just before crash
(532.3 KiB) Downloaded 162 times
Gunvald
Engineer
Engineer
Posts: 21
Joined: 25 Apr 2004 12:31

Re: Passengers/Mail with Specific Destinations

Post by Gunvald »

It's is sure a danm shame this patch i not going to be included in the game.. this patch adds, by fare, the most new aspechts to the game.
Scarzzurs
Engineer
Engineer
Posts: 18
Joined: 14 Apr 2006 14:27
Location: Denmark
Contact:

Re: Passengers/Mail with Specific Destinations

Post by Scarzzurs »

Indeed it does. As long as my version of openttd with this patch works and there isn't another version that works with this, i'm not going to change :-)
I wish i had time to look into it... Although i doubt i could do better then the original author...

- Scarzzurs
You are what you create.
User avatar
DJ Nekkid
Tycoon
Tycoon
Posts: 2141
Joined: 30 Nov 2006 20:33

Re: Crash with revision 10198

Post by DJ Nekkid »

mathijsjansen wrote:Hello,

I really enjoy this new function and I hope it will be in the next official version. I've build an extensive network, but now when I try to optimize passenger flows I repeatedly get the same error message:

GB(st->goods{0].waiting_acceptance, 0, 12) == min(4095, total_pass)

The game crashes at the 31st of June 1984 every time. So it might have something to do with saving the game. Before I never experienced crashes of the game so I hope you can help me complete the game until 2050

Greetz, Mathijs Jansen

edit: Added is my latest autosavegame
use the chat and jump to next year just a tad before 99,9% of 1984 :)
Member of the
ImageImage
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 3 guests