Page 5 of 235

Re: JGR's Patch Pack

Posted: 12 Sep 2015 18:50
by Mizari
When will that be?

Re: JGR's Patch Pack

Posted: 12 Sep 2015 19:40
by JGR
Mizari wrote:When will that be?
Maybe tomorrow.

Re: JGR's Patch Pack

Posted: 13 Sep 2015 07:49
by viking42
Hi,

I suppose one needs a bit more deep understand of OTTD to get the thing running
I copied my install,
installed your win64 files on top,
and ran it
but saw none of the described GRF's, what did i miss ?

Re: JGR's Patch Pack

Posted: 13 Sep 2015 09:53
by JGR
viking42 wrote:Hi,

I suppose one needs a bit more deep understand of OTTD to get the thing running
I copied my install,
installed your win64 files on top,
and ran it
but saw none of the described GRF's, what did i miss ?
The patchpack will refuse to run if any of the 4 GRFs included in the install are missing, however they won't show up in the GRF list as they're classified as part of the base set (i.e. internal).
So if it runs OK the GRFs are installed correctly.

Re: JGR's Patch Pack

Posted: 13 Sep 2015 20:49
by palaceofhate
Hi, thanks for the great patch pack! I was wondering if you had planned to include some sort of copy/paste patch (such as http://www.tt-forums.net/viewtopic.php?f=33&t=45488) or similar functionality?

Re: JGR's Patch Pack

Posted: 13 Sep 2015 21:31
by JGR
palaceofhate wrote:Hi, thanks for the great patch pack! I was wondering if you had planned to include some sort of copy/paste patch (such as http://www.tt-forums.net/viewtopic.php?f=33&t=45488) or similar functionality?
I'm not so keen on the idea TBH. Without wanting to regurgitate the various threads on the subject, it seems a bit unnecessary to me.
On a more objective front though, the patch in that thread is huge and seems to make an excessive number of changes, which would be time-consuming to merge and maintain, so it's unlikely that it'll be included in the near future.

Re: JGR's Patch Pack

Posted: 14 Sep 2015 00:03
by archy
Latest git master gives me a strange linker error:

http://pastebin.com/raw.php?i=0JscY4bE

Re: JGR's Patch Pack

Posted: 14 Sep 2015 00:08
by JGR
archy wrote:Latest git master gives me a strange linker error:

http://pastebin.com/raw.php?i=0JscY4bE
Which platform/OS are you running on?
In the meantime you should be able to get around that by configuring with:

Code: Select all

./configure --without-libbfd

Re: JGR's Patch Pack

Posted: 14 Sep 2015 00:14
by archy
JGR wrote:Which platform/OS are you running on?
an up-to-date 64bit Arch Linux system
JGR wrote:In the meantime you should be able to get around that by configuring with:

Code: Select all

./configure --without-libbfd
With that it works. Thanks.

Re: JGR's Patch Pack

Posted: 14 Sep 2015 01:26
by JGR
archy wrote:
JGR wrote:Which platform/OS are you running on?
an up-to-date 64bit Arch Linux system
JGR wrote:In the meantime you should be able to get around that by configuring with:

Code: Select all

./configure --without-libbfd
With that it works. Thanks.
If you get a chance, it'd be much appreciated if could you see whether the tmp_jgrpp_libbfd_update branch fixes the issue on your system, and what the output of `./configure` is. I've made some tweaks to the configure script.

Re: JGR's Patch Pack

Posted: 14 Sep 2015 01:43
by archy
That one compiles fine.

./configure output: http://pastebin.com/raw.php?i=NtsJ2Jhs

Re: JGR's Patch Pack

Posted: 18 Sep 2015 19:52
by Mizari
An old save (it's not important that it works, I just wanted to check in on it because of realising that certain performance problems had to do with one-way roads without end) suddenly crashed when zooming out with some error about water. I guess it might be something that could occur for others, so... Thus attached.

Re: JGR's Patch Pack

Posted: 18 Sep 2015 21:26
by JGR
Mizari wrote:An old save (it's not important that it works, I just wanted to check in on it because of realising that certain performance problems had to do with one-way roads without end) suddenly crashed when zooming out with some error about water. I guess it might be something that could occur for others, so... Thus attached.
These should both be fixed in in 0.5.1.
The performance issue was due to inclusion the extra large maps patch, as the pathfinder (YAPF) limited the road vehicle path length to the maximum map size (2048). As this has now gone up to 1M, the excessively long paths were causing the performance regression. I've decreased the road vehicle pathfinder limit back down to 2048.
The crash was because the earlier fix for the crash when looking at aqueduct bridge heads using the enhanced viewports patch was incorrect, but I hadn't noticed as the crash was then only triggered when the tile with the index of the tile type of the aqueduct bridge head tile was a water tile, which it generally isn't.

Re: JGR's Patch Pack

Posted: 21 Sep 2015 13:06
by HackaLittleBit
Found you a bug.
It is also in the everest patch.
See attachment for patch.
Reproduce bug.
In arctic climate go above snowline and tree line.
Build random trees.
Result will be cactus.
Question:
Can I use your code to upgrade everest patch?
It is better than mine.

Re: JGR's Patch Pack

Posted: 21 Sep 2015 18:05
by JGR
HackaLittleBit wrote:Found you a bug.
It is also in the everest patch.
See attachment for patch.
Reproduce bug.
In arctic climate go above snowline and tree line.
Build random trees.
Result will be cactus.
Thanks for this fix, I've merged it in (with a minor formatting change), and it'll be in the next release.
HackaLittleBit wrote: Question:
Can I use your code to upgrade everest patch?
It is better than mine.
Please feel free, (it's all GPL, after all).

Re: JGR's Patch Pack

Posted: 21 Sep 2015 18:07
by arikover
Hello!

Really nice patch pack! So far, no crash or bugs to report. I have a question though:
I noticed there is a patch to pick and place houses in the scenario editor. I found the house pick window, which has a similar interface as the NewObject window, but I can't manage to place a house in game. I tried in city centres, in suburbs, but I must have missed something. How to use this patch properly?

(I am using version 0.5.1 of the Patchpack, running on Win 7)

I also noticed an error in the first post: the "Vehicle group info" links to the "Upgrade airport" thread.

Re: JGR's Patch Pack

Posted: 21 Sep 2015 19:08
by JGR
arikover wrote:Hello!

Really nice patch pack! So far, no crash or bugs to report. I have a question though:
I noticed there is a patch to pick and place houses in the scenario editor. I found the house pick window, which has a similar interface as the NewObject window, but I can't manage to place a house in game. I tried in city centres, in suburbs, but I must have missed something. How to use this patch properly?

(I am using version 0.5.1 of the Patchpack, running on Win 7)

I also noticed an error in the first post: the "Vehicle group info" links to the "Upgrade airport" thread.
It seems that the functionality got broken when I fixed a bug in the last release.
I'll probably go through that patch and sort it all out so it works like the object picker window. It should be fixed in the next release.
Thanks for reporting the bug.

Re: JGR's Patch Pack

Posted: 21 Sep 2015 21:04
by arikover
Well thanks for the quick answer and keep up the good work!

Re: JGR's Patch Pack

Posted: 26 Sep 2015 16:12
by JGR
arikover wrote:Well thanks for the quick answer and keep up the good work!
This is fixed in v0.5.2 which is available in the first post.

Re: JGR's Patch Pack

Posted: 28 Sep 2015 00:20
by Mizari
Are there any instabilities with multiplayer to be expected?