Page 2 of 3

Re: [patch] Polyline track building tool

Posted: 02 Nov 2011 00:22
by adf88
Building while paused gives you advantage. Even if we call it a cheat, we can't say that every advantage is a cheat. I'm 100% sure that making game interface more efficient doesn't have anything to do with cheating.

Re: [patch] Polyline track building tool

Posted: 27 Dec 2011 15:43
by adf88
Patch updated
r23663 and 1.1.4

// EDIT
Fixed a bug (placing tunnel in multiplayer caused a crash)
r23677 and 1.1.4

Re: [patch] Polyline track building tool

Posted: 18 Apr 2012 07:57
by elmaniolo
Hi,
I'm sort of addicted to this patch. It doesn't work with new openttd 1.1.2. Would you be so kind and re-write it for new version? Thanks in advance.

Re: [patch] Polyline track building tool

Posted: 29 Jun 2012 11:32
by adf88
Perhaps you are asking about 1.2.X? Try polyline_track_tool_v6_ottd_r23677.diff

Re: [patch] Polyline track building tool

Posted: 11 May 2013 09:12
by adf88
New version (7) is ready. See the first page to download.

Re: [patch] Polyline track building tool

Posted: 13 May 2013 19:18
by Honza_
Hi, thanks for the new version of this pure awesomeness. The additional blue coloured line is helpful.

Do you know, that when building bridges with ctrl (so the last type of bridge is build instantly), the polyline does not save the end of the bridge, but continues from the point before building the bridge? Normal bridge building works fine, but this might use some improvement :-)

Re: [patch] Polyline track building tool

Posted: 14 May 2013 11:08
by adf88
New version (v8) released. I fixed some issues with glitching graphics and the one with bridges reported by Honza_.

Download from the first page.

Re: [patch] Polyline track building tool

Posted: 14 May 2013 19:10
by Honza_
What a quick fix. Thank you very much

Re: [patch] Polyline track building tool

Posted: 15 Jun 2013 13:26
by Honza_
hi, I discovered another bug I think is related to polyline. When placing dock, station coverage is not displayed when it should be. With other station types, it is ok.
Could you please check it?

Re: [patch] Polyline track building tool

Posted: 17 Jun 2013 08:39
by adf88
Which patch and which OTTD did you try?

//EDIT
Never mind, I got it. This bug is certainly my fault :cry: .

//EDIT 2
Fixed in version 8b.

Re: [patch] Polyline track building tool

Posted: 17 Jun 2013 19:27
by Honza_
hi,
works like a charm. Thanks for update.
I have also some ideas from using your polyline patch.
1. doubleclick is fine, but mostly I use ti accidently and cancel my route. Could you maybe consider making some enable/disable switch for it
2. when I build bridge, I have to drag it. How about make it also poly line style, so when I press 'B' I just mark first tile and after that I can drag it without holding button and mark only end point.

Anyway, I like this polyline very much. It is so friendly for people with mouse hand wrist problem :-)
Any trunk ambitions?

Re: [patch] Polyline track building tool

Posted: 14 Aug 2013 12:33
by adf88
New version released (8c). I finally found and fixed the nasty bug that was present earlier. Users probably noticed that sometimes only the last piece of track was placed instead of whole line.
Honza_ wrote:doubleclick is fine, but mostly I use ti accidently and cancel my route.?
Try new version and give a feedback. Probably the bug I described before was causing troubles.
adf88 wrote:when I build bridge, I have to drag it. How about make it also poly line style
bridges, tunnels, roads, canals... I'm thinking of them ;)

Re: [patch] Polyline track building tool

Posted: 14 Aug 2013 18:03
by Vaulter
Heavy conficting in DrawTileSelection with clipboard patch. Previous version was better in this.

Re: [patch] Polyline track building tool

Posted: 15 Aug 2013 09:52
by Lord Aro
Why exactly does this concern you? Patches aren't supposed to work with each other...

Re: [patch] Polyline track building tool

Posted: 15 Aug 2013 11:06
by WWTBAM
Lord Aro wrote:Why exactly does this concern you? Patches aren't supposed to work with each other...
Perhaps because adf88 is the maintainer of both patches :?:

Re: [patch] Polyline track building tool

Posted: 15 Aug 2013 12:44
by adf88
Vaulter wrote:Heavy conficting in DrawTileSelection with clipboard patch.
It was always difficult to merge them, that's why I made a mini patch pack with these two patches.
Vaulter wrote:Previous version was better in this.
Previous version differs only by 2 lines :) Maybe you were applying them in reverse order?

Anyway, I'll publish updated mini patch pack soon.

Re: [patch] Polyline track building tool

Posted: 15 Aug 2013 19:03
by adf88
Done.

Re: [patch] Polyline track building tool

Posted: 18 Dec 2013 13:08
by _dp_
Hi! I like this patch very much but it feels somewhat incomplete, so I have some suggestions.
1. Remove double-click reset. It is really annoying when building fast. Also it is counter-intuitive with that new blue highlight (it should build both segments). And there is no need for finishing line thing, coz it's not always clear when to finish it.
2. But it is alway clear when to start a new line, so there should be some way to do it. IMO just adding separate hotkey for that is fine, I would use it like A - polyrail, CTRL+A - new polyrail line. Autorail in this case is not needed at all.
3. Allow building over already built tracks instead of throwing an error (it is not really building, just switching starting point)
4. When encountered a tunnel/bridge move starting point to other end of bridge. So it would be possible to build bridge first and then build line before and after it with just 2 clicks. (1 click is even better but, I guees, that's not very possible)

Re: [patch] Polyline track building tool

Posted: 18 Dec 2013 14:49
by adf88
Ad. 1 and 2) Actually it's the hardest task to me to design a consistent, easy to use and comfortable set of rules. Autorail must stay under the A key, it cannot be changed. Otherwise people would shout "where the hell autorail gone!!!". I'm opened on suggestions. Have on mind that some people don't use hotkeys at all (especially on tablets). I was considering following solutions:
  • Current. I think it's quite straight, simple and coherent. When I want to start a new polyline, I press A (autorail), build the first segment and then press Ctrl+A to build following segments. The first segment is specific because you must pick booth ends of it - like in autorail. Thus activating the autorail tool to build the first segment of a polyline is quite logical. This is straightforward: A - place a segmant, CTRL+A - connect a segment.
  • The double click is problematic, I know. From one hand it allows you to easily finish a polyline (e.g. if you don't use hotkeys) but from the other hand it can be triggered accidentally. I'm not sure what to do. Leave? Remove? Make it customizable (new setting)?
  • New setting - what rail tool to use - classic autorail style or polyrail style. Classic autorail style would be by default. With polyrail style, hotkeys would work like you suggested: A - start a new polyline, Ctrl+A - connect another segment. I'm opposed to this idea because it doesn't differ much from current solution and it would "hide" the new feature (polyline) behind settings.
  • New hotkey. :S I don't like this idea. Too many hotkeys. People wouldn't know about it anyway. Besides, which key would it be?
Ad. 3) Yeah, you're right. Adding to my TODO list.

Ad. 4) Sounds interesting ... but the tool can't be too smart. It cannot make arbitrary decisions. Players would mostly like it, but not always. Instead of moving the node, a new node could be added so you can choose one or another end of the bridge. I'll think on this.

Re: [patch] Polyline track building tool

Posted: 04 Jan 2014 12:56
by _dp_
Hi,
I made 1 and 2 myself and, well, 2 definitely needs more thought, mb it will be beteer with 3. But 1 is simply great so at least do a way to disable it.
As for 4... sounds ok to me since in that particular case it will be exactly same. But, you know, sometimes it can be even more annoying when tool can't make an obvious decision. Actually I'm still not sure if I like having multiple starting points at all or not. Sometimes it seems handy but sometimes definitely not. Like when I place segment with autorail and then can't remove it with polyrail (in one click). It just jumps from one end to other.