Page 1 of 1

Patch: drag&drop land purchase

Posted: 13 Apr 2008 16:04
by Roest
What the title says. Just a small patch to make it possible to purchase land by drag&drop.

As a side effect, i moved void PlaceProc_BuyLand(TileIndex tile) from rail_gui.cpp to terraform_gui.cpp. Just makes a bit more sense.

Re: Patch: drag&drop land purchase

Posted: 13 Apr 2008 18:31
by Xaroth
woot :bow: :bow: :bow: :bow: :bow: :bow:

been waiting for this one for quite a while

Re: Patch: drag&drop land purchase

Posted: 13 Apr 2008 18:58
by Alberth
In general, patches should be submitted to FlySpray if you want to have them merged into trunk by one of the devs.

You should fix your comments; a line consisting solely of a comment should use C style comment rather than C++ line comments. Also, the commented out return statements look kind of weird to me, however I am not familiar with that part of the code.

Sincerely,
Albert

Re: Patch: drag&drop land purchase

Posted: 13 Apr 2008 19:03
by Roest
Well ok, i didn't make this clear in the first post. This isn't the last word on this. First of all, i made it for myself because i found it kinda weird that functionality wasn't there in the first place and i really missed it. To make it really trunk compatible, i'll have to polish it up a bit.

Re: Patch: drag&drop land purchase

Posted: 13 Apr 2008 19:27
by Rubidium
In general it is wise for people that make patches to do a search for the feature they want to introduce in both the forum and in flyspray (also including the closed tasks). Then you would know what the fate of this patch is.

Re: Patch: drag&drop land purchase

Posted: 13 Apr 2008 19:45
by Roest
Well i did the search now. Guess its fate is that it will be for my single player games only. Good to have anyway.

Edit: So the main concern against it, is that players can simply block others from reaching industries by purchasing the land around them. Would it increase its chances to live in a world beyond my little refuge here, if it would be off by default in multiplayer games, and only available in singleplayer?

Re: Patch: drag&drop land purchase

Posted: 13 Apr 2008 20:28
by Wolf01
I already made it available to singleplayer only but it was rejected many times, not for coding style but for the idea itself

Re: Patch: drag&drop land purchase

Posted: 13 Apr 2008 20:34
by Roest
Wolf01 wrote:I already made it available to singleplayer only but it was rejected many times, not for coding style but for the idea itself
There goes my hopeful career as a path author. :|

Re: Patch: drag&drop land purchase

Posted: 13 Apr 2008 22:54
by athanasios
:cry: Developers don't like such a feature.
But never mind, you 'll make another one.

Re: Patch: drag&drop land purchase

Posted: 04 Jun 2008 04:33
by Tiberius
version bump :)

EDIT: change to svn-diff style (actual code not modified at all)