Page 1 of 2
Improved Shares - Patch 1
Posted: 15 Mar 2008 00:18
by TheJosh
Hey,
I'm going to be making some improvements to shares.
For a complete overview of the changes I'm planning, see this url:
http://wiki.openttd.org/index.php/User: ... ved_Shares
This is part 1, its a small GUI overhaul
The only change in this patch is that all of the owners of a company are now properly listed, and they are under the heading "Company owners:" This is to make way for the future overhaul of shares.
This patch will cause the company window to grow or shrink depending on the number of owners.
This patch also causes the current company to be listed as an owner, so if no-one has bought shares, the current company will be 100% owner. If someone buys 25% of the shares, the current company will become 75% owner, etc etc. If 4 different companies own 25% each, the current company will not be listed.
This patch does not in any way affect the way shares are handled by the game. It is merely a cosmetic patch.
Patch Version: 1.4
OpenTTD Rev: 13013
Changes:
1.1: Made the current player be shown as the manager name.
1.2: Updated the patch to revision 12437
1.3: Updated the patch to revision 12537
1.4: Updated the patch to revision 13013
Re: Improved Shares - Patch 1
Posted: 15 Mar 2008 02:43
by athanasios
Such info shouldn't be missing from trunk from the beginning.
Re: Improved Shares - Patch 1
Posted: 15 Mar 2008 06:35
by Ammler
Hmm, how does a company own itself? Shouldn't the owner be the Manager then?
Re: Improved Shares - Patch 1
Posted: 15 Mar 2008 08:05
by TheJosh
A company owns itself if its unowned by someone else It was simply implied in the previous gui, but is specific now
Re: Improved Shares - Patch 1
Posted: 15 Mar 2008 14:03
by Bilbo
This could be useful, even with current code company can be owned by 3 different people nd current code shows only first two I think.
I think that the line with "self-ownage" should be painted in another color, so you will more easily recognize that it is you. Or perhaps replace the company name by string like "owned by itself" too.
Re: Improved Shares - Patch 1
Posted: 15 Mar 2008 17:00
by Alberth
Maybe use the name of the company-owner for the self-ownership?
[edit: fixed typo]
Re: Improved Shares - Patch 1
Posted: 15 Mar 2008 20:43
by TheJosh
What about:
50% owned by itself
25% owned by Pizza Transport
25% owned by Random Transport
I don't mind changing it, as long as there is some kind of consensus.
Re: Improved Shares - Patch 1
Posted: 15 Mar 2008 20:45
by T-Unit
It would be better if it was the name of the Company Owner.
Re: Improved Shares - Patch 1
Posted: 15 Mar 2008 23:55
by WWTBAM
T-Unit wrote:It would be better if it was the name of the Company Owner.
agree with T-Unit
Re: Improved Shares - Patch 1
Posted: 16 Mar 2008 12:10
by TheJosh
What do people mean by the "company owner"? does that mean the manager?
Re: Improved Shares - Patch 1
Posted: 16 Mar 2008 12:22
by Alberth
TheJosh wrote:What do people mean by the "company owner"? does that mean the manager?
I just missed you at #openttd... yes, I mean to use the name of the manager.
Sincerely, Albert
Re: Improved Shares - Patch 1
Posted: 17 Mar 2008 02:04
by TheJosh
I will change the patch to use the name of the manager, as per many requests
Re: Improved Shares - Patch 1
Posted: 17 Mar 2008 04:12
by dibsen
Using the manager's name seems completely senseless to me since you do not own your company. In fact the company's shares are available on the market as long no company buys them; so i would find a simple phrase like "xx% available" more accurate.
Btw.: I always missed the possibility of emitting new shares like I was used to do back then when I was no Transport but a Railroad Tycoon.

Re: Improved Shares - Patch 1
Posted: 17 Mar 2008 11:54
by TheJosh
I have updated the patch to version 1.1
Re: Improved Shares - Patch 1
Posted: 23 Mar 2008 07:48
by leno4
should be added to the trunk, would be good for mp
Re: Improved Shares - Patch 1
Posted: 23 Mar 2008 23:51
by dibsen
Sorry for posting without checking the newest patch... please allow me to ask three simple questions anyway.
Am I overruled? Is the manager in 100% possession of is company by default? And is she/he neither asked if shares she/he owns are sold nor is accounted the value of those?
Re: Improved Shares - Patch 1
Posted: 24 Mar 2008 02:15
by leno4
Ammler wrote:Hmm, how does a company own itself? Shouldn't the owner be the Manager then?
Maybe if you open your eyes you will see that is has "manager" in (brackets)
Re: Improved Shares - Patch 1
Posted: 24 Mar 2008 17:12
by T-Unit
@leno4: it didnt when he said that
@dibsen: When you set up a company you own the whole company as you will be putting in the money for it, or borrowing it from the bank against your own collateral. Therefore the manager owns 100% of the shares until they decide to go public and sell them off.
Re: Improved Shares - Patch 1
Posted: 27 Mar 2008 08:17
by TheJosh
I have updated the patch again to r12437. See the first post.
Re: Improved Shares - Patch 1
Posted: 02 Apr 2008 04:21
by TheJosh
With the release of 0.6.0, the devs will be happy to start accepting patches and the like, therefore I have updated the patch to the latest trunk rev.
See the first post.