Transport Tycoon Forums

Updated the patch to apply against current trunk

Updated to current trunk

possible get this with along close airport in the trunk in time for openttd 1.2.0?

Hello

MAG101 wrote:possible get this with along close airport in the trunk in time for openttd 1.2.0?

No, no new features were added when the first beta of the next stable version is released. You have to wait for adding it to trunk.

Tschö, Auge

incorrect, trunk will be 'mirrored' until 1.2 is branched off, i.e. with the first release candidate (1.2.0-RC1)

If

Lord Aro wrote:incorrect, trunk will be 'mirrored' until 1.2 is branched off, i.e. with the first release candidate (1.2.0-RC1)

Then

MAG101 wrote:possible get this with along close airport in the trunk in time for openttd 1.2.0?

trunk is intended to be branched shortly. I doubt it. :L

Ehh... One more year...

You are way too optimistic.

This patch is short and adds exactly one simple, useful, unobtrusive feature, and yet is already 4 years and 12000 revisions old. I do not think its chances of going into trunk will be higher in the next year.

The flyspray task for this patch can provide some insight into its history and my thoughts about it.

*reads*

So, basically, what's holding this up is a) a "close airport" patch that one developer doesn't think does enough for players, and b) the NewGRF Airports project which still hasn't taken off?

C'mon, devs! What's wrong with you??

kamnet wrote:C'mon, devs! What's wrong with you??

a) is most certainly waiting on b) as well.

FooBar wrote:

kamnet wrote:C'mon, devs! What's wrong with you??

a) is most certainly waiting on b) as well.

Yeah, that could be the case...

...if only this patch didn't predate the NewGRF airport spec by about two years.

Even if this were the case, I don't know if it makes sense to withhold a feature just because it is remotely related to some vague plans for the future. And, honestly, I think that the part of the NewGRF airport spec that deals with airport overbuilding will have limited used in practice except for very particular situations, so this patch would still be useful.

Rebased against current trunk. A recent commit has forced me to rewrite part of the patch, so use with care.

Updated to current trunk.

*bumps*

Six yeas, and still no inclusion, still new NewGRF Airports either. It's time to get this implemented, because it WILL be an improvement, and if NewGRF Airports does come along, then if that's an improvement we can implement that instead. This issue should be raised again, and if it's not accepted then it's just pure silliness on the dev's part.

Did you want to reply to richk's thread? This is about replacing an existing airport, which is already easier because of the already included close airport patch.

bokkie wrote:Did you want to reply to richk's thread? This is about replacing an existing airport, which is already easier because of the already included close airport patch.

No, he almost certainly wants to reply to this one, which is made much more useful by the patch you mention (this needs the airport being overbuilt to be empty, which that patch makes possible). You might want to consider that they were written by the same author.
Just because one feature is introduced doesn't make all other similar features unnecessary.

I'd support Kamnet's opinion - there's no sign of NewGRF airports any time soon, and this patch's behaviour would work quite reasonably for complete ones anyway. If tile-based airport construction ever gets written, removing that behaviour would be trivial compared to rewriting everything else connected to airports.

Now that the Close Airport button is implemented and working, I see no reason to delay the inclusion of this patch anymore.

kamnet wrote:Six yeas, and still no inclusion, still new NewGRF Airports either. It's time to get this implemented, because it WILL be an improvement, and if NewGRF Airports does come along, then if that's an improvement we can implement that instead.

Note that this patch cannot possibly interfere with newgrf airports in any way, despite some people' insistence: This patch adds no new game state whatsoever so, if at any point in the distant future something related to newgrf airports does get implemented and happens to clash with airport overbuilding, then this patch can be reverted with no ill effects.

FLHerne wrote:

bokkie wrote:Did you want to reply to richk's thread? This is about replacing an existing airport, which is already easier because of the already included close airport patch.

No, he almost certainly wants to reply to this one, which is made much more useful by the patch you mention (this needs the airport being overbuilt to be empty, which that patch makes possible). You might want to consider that they were written by the same author.
Just because one feature is introduced doesn't make all other similar features unnecessary.

The best part of this story is that, before my patch to close airports got merged, airport overbuilding was not considered for inclusion because it was deemed useless without being able to close airports [1]; now that airports can be closed, it is felt that, as a consequence, there is less of a need for airport overbuilding [2].

there's almost nothing more creative than devs finding reasons not to include patches