Page 1 of 6

NewGRF GUI Window

Posted: 23 Nov 2007 14:44
by nycom
Hi all,

I just created a patch to merge the two newgrf windows.

- To add a NewGRF : on the left side, click on a newGRF and press the ">>"' button, or doubleclick on it.
- To Remove a NewGRF : on the right side, click on a newGRF and press the "<<"' button.

Attached is a patch against r11499.

Re: NewGRF GUI Window

Posted: 23 Nov 2007 15:52
by Ben_K
Awesome. This would be a great patch. I hope you can work with the developers to get it into trunk! 8)

Re: NewGRF GUI Window

Posted: 23 Nov 2007 17:01
by Rubidium
How does this look at 320x240 and 240x320? Is it useable at those resolutions?

Re: NewGRF GUI Window

Posted: 23 Nov 2007 17:18
by rabbit67890
Rubidium wrote:How does this look at 320x240 and 240x320? Is it useable at those resolutions?
i guess yes

Re: NewGRF GUI Window

Posted: 23 Nov 2007 17:32
by Octopussy
Very nice !!

Exactly what I want here : https://www.tt-forums.net/viewtopic.php? ... &sk=t&sd=a

Image

You are so fast !!

Thanks a lot !! :P :P :P

Re: NewGRF GUI Window

Posted: 23 Nov 2007 18:10
by Zuu
Nice patch. :) Have you tried to make multi-line selection?

But if that is not currently supported by the GUI "framwork" it might not be that trival to do.
rabbit67890 wrote:
Rubidium wrote:How does this look at 320x240 and 240x320? Is it useable at those resolutions?
i guess yes
If you check you'll se that the by nycom attached image is 615 pixels wide. How will you reduce the window to become 320 or even 240 pixels?

Re: NewGRF GUI Window

Posted: 23 Nov 2007 18:13
by George
Would it be possible to save window size in config if it was resized and use stored size in next window opening?

Re: NewGRF GUI Window

Posted: 23 Nov 2007 19:17
by nycom
Rubidium wrote:How does this look at 320x240 and 240x320? Is it useable at those resolutions?
The minimum size is 607x198.
I don't know how to resize the window and keep the same width for both sides
George wrote:Would it be possible to save window size in config if it was resized and use stored size in next window opening?
I made a litte patch that store the window size in the config file.

Re: NewGRF GUI Window

Posted: 24 Nov 2007 00:55
by athanasios
You made my day, er my night! :] Thanks for this practical patch.
Sorry, besides Pocket PCs who is using 320x240? Let's hold to the standard min. (640x480) and the rest can follow later. To my opinion it is not so trivial.

Re: NewGRF GUI Window

Posted: 24 Nov 2007 01:19
by rbenevid
Great work. Much better than the old one. Maybe we could have both, just for the portable ports?

Re: NewGRF GUI Window

Posted: 24 Nov 2007 07:42
by Rubidium
athanasios wrote:You made my day, er my night! :] Thanks for this practical patch.
Sorry, besides Pocket PCs who is using 320x240? Let's hold to the standard min. (640x480) and the rest can follow later. To my opinion it is not so trivial.
Almost *all* windows are useable on 320x240, except IIRC the configure patches. This includes the main toolbar that resizes for resolutions less than 640 wide. I'm all okay with the GUI being 640x480 or even 800x600 but only when it automatically downscales so it is useable on 320x240. Primarily because it is inevitable that we will some time get Pocket PC (and similar platform) support; we already have quite a lot support for them, it only is not 100% functional.

Re: NewGRF GUI Window

Posted: 24 Nov 2007 11:13
by Octopussy
But the Subsidies window is larger than the NewGRF one and the Vehicle Group Window is also higher than it.

So where is the problem ? :wink:

Image

And we can't resize the Subsidies one ... :roll:

Re: NewGRF GUI Window

Posted: 24 Nov 2007 12:34
by Rubidium
The problem is that the subsidiaries window apparantly wasn't updated to work at 320x240. If you would've opened the vehicle window at 320x240 you would have seen that it would still fit the screen; it would only be smaller. The default size of the windows in OTTD is not necessarily the smallest size.

Re: NewGRF GUI Window

Posted: 24 Nov 2007 23:03
by athanasios
Questions for thought:
How long will pocket PCs stay in 320x240? There are already models that support 640x480.
How long will it take for OpenTTD to be ported to pocket PCs?
How useful would be the NewGRF GUI Window in 320x240? There won't be enough space to fit the new grfs titles (they will be displayed trunkated).

Re: NewGRF GUI Window

Posted: 24 Nov 2007 23:13
by Rubidium
Quite long I fear; an 'issue' with 640x480 is that it is kinda advertised as 320x240 and that you should use that for better quality graphics instead of 'more' graphics, or at least that was discovered when trying to port it. As far as I am aware this was a major reason why we do not have a pocket pc version yet.

There is already a pocket pc port and there is already a vast amount of code as base for a pocket pc port. How long it takes really depends on whether there is a developer with such a device or someone else who wants to cooperate closely to make the port.

Counter question: how useful is a 640x480 GUI window on 320x240? Especially because it is split into two distinct sides, it's kinda useless in that case. I'd rather have truncated text than not being able to 'properly' configure my NewGRF config.

Re: NewGRF GUI Window

Posted: 25 Nov 2007 14:11
by T-Unit
Couldn't it just be programmed to return to the current setup when viewed in 320x240?

Re: NewGRF GUI Window

Posted: 28 Dec 2007 11:40
by Octopussy
Is it possible to update this patch with the new OOP window system ?

Thanks :)

Re: NewGRF GUI Window

Posted: 28 Dec 2007 12:17
by nycom
Octopussy wrote:Is it possible to update this patch with the new OOP window system ?

Thanks :)
OOP ??

Re: NewGRF GUI Window

Posted: 28 Dec 2007 12:24
by belugas
Octopussy has been misleading in believing the widget/window system has turned into an Object Oriented Programming code.
It's not the case, just a little layer of OOP...

Re: NewGRF GUI Window

Posted: 28 Dec 2007 17:19
by LordAzamath
Rubidium wrote:How does this look at 320x240 and 240x320? Is it useable at those resolutions?
How is wiki.openttd.org readable for even 640*480. I tried this just..Wanted to show manual to someone...He couldn't read it...