Patch: Close airports

[cirdan]

All right, thanks for the feedback. I didn't know there was a consensus that the Right Thing (tm) was to hide the button (no one cared to tell me ). I'll make a patch that hides the button in the following days.

[cirdan]

Here it is. The attached patch hides the 'close airport' button for airportless stations, instead of just disabling it.

[cirdan]

Rebased against r14876. The patch named 'v6' disables the 'close airport' button for airportless stations; the other one hides it instead.

[Chico008]

Hi, have this error when i tried to compile.
(using V7 for the last trunk)

[cirdan]

Could you try this new version?

By the way, did the patch apply cleanly? Messages from patch saying 'HUNK FAILED' are clear indications that the patch is not likely to work...

[Chico008]

tried with the new patch, but still same bug when compiling.

but this patch is not ok for Tortoise SVN, so i patched it hand made, with the power of copy/paste keys
(i already done this way with previous version of this patch, with no errors at compiling)

plus, i have a small question, what difference is there between v6 and v7

[Conditional Zenith]

Could you copy/paste rather than screenshot when posting compile errors please.

[Yexo]

plus, i have a small question, what difference is there between v6 and v7

Just read a few posts up:

The patch named 'v6' disables the 'close airport' button for airportless stations; the other one hides it instead.

[Chico008]

Could you copy/paste rather than screenshot when posting compile errors please.

i'd like to, but i can't copy paste from Cygwin.
i tried a "make > file.txt" but errors doesn't appears in the output file.

[Conditional Zenith]

I see.

You can fix that by doing

Code: Select all

make > file.txt 2>&1

to get both output and errors into the file

Also, if you just want the errors in a file, then you can do

Code: Select all

make 2> file.txt

[Chico008]

thx, i'll try this.

so, got this error :

Code: Select all

make[1]: Entering directory `/cygdrive/f/compil_ttd/r14736/objs/lang'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/cygdrive/f/compil_ttd/r14736/objs/lang'
make[1]: Entering directory `/cygdrive/f/compil_ttd/r14736/objs/release'
[SRC] Compiling station_gui.cpp
/cygdrive/f/compil_ttd/r14736/src/station_gui.cpp: In member function `virtual void StationViewWindow::OnClick(Point, int)':
/cygdrive/f/compil_ttd/r14736/src/station_gui.cpp:962: error: invalid conversion from `int' to `void (*)(bool, TileIndex, uint32, uint32)'
/cygdrive/f/compil_ttd/r14736/src/command_func.h:61: error: too few arguments to function `bool DoCommandP(TileIndex, uint32, uint32, void (*)(bool, TileIndex, uint32, uint32), uint32, bool)'
/cygdrive/f/compil_ttd/r14736/src/station_gui.cpp:962: error: at this point in file 
make[1]: *** [station_gui.o] Error 1
make[1]: Leaving directory `/cygdrive/f/compil_ttd/r14736/objs/release'
make: *** [all] Error 2

[planetmaker]

Code: Select all

make[1]: Leaving directory `/cygdrive/f/compil_ttd/r14736/objs/release'
make: *** [all] Error 2

Your path information hints that you're using release r14736 while the latest patches are made for r15177. Is 15177 the trunk version which you tried to compile the patch for? For all other versions it might fail.

[sulai]

Hey guys,

I like this patch a lot, the only thing: the close airport button is way too large
Maybe put a little "close" button next to the "rename" button?

[cirdan]

I'd rather not make that decision myself. I think the position/size/shape of the button is a last-minute detail (it's trivial to change), so I'd rather let the devs decide on that, should the patch ever hit trunk.

[Lord_BoNes]

Just my 2 cents:
I think that the button shouldn't be a "close airport" button, but one of those flags that the vehicles use (just one flag that toggles red or green).

[atalantino]

Does this patch work for ottd 0.63?(sorry, I dont like the r###### thingys, I'm classic)

[Eddi]

look in the first post, there is a patch for 0.6.1, it should usually apply to 0.6.3, too.

[cirdan]

Just my 2 cents:
I think that the button shouldn't be a "close airport" button, but one of those flags that the vehicles use (just one flag that toggles red or green).

Thanks for your suggestion. Unfortunately, the GUI seems to be the only part of this patch where an agreement hasn't been reached, ie, I haven't heard of anyone opposing the feature itself, but everyone appears to have their own idea of how it should look. As it is, I'm reluctant to introduce changes in the patch unless I have a clear indication that such a change would increase the probability of landing in trunk--periodically syncing the patch is already enough work.

Does this patch work for ottd 0.63?(sorry, I dont like the r###### thingys, I'm classic)

look in the first post, there is a patch for 0.6.1, it should usually apply to 0.6.3, too.

In fact, I stopped updating the patch for the 0.6.x series because the patch for 0.6.1 applies (possibly with some offsets) to 0.6.2 and 0.6.3 as well. Complain loudly if it doesn't.

While at it, here are updated versions against current trunk. I'm now using git for managing my patches, so you should apply them with -p1 instead of -p0.

[pavel1269]

friendly update

[cirdan]

Updates against 0.7.0.