Transport Tycoon Forums

Carnildo · Post by **Carnildo** » 26 Jun 2007 18:19

Since my report that opening new windows can cause old ones to be closed was marked as "not a bug", I've been looking into re-designing the window system to get rid of this limitation.

Would re-writing the windowing system in C++ be acceptable? Doing so would get rid of some of the awkward bits currently in there, like the use of the WP() macro and and the dependancies on pointer size and structure padding.

XeryusTC · Post by **XeryusTC** » 26 Jun 2007 18:23

There is a branch for this, it's called cpp_gui IIRC.

FooBar · Post by **FooBar** » 26 Jun 2007 21:29

IIRC, TTDPatch has an option to set the maximum number of open windows. Maybe some feature like that.

Carnildo · Post by **Carnildo** » 27 Jun 2007 00:20

My plan is to remove the limit entirely. It's not hard.

belugas · Post by **belugas** » 27 Jun 2007 00:52

XeriusTC is right. The effort is already underway. Branch cpp_gui.
As the name implies, it is doneby changing actual C based gui system to a more elaborate c++ version.

My plan is to remove the limit entirely. It's not hard.

Seeing at how the branch is going (although it may seems dormant right now), i would say it does not look so easy.
Not just a simple limit would suffice. Redo the whole thing, the right way.

DaleStan · Post by **DaleStan** » 27 Jun 2007 02:19

belugas wrote:XeriusTC

I think your copy/paste system is broken. You might want to look into that.

belugas wrote:
My plan is to remove the limit entirely. It's not hard.
Seeing at how the branch is going (although it may seems dormant right now), i would say it does not look so easy.
Not just a simple limit would suffice.

And how is "realloc the window stack every time you run out of space" either inappropriately simple or too hard?

Carnildo · Post by **Carnildo** » 27 Jun 2007 05:50

belugas wrote:XeriusTC is right. The effort is already underway. Branch cpp_gui.
As the name implies, it is doneby changing actual C based gui system to a more elaborate c++ version.

My plan is to remove the limit entirely. It's not hard.
Seeing at how the branch is going (although it may seems dormant right now), i would say it does not look so easy.

Well, now that I've looked at the existing code, removing the limit still looks easy. Injecting sanity into the GUI class hierarchy, on the other hand, looks hard.

Bjarni · Post by **Bjarni** » 27 Jun 2007 08:47

Carnildo wrote:Well, now that I've looked at the existing code, removing the limit still looks easy. Injecting sanity into the GUI class hierarchy, on the other hand, looks hard.

Just removing the limit gives some unwanted sideeffects like asserting when it tries to open too many viewports. This should really be done the right way.

Bilbo · Post by **Bilbo** » 27 Jun 2007 09:45

Bjarni wrote:
Carnildo wrote:Well, now that I've looked at the existing code, removing the limit still looks easy. Injecting sanity into the GUI class hierarchy, on the other hand, looks hard.
Just removing the limit gives some unwanted sideeffects like asserting when it tries to open too many viewports. This should really be done the right way.

There is some issue with _active_viewports (in viewport.cpp) being a bitmask (so no more windows are possible than bits in the bitmask, which means 32 for int32 or 64 for int64)

I have submitted patch that changed the limit to 60 from 25 (http://bugs.openttd.org/task/925) - it's not unlimited, but raises the limit considerably and is near maximum you can get without some larger rewriting or assertion bugs (aka it worked without problems).

60 should be enough to bridge the limit till someone rewrite the thing completely ...

However, the patch has not been (yet) accepted, but you are still welcome to apply it yourself, test it and if you find any bug, report it (best to do it in the bugtracker directly).

belugas · Post by **belugas** » 27 Jun 2007 10:52

DaleStan wrote:
belugas wrote:XeriusTC
I think your copy/paste system is broken. You might want to look into that.

Sorry XeryusTC... I can't get that Y into place, it seems...

DaleStan wrote:And how is "realloc the window stack every time you run out of space" either inappropriately simple or too hard?

Because it is not simply a matter of reallocating the window stack. It does a lot more. Please look at the branch to find out

Simply reallocating the window stack is not the right thing to do, here. A new kind of stacking is required. Like what we did for XTDWidget. We could have simply incraesed the limit of widgets per window from 32 to 64. Instead, we made it so that the windows do now have an unlimited number of widgets. THAT is the right approach

Bilbo · Post by **Bilbo** » 27 Jun 2007 11:00

belugas wrote: 32 to 64. Instead, we made it so that the windows do now have an unlimited number of widgets. THAT is the right approach

Maybe best will be to increase the limit, then go working for rewriting the code to remove the limit at all ... before the final rewrite is done, at least temporary remedy exists ....

Tomsomethingcon · Post by **Tomsomethingcon** » 27 Jun 2007 13:29

wouldn't being able to open more windows, slow the game engine down, more ?

just my thought

belugas · Post by **belugas** » 27 Jun 2007 14:26

Bilbo wrote:Maybe best will be to increase the limit, then go working for rewriting the code to remove the limit at all ... before the final rewrite is done, at least temporary remedy exists ....

Nope. History shows that temporary fixes have a very long life... So unless the fix is the good one, do not mess around with bogus fixes

Sorry

Tomsomethingcon wrote:wouldn't being able to open more windows, slow the game engine down, more ?

It really should not. Rest assure

[Edit] On second thoughs, it might take a slightly bigger chunk of cpu cycles. But as to know if it would be noticeable, i guess only time will tell[/Edit]

Bilbo · Post by **Bilbo** » 27 Jun 2007 14:58

Tomsomethingcon wrote:wouldn't being able to open more windows, slow the game engine down, more ?

just my thought

Well, if the fix is made good, game will slow down only when so many windows are actually opened and something (like a vehicle) is moving in it.

If you open huncerds of windows with vehicles, you can expect some slowdown ... till you close them

C++

C++

Who is online