Page 3 of 3

Posted: 02 Jul 2006 15:35
by webfreakz.nl
Strange then, i compiled a clean SVN r5477 from /trunk/ and without your patch it does compile ( rebuilt solution in MSVS2005 ). With your patch it gives the warnings in my previous post.

Posted: 02 Jul 2006 18:13
by MeusH
Try this one. Guys told me on IRC that StringID wasn't defined (for some files strings.h was called before openttd.h, which was bad)

Posted: 02 Jul 2006 21:09
by webfreakz.nl
Compiles perfectly! Thanks!

Have fun on your holiday ;)

Posted: 02 Jul 2006 21:29
by MeusH
Thank you so much :) Bye!

Posted: 11 Aug 2006 17:30
by webfreakz.nl
Darn. The patch doesn't work anymore after this revision-changeset: http://svn.openttd.org/cgi-bin/trac.cgi/changeset/5806

Here Tron deletes the function FindLandscapeHeight() which is used about 7 times in measurement_6.patch. Maybe you could update your patch? That would be great.

Posted: 12 Aug 2006 20:16
by MeusH
Allright, I'll take a look at this and fix it.

Posted: 15 Aug 2006 11:36
by MeusH
I'm trying to finalize this patch.
Thanks to Tron, who helped me optimizing the code. Also he helped me realize I used FindLandscapeHeight bad way, or rather I didn't even had to use it.

There are two things, however, that aren't as good as I wanted:

2x1 autorail:
what's wrong:
Dragging in a "diagonal" direction shows length = 2 instead of 1
why it isn't that bad:
It is very rare (or it doesn't happen, ever) to measure length on such a small distance

Level land tool:
what's wrong:
I couldn't do what one user suggested; the measurement isn't reduced by 1 in width and height
why I couldn't do it:
The function I'm measuring in doesn't contain selection method data, but I'll work on it


Please voice your comments, also about the code style. Thank you in advance

Posted: 12 Oct 2006 20:19
by MeusH
r6758 is our happy revision.
Thanks to great help of Darkvater and other developers, and of course your tips and ideas, the patch is ready :wink:

Posted: 12 Oct 2006 20:29
by webfreakz.nl
MeusH wrote:r6758 is our happy revision.
Thanks to great help of Darkvater and other developers, and of course your tips and ideas, the patch is ready :wink:
Finally 8)

My idea, and your programming (meush). Great! 8) 8) 8)

Posted: 12 Oct 2006 21:37
by Darkvater
/me sneaks in

/me looks around

I'll just close this thread then...

/me runs away