Chill's patchpack v14_7

[Cadde]

I see, I need to disable the start time button also when automate is on ...

Can you try again please.
This time do not enable the automate button but use the autofill button, when filled adjust and set start times.
Better now?

Automate keeps adjusting the time over and over again without user input. When GOD clicks the button it means that GOD gives contol over timetables out of his hands to do more important things ...

/me likes kittens ...

Nah srsly dood... Liek i didn't do dat cuz i r pro an shizz... (Ok i'll stop, been on the internet for too long)

But yeah, i meant autofill if that wasn't what i wrote. and i didn't have automate on. But i had used it before i set the time tables. Maybe that's what causes the issue?
Either way, it's nothing but me having manually filled in everything after i used autofill and setting the start dates, still the trains are either 2 minutes early or 2 minutes late even when they are on time.
It's really wierd!

I shall try it with another train line later without using automate once and see if that one can keep it's head straight.

[MagicBuzz]

I think you were using one of the incomplete , now removed, versions MagicBuzz had posted before.
Which shows how important it is to distribute complete binaries ...

I don't think so.
Ok, my first builds were incomplete, but everything needed to upgrade a 1.0.5 installation was present (except the prerequisites found at first page of the forum).
All langs and compat_1.1.nut where present, and on my environment at least, it's more than enougth to get your patchpack working correctly.

(Just kidding MagicBuzz I am a non-violent person in general. )

You scaried me

[ChillCore]

Nah srsly dood... Liek i didn't do dat cuz i r pro an shizz... (Ok i'll stop, been on the internet for too long)

Humpty Dumpty sat on a wall, than the big bad wolf came, bit in the apple and fell down the rabithole.
¿pleh taht seoD

But yeah, i meant autofill if that wasn't what i wrote. and i didn't have automate on. But i had used it before i set the time tables. Maybe that's what causes the issue?
Either way, it's nothing but me having manually filled in everything after i used autofill and setting the start dates, still the trains are either 2 minutes early or 2 minutes late even when they are on time.
It's really wierd!

I shall try it with another train line later without using automate once and see if that one can keep it's head straight.

If a train has a travel time of 10 minutes and you give it 12, the train will not run slower making it early.

I did a little test myself ... had two trains with a travel time of 2 * 5 minutes and a waiting time of 2 * 1 (Autofill) so I adjusted the waiting times to 2 and 3 for each station. Then I set the start times at xx.13 and xx.20, they seemed to be doing fine in terms of running on time.
Mind that my test was rather short and there was no other traffic on the (short) line ...

Does it help if you adjust the waiting times instead of the traveltimes to make the trip take 30 minutes?

Ok, my first builds were incomplete, but everything needed to upgrade a 1.0.5 installation was present (except the prerequisites found at first page of the forum).
All langs and compat_1.1.nut where present, and on my environment at least, it's more than enougth to get your patchpack working correctly.

The only folders I overwrite is my clean nightly installation with a newer nightly, to check if a bug is also in trunk, and my stable release folder.
I never ever install a modified build or nightly over a stable release ...

I know it is explained somewhere to do it like that but I do not see the point of doing that if the downloaded binary is complete, the only thing you are going to get in the end is problems.

For example if openttd.grf changes in the nightly (or the ogfxe_extra.grf in a modified buid ) but you do not overwrite that file than you have messed up graphics.
Also some AI's still depend on compat_1.0.nut or compat_0.7.nut ...

The one and only correct way IMHO is only using compelete binaries. (Even if you overwrite a stable release.)

ps:
My downloaded binaries can now see in the shared folder also when there is a config near the exe ... Yiehaa no more copying the base graphics and sounds sets all over the place.

You scaried me

No need to be, it is way too cold to ride my motorcycle and if I ever make it to your place it would be to have a drink with you ...



Now I need to fix copypaste again ...
I have already but not in the way it is supposed to be fixed.

[Cadde]

If a train has a travel time of 10 minutes and you give it 12, the train will not run slower making it early.

I did a little test myself ... had two trains with a travel time of 2 * 5 minutes and a waiting time of 2 * 1 (Autofill) so I adjusted the waiting times to 2 and 3 for each station. Then I set the start times at xx.13 and xx.20, they seemed to be doing fine in terms of running on time.
Mind that my test was rather short and there was no other traffic on the (short) line ...

Does it help if you adjust the waiting times instead of the traveltimes to make the trip take 30 minutes?

Never got a chance to test it again, will do later. But the problem was that the trains where both running late and the early completely random. And then they changed their timetables whenever they where running late. Should they even change timetables when automate is turned off?
Like i said earlier, i think it happens if automate has been activated before setting up the time tables manually.

That's what i am going to test when i have the time to do so.

[ChillCore]

That's what i am going to test when i have the time to do so.

Whenever you have the time and feel like it is fine.

Also I found where your problem is coming from, try disabling the "Use timetable to ensure vehicle separation" setting in advanced settings ...

[hthhs]

Instead of displaying the arival time and the departure time underneath eachother it would perhaps be nice to display them on the same line ... @see shematic below:

Code: Select all

Currrently:
12.35 v .... other information
12.39 ^ .... same other information

proposal:
12.35 v 12.39 ^ ... other information

Done - check the departure boards thread.

I decided to sort by departure time because it's displaying it as a departure, with the list of stations to be called at after the current one.

[ChillCore]

Nice, checking ...

Thank you.

[Cadde]

That's what i am going to test when i have the time to do so.

Whenever you have the time and feel like it is fine.

Also I found where your problem is coming from, try disabling the "Use timetable to ensure vehicle separation" setting in advanced settings ...

That makes perfect sense, i will try that later. Here is your "Human library of the day" award:

[ChillCore]

That's what i am going to test when i have the time to do so.

Whenever you have the time and feel like it is fine.
Also I found where your problem is coming from, try disabling the "Use timetable to ensure vehicle separation" setting in advanced settings ...

That makes perfect sense, i will try that later. Here is your "Human library of the day" award:

Yummie ... cookie ... and a real one.

It helps having put in and updated the patches manually.
I am not saying I have read every line of code included in the patchpack but I did glance over a big part of them.

Hmm Human Library ... Could I make a decent living out of that?

[NekoMaster]

Could I perhaps get the patch for r21474? I'd like to be able to play the same game on Ubuntu and Windows 7

[ChillCore]

I do not have that one.

The attached version has the changes that MagicBuzz made to be able to compile the windows binary he posted. -> add "(int)" 2 times to economy.cpp.
For compiling on Ubuntu the changes are not needed but I added them anyway.

I had a quick looksie at the changelog and there should be no conflicts when you apply it to r21472 then bump to r21474 before compiling.
Maybe it can be even applied to r21474 directly but I have not tried that.

[Cadde]

Yeah, it was that "Use timetables to ensure vehicle separation" setting... GAH!
Anyways, it works like a charm!

EDIT: I wish i could enable "Use timetables to ensure vehicle separation" on a per vehicle basis

[ChillCore]

Yeah, it was that "Use timetables to ensure vehicle separation" setting... GAH!
Anyways, it works like a charm!

Thank you for comfirming.

EDIT: I wish i could enable "Use timetables to ensure vehicle separation" on a per vehicle basis

That would be cool yes, IIRC this has been mentoined somewhere in the thread before ...

Note that this will not solve the problem with the timetable start dates of a group of vehicles that has the autoseparation enabled though, the only way to adjust the separation is by holding vehicles when they are in stations and releasing them when appropriate.

Before I go digging in that part of the code there are some other things that need attention ... will be some time before I have a looksie on how hard this change would be to make.


Edit:
Spelling

[ostlandr]

Agreed! Thankyouthankyouthankyou!!!!

Here is the Win32 binary.

TYVM!

And for Chill too!

[ReisRyos]

Yesterday he appeared in trunk Feature [FS#730]: diagonal tile clearing and terraforming. Based on patch by fonsinchen.

Would it be possible to update the patch please?

Thanks

[ChillCore]

Agreed! Thankyouthankyouthankyou!!!!

Here is the Win32 binary.

TYVM!

And for Chill too!

Thank you too.

Yesterday he appeared in trunk Feature [FS#730]: diagonal tile clearing and terraforming. Based on patch by fonsinchen.

Would it be possible to update the patch please?

Thanks

Actually I was going to first update the Copypaste patch and also experiment with the savegame code in afterload.cpp but since you asked so nicely I have attached what I have so far.
Not much tested, other than check if my savegame still loaded, as it was late yesterday when I finished updating CargoDist ...



v11_5:
-----
Update:
- Partial refit patch.
- Departure boards wallclock patch to v10. (departure and arrival times can now be on the same line in the gui.)
- CargoDist updated to r21511.

Fixed:
- Windows failed to compile. (MagicBuzz)
- Fixed a bugsie with the refit selection box. (Terkhen)
- Infrastructure sharing, acc_cache -> gcache. (-> infrastructure.cpp)

Fixed maybe:
- Compiler warnings in viewport.cpp ? (oberhümer)

Todo:
- Adjust copy paste patch to TILE_AREA_LOOP and remove (re-introduced) TILE_LOOP. (-> I had too because it was broken more than it was already, both template preview and pasting, and did not feel much at fiddling much more at the time.)


Enjoy and feel free to post savegames.

[ColdIce]

thank you chillcore for all this effort.

build log
http://www.heypasteit.com/clip/QFA

win32

[ChillCore]

thank you chillcore for all this effort.

My pleasure.

Thank you for the binary and the build log, Coldice.


/me goes trying to continue my own game for a bit now ... If only I could keep my fingers out of the code for a minute.

[Dwight_K._Schrute]

Great As always ...

There is one thin in thedaparture board that bothers me a little bit. It would be great to show the group name with the departure/arrival and not the vehicle name or company name. So there will be one nem per line (e.g. "IC 280").With trains it is no big deal as I name them IC 280, IC 281 etc. But it's kind of a problem with city bus lines. There the vehicle name is something like "London line 1 001". It is ok in the departureboard.. but not perfect

If it's possible: great ... if not: still great

P.S. Didn't know if I should have posted it in the original thread since the last changes were posted here...

[ChillCore]

P.S. Didn't know if I should have posted it in the original thread since the last changes were posted here...

It is OK to post this suggestion to the original thread, I think.
First post has been updated with changes also by htths btw.
I was going to post the suggestion for both times on one line there also but hthhs picked it up before I did.

EDIT_1:
Hmm, how are you going to know what vehicle is due to arrive if the vehicle name is not shown?
EDIT_2:
Have a looksie at advanced settings -> interface -> Departure boards ...
Also if you name a group eg. "goods" and the first vehicle in that group "goods" then clone it, vehicles will be called "goods 1", "goods 2" etc. automatically.
Choosing good names for groups may help a lot.
/EDIT

Just when you suspect there to be a bug, and you have not checked with the patch alone, it is better to report here to avoid confusion for the original author.


Two minutes of playing and already found me another little bugsie ...
When you click the automate button in the timetable gui the button is not depressed and the other buttons are not disabled ...
However the patch still seems to be functional even with this flaw.

So much for playing myself, back to the code to figure out what is wrong this time ...