Signals in tunnels and on bridges V3.02 r24031

[HackaLittleBit]

This is very close to definite patch.

I tested it in multiplayer and it worked fine.
It should however be tested much more.
Maybe openttdcoop is the place to do this?

I still have some doubt about reversing and I will not commit this patch until I am 100% sure.

EDIT Please go to first page to download patch http://www.tt-forums.net/viewtopic.php? ... 60&start=0

Regards HackaLittleBit

[ZxBiohazardZx]

alright, looks very good, hope you can get a platform for it soon, id love to see this in stable, very very good patch

[Vitus]

Here's another feedback from the latest version (v19).

Tried to play with train reversing. Found one situation, where the train gets stuck and doesn't want to turn back. It should be in the attachement.

The second problem I've experienced: sometimes, the train doesn't react to free track for a while (in some cases even few seconds). Bigger networks cause longer delays. Try to download for example this savegame. You'll most likely need their GRF pack (can be found here, it's version 7.3).

Now, try to replace part of mainline with signalled bridge and reverse one train on the bridge. The delay should be clearly visible.

I really don't know what could cause this. Maybe bad optimisation or huge CPU load, but I'm just guessing.

Thanks!

Edit: The idea with #openttdcoop is really great. They are now testing infrastructure sharing patch, so I guess they would be able to test this patch as well.

[HackaLittleBit]

The second problem I've experienced: sometimes, the train doesn't react to free track for a while (in some cases even few seconds). Bigger networks cause longer delays

This is build in behavior.

see line 292 in the patch

Code: Select all

v->load_unload_time_rem = 10;

I put this line to ease processor load.
The smaller the value, smaller waiting time but more times checking for distance between trains.
You can easily change this value to suit your needs.

I downloaded the game (2000 trains good for testing) thanks.
I am aware about this reversing problem. It is a very small problem.
Most of the reversing is done correct.
I am reluctant to change code for that issue at this moment.
I rather prefer some serious testing now.

Thanks

[Vitus]

This is build in behavior.

Ah, I see.

I was just wondering, if you could include some kind of switch for this value (either in game options or the cfg file). However, as you don't want to make changes to the code, take this as idea for future versions.

Anyways, thanks for great patch!

[HackaLittleBit]

train gets stuck

Fixed that one.

the train doesn't react to free track for a while (in some cases even few seconds)

Fixed that one.

Code: Select all

v->load_unload_time_rem = 10;

changed into

Code: Select all

v->load_unload_time_rem = 4;

See first page for patch


Regards

[Sensation Lover]

or even worse, like in Norway:

how did you do that i want to know pleeeeease!

[maquinista]

or even worse, like in Norway:

how did you do that i want to know pleeeeease!

There is a example with a tunnel with curve.

But... It was done with two tunnels. Tunnels with turns is not implemented yet. Watch under the save button. There is the exit of the tunnel.

[Sensation Lover]

There is a example with a tunnel with curve.

But... It was done with two tunnels. Tunnels with turns is not implemented yet. Watch under the save button. There is the exit of the tunnel.

you didn t answer my question... it was HOW DID YOU DO THAT?

[Benny]

[quote]It was done with two tunnels.[/quote]

[maquinista]

There is a example with a tunnel with curve.

But... It was done with two tunnels. Tunnels with turns is not implemented yet. Watch under the save button. There is the exit of the tunnel.

you didn t answer my question... it was HOW DID YOU DO THAT?

[Sande]

I think, for a realistic solution, when using the teleporting tunnels, the game should offer the player an amount of tiles the train has to pass inside the tunnel. Minimal amount is calculated by the minimum length.Dunno about the speed. Maybe this can be calculated somehow, too.

I love the signals in tunnels and bridges! I hope it gets implemented.

[Sensation Lover]

Yeah, this patch is realy great! I can construct now metros in the cities, long bridges and tunnels, it's very usefull!!!

[Terkhen]

I think i did something wrong... but I compiled the patch with latest trunk and it doesn't seem to work. I can click on the tunnel's entrance to see the trains inside of the tunnel, but no matter how I fiddle with the settings, I never get more than a single train in the tunnel (or bridge) at once.

[HackaLittleBit]

Fixed it see first post
Now it looks for Front Engine and only shows if front engine is inside tunnel.

Changed:

Code: Select all

 proc ClickTile_TunnelBridge(TileIndex tile)

line			if (v->type != VEH_TRAIN || !HasBit(v->subtype, 0)) continue;
into 			if (v->type != VEH_TRAIN || !IsFrontEngine(v)) continue;

Thanks Terkhen

[Terkhen]

Wow, that was fast. Thank you for your great work!

EDIT: I got the same problem again. I can see the train in the tunnel clicking on its entrance, but only one train enters into it... There's something else besides "Simulate signals in tunnels and bridges every N tiles" that I need to activate?

[HackaLittleBit]

but only one train enters into it...

Did you read this? Is it possible you did not activate the feature?

I checked it but everything working allright.
You have to be more specific please or send me save game by PM.

Regards

[Terkhen]

I was missing this:

Making it a tunnel / bridge with signals just build a signal on the entrance.

I suppose that was added since I tried the patch the last time. Thanks, it is working now!

[HackaLittleBit]

Well I managed to plant a signal on the entrance of tunnel or bridge.
Placing it works the same as on normal rail.
The function of it is to indicate that a bridge/tunnel has signal simulation.
You can toggle the signals in order to make a one-way or a two-way tunnel/bridge.
I did not have much time to test it and I expect still some minor buggs.

Seefirst page for patch

Regards HackaLittleBit

[HackaLittleBit]

Ok some minor bug fixes.
Fixed transparecy problem on bridges with signal
Signal on bridge flips when train passes.
Code clean up.

Patch

Regards