Re: yet another...err...my patch pack (r12930)
Posted: 30 Apr 2008 20:52
Might be a compiler issue. Try buildottd which uses mingw if i remember right.
Transport Tycoon Forums
The place to talk about Transport Tycoon
https://www.tt-forums.net/
roest's patch pack v9 (r13019)
Page 4 of 8
Re: yet another...err...my patch pack (r12930)
Posted: 30 Apr 2008 21:15
i'll try but that's not good for me, since i modify the code a lot and compile-recompile-debug it in MSVS
Re: yet another...err...my patch pack (r12930)
Posted: 30 Apr 2008 21:53
Dear lord... This is just too much. OTTD has entered another level for me now. Combining all these great features and great trainsets together, it's just too friggin' much! 
Re: yet another...err...my patch pack (r12930)
Posted: 01 May 2008 06:15
An update, good, now the engine pool is in. 
Re: yet another...err...my patch pack (r12930)
Posted: 01 May 2008 11:12
Got inside of it. Memory problem. I have no idea how in hell it works for you.....
stack (std::list) is defined.
One element is added to it.
Then we get inside of the loop. iterator is created pointing to the beginning of the list (on that only element in it).
Then we create a const reference to the value of iterator, thus m is a variable which is a copy of variable (*it). m is a reference to *it, which means m is not a copy of that value, it simply is another variable associated with the same thing in memory.
And then. We erase that thing in memory by calling stack.erase(it). m now points to garbage. Which is referenced in the next if statement and even more further.
Code: Select all
std::list<RouteDisplayInfo> stack;
stack.push_back(RouteDisplayInfo(src, INVALID_ORDER, 0, 0, 0, 0));
const int max_trial = 1024;
for (int trial_count = max_trial; trial_count >= 0 && ! stack.empty(); trial_count--) {
const std::list<RouteDisplayInfo>::iterator it = stack.begin();
const RouteDisplayInfo &m = *it;
stack.erase(it);
if (m.station_id == INVALID_STATION) { // destination
One element is added to it.
Then we get inside of the loop. iterator is created pointing to the beginning of the list (on that only element in it).
Then we create a const reference to the value of iterator, thus m is a variable which is a copy of variable (*it). m is a reference to *it, which means m is not a copy of that value, it simply is another variable associated with the same thing in memory.
And then. We erase that thing in memory by calling stack.erase(it). m now points to garbage. Which is referenced in the next if statement and even more further.
Re: yet another...err...my patch pack (r12930)
Posted: 01 May 2008 11:23
I never looked deep into it. I'm on the verge of starting my own paxdest project. This patch is too big and too old to ever get it fixed for multiplayer stability.
Re: yet another...err...my patch pack (r12930)
Posted: 01 May 2008 13:24
well, anyway, if you're going to write anything like that - you'd better prepare for this kind of stuff 
Re: yet another...err...my patch pack (r12930)
Posted: 01 May 2008 13:42
yep... the whole code is kinda buggy. don't want to play with these destinations anymore
Re: yet another...err...my patch pack (r12930)
Posted: 02 May 2008 01:39
Erm, anyone could help out? Daylength + r12930 and above. No need PaxDest if it's too much of a hassle. Daylength is very important. Haha! Starting a new game.
Edit: Oops! What I meant was Roest's Patchpack + Daylength +/- PaxDest.
@Philosophus: Really? I downloaded the one on page 3, it didn't have daylength although it did have PaxDest. Maybe you're referring to the one on page 1. Will give it a go. My bad. Haha!
Edit again: Erm, nope. The one on Page 1 doesn't have daylength either.
Edit: Oops! What I meant was Roest's Patchpack + Daylength +/- PaxDest.
@Philosophus: Really? I downloaded the one on page 3, it didn't have daylength although it did have PaxDest. Maybe you're referring to the one on page 1. Will give it a go. My bad. Haha!
Edit again: Erm, nope. The one on Page 1 doesn't have daylength either.
Re: yet another...err...my patch pack (r12930)
Posted: 02 May 2008 02:11
The last version of this patchpack is for r12930 and includes daylength, so, sorry, I obviously fail to see your problem.Two5Kid wrote:Erm, anyone could help out? Daylength + r12930 and above. No need PaxDest if it's too much of a hassle. Daylength is very important. Haha! Starting a new game.
Edit: Oops! What I meant was Roest's Patchpack + Daylength +/- PaxDest.
Re: yet another...err...my patch pack (r12930)
Posted: 02 May 2008 18:02
Sorry Philosophus, but the Windows binarys do not include the Daylength Patch 
Re: yet another...err...my patch pack (r12930)
Posted: 02 May 2008 18:26
Can you include this? http://www.tt-forums.net/viewtopic.php?f=33&t=36648
Re: yet another...err...my patch pack (r12930)
Posted: 02 May 2008 18:34
I'm starting to believe you aren't the brightest here. In that thread i mentioned the patch isn't working since he missed something and here you ask me if i can include it.Draakon wrote:Can you include this? http://www.tt-forums.net/viewtopic.php?f=33&t=36648
Re: yet another...err...my patch pack (r12930)
Posted: 02 May 2008 19:10
You weren't giving a good information on what was missing.Roest wrote:I'm starting to believe you aren't the brightest here. In that thread i mentioned the patch isn't working since he missed something and here you ask me if i can include it.Draakon wrote:Can you include this? http://www.tt-forums.net/viewtopic.php?f=33&t=36648
Re: yet another...err...my patch pack (r12930)
Posted: 05 May 2008 07:24
the patch has already been fixed.
Re: yet another...err...my patch pack (r12951)
Posted: 05 May 2008 08:23
updated to r12951
added: Nycom's routing restrictions patch
added: Nycom's routing restrictions patch
Re: yet another...err...my patch pack (r12951)
Posted: 05 May 2008 12:26
After the update, most of the scenarios i was able to load can't be loaded now because of the broken savegame error. Any plans on fixing it?
Re: yet another...err...my patch pack (r12951)
Posted: 05 May 2008 12:45
nice, i just found out this forum has an ignore option
Re: yet another...err...my patch pack (r12951)
Posted: 05 May 2008 16:06
very nice pack 
can you add:
Track Sharing
Limit Road Vehicle Speed
There is a patch but i didnt know the name, it let you make subcompanys.
That would be great
can you add:
Track Sharing
Limit Road Vehicle Speed
There is a patch but i didnt know the name, it let you make subcompanys.
That would be great
Re: yet another...err...my patch pack (r12951)
Posted: 05 May 2008 17:45
i really like this pack. could you please add Advanced Terraform - Drag&Draw or 45° rotated rectangle clearing / leveling patch.
i also have the problem that i cannot load most of the scenarios since the last update.
i also have the problem that i cannot load most of the scenarios since the last update.