Aquaduct GRF for nightly r1498.

JGR · Post by **JGR** » 24 Apr 2007 20:37

After some fiddling and the Windows Magnifier I've cornered the first bug, I will investigate and report back some time later.

JGR

SuperTycoon · Post by **SuperTycoon** » 24 Apr 2007 20:43

The aqaduct seems to lack enough depth for a boat to go through it? Maybe make the bridge a little thicker and then prohibit single tile height aqueducts being built? Is that even possible?

Caelan · Post by **Caelan** » 26 Apr 2007 10:48

If its possible, it sounds like a good solution, i already build most of my bridges at two tiles higher anyway for realism

Carlo Ghega · Post by **Carlo Ghega** » 27 Apr 2007 17:25

Anyway: Thanks a lot for that very nice featurure!

Best regards

CG

JGR · Post by **JGR** » 29 Apr 2007 16:52

The first bug is now fixed, see next nightly.
Issue was mostly due to my badly written code which overwrote the value to be tested just before testing it

I will now bash my head against the screen to determine the cause of the second bug...

JGR

michael blunck · Post by **michael blunck** » 30 Apr 2007 19:30

16:49 Changeset [1536] by JGR
trunk/patches/hbridges.asm: Fix bug with sprite sorting/clipping of vehicles under aqueducts due to …

In r1536 there´s a problem with showing middle parts of canal bridges (aka aqueducts) correctly, see attachment. I´m using your .grf here (only slightly modified), which does indeed work under r1518.

I´m using the DOS version, BTW.

regards
Michael

JGR · Post by **JGR** » 01 May 2007 14:31

Michael:
It may take me a while to work out why the DOS version isn't working...

The second previosu bug, with vehicles below and above aqueducts should now be fixed in the latest nightly.

JGR

eis_os · Post by **eis_os** » 01 May 2007 15:46

hmm, have you checked via idb if the windows & dos version fragments will need the same size?

JGR · Post by **JGR** » 02 May 2007 05:38

Yes, they are the same size, and the fragment in question already existed for higher bridges. It was more sensible to integrate the code into higher bridges.
I will have a thorough look at this sometime later...
I am off to school soon...

JGR

wallyweb · Post by **wallyweb** » 21 May 2007 01:44

I thought it might be prudent to post this here as well as in the River waterside (riverbanks) thread:

wallyweb wrote:The rivers are built by clicking on the canal icon while holding the Ctrl (control) key.
The aqueducts are built by clicking on the canal icon while holding the Ctrl (control) key.
If you are building rivers, you must press the Ctrl key continuously.
If you are building aqueducts, you must release the Ctrl key.

ISA · Post by **ISA** » 21 May 2007 07:45

Little question.
Maybe someone know why Windows version viaduct seems same as Michel's one above picture?

wallyweb · Post by **wallyweb** » 15 Jun 2007 23:48

I just noticed this with the ttdpbase[w].grf that Lakie just released that now includes the aqueduct grf.
The problem might go back to the standalone jaquaduct.grf but I now have no way to test it without the old ttdpbase[w].grf.
With higher bridge where the land (not water) underneath is at sea level, the abutments display a bit of the beach and the waves breaking on it.

You might want to check with Oskar to see if his changes to the canal code might have something to do with this.

Website · Post by **Lakie** » 16 Jun 2007 00:46

The nfo code is the same in both grfs, so it must be an internal issue.

~ Lakie

wallyweb · Post by **wallyweb** » 16 Jun 2007 01:28

Lakie wrote:The nfo code is the same in both grfs, so it must be an internal issue.

~ Lakie

I agree.
I just found the prior ttdpbase[w].grf without the aquaduct so I tested with jaquaduct.grf as a stand alone file. I also went to nightly r1568 that does not include Oskar's changes. The issue is still there.
Your turn JGR

eis_os · Post by **eis_os** » 16 Jun 2007 07:27

Well the code for trying to guess if a coastline gets drawn was never that good, as you see on my code comments in selectgroundforbridge...maybe it's now totally broken..

m3henry · Post by **m3henry** » 16 Jun 2007 07:47

that sometime happens for me on other bridges. although it seems to happen only when the height of the bridge is 8 or if the bridge crosses land of 0 height

wallyweb · Post by **wallyweb** » 16 Jun 2007 08:56

m3henry wrote:that sometime happens for me on other bridges. although it seems to happen only when the height of the bridge is 8 or if the bridge crosses land of 0 height

That's where these occur.

m3henry · Post by **m3henry** » 17 Jun 2007 10:29

oops, didnt read the whole post properly

wallyweb · Post by **wallyweb** » 17 Jun 2007 10:35

m3henry wrote:oops, didnt read the whole post properly

That's ok ... I didn't notice that the problem also exists for road and rail bridges too.

Transport Tycoon Forums

Aquaduct GRF for nightly r1498.

Who is online