Transport Tycoon Forums

kuifware wrote: BuildRoad and BuildRoadFull require that start != end, so you can't build individual road segments on one tile (without also building on neighbouring tiles as well).

kuifware wrote:

• When you want to connect a road depot or station, you need to build a road segment which will be replaced by the depot/station. A slight waste of money.

kuifware wrote:

• More interesting is the possibility to use BuildRoadSegments in AITestMode. It makes it much easier to estimate the costs of a road path. (Using BuildRoad in AITestMode won't allow you to do that because then you'd typically double-count the cost of clearing the tiles and the costs of building foundations. Workarounds for this are less efficient and prone to bugs.)

kuifware wrote: If you want to know how much funds your competitor can raise, you need to know its BankBalance and MaxLoanAmount - its LoanAmount.

GeekToo wrote:

kuifware wrote: If you want to know how much funds your competitor can raise, you need to know its BankBalance and MaxLoanAmount - its LoanAmount.

But, unless you want to buy out, like mentioned above, why would you want to know that? I.e. in what way would that influence the behaviour of your AI? Imo, most AIs that are currently built are still struggling with vehicle management, path finding etc. Buying out other companies is at another strategic level, that, at least my AI is not ready for yet. I'm not saying it's an invalid request, I just would like to understand the thought behind it.

Finaldeath wrote:I think it's useful to have those numbers Truelight...at least for beginners.

You have, after all, "hardcoded" it into the default WrightAI. For beginners, it's a big "need to know" bit of info which is hidden in some source header file. With no knowledge of it, and without looking rather deeply at how on earth it is meant to work, it looks impossible from the outset to know what types of cargo can be used - eg, for simple bus routes.

Who knows how you'd determine how to even start a bus route without the knowledge that 0 was passengers when searching for a good station location.

If the API documentation was improved, both to include some information on what on earth a "cargoID" represents (an integer right? oh, wait, no, an indexed-0 integer... ), it'd be much more clear. Same goes with some others I was tempted to add info on The WrightAI would also have to be changed to include explicit notes that it will break, like you said, when the GRF files change.

(...)

GetCargoLabel ( CargoID cargo_type ) [static]

Note:
Never use this to check if it is a certain cargo. NewGRF can redefine all of the names.

for (local i = list.Begin(); list.HasNext(); i = list.Next()) {
			if (AICargo.GetCargoLabel(i) == "PASS") {
				this.passenger_cargo_id = i;
			}
		}

GeekToo wrote: (..)

So far the nagging. I'd also like to compliment you with the development of this branch. Last night I put up a battle between WrightAI and my bus loving AI (working name Convoy ), on a flat scenario ( wright couldn't find a spot for anairport in the test scenario ).
I expected it to be boring, to just watch 2 AIs battling, but it was a very exciting fight, with no definitive winner after 5 years. I had a lot of fun watching the fight, and it gave me inspiration for A LOT of things I still have to improve.

Thanks for making this experience possible !

GeekToo wrote:TrueLight,

Considering this ( imo correct ) note on the api-doc

GetCargoLabel ( CargoID cargo_type ) [static]

Note:
Never use this to check if it is a certain cargo. NewGRF can redefine all of the names.

I think your solution in WrightAI:

Code: Select all

for (local i = list.Begin(); list.HasNext(); i = list.Next()) {
			if (AICargo.GetCargoLabel(i) == "PASS") {
				this.passenger_cargo_id = i;
			}
		}

is not less of a bug than comparing against the 0 value. I tried to solve this (that is, finding passenger cargo id ) by checking with the IsFreight function.But that does also return false on mail cargo( and mail trucks cannot go to busstations). So maybe the IsFreight function can return true for mail, then there is a real solution.

TrueLight wrote: Oh, and IsFreight means that the cargo goes to or from an industry, nothing else. So Mail can never be a Freight... sad sad world (how else would you find out what you have to move from town to town ).

RoadStopType type = IsCargoInClass(v->cargo_type, CC_PASSENGERS) ? ROADSTOP_BUS : ROADSTOP_TRUCK;

• AICargo.GetCargoClasses(cargoID) + adding an enumeration for the CC_* constants (from newgrf_cargo.h). AFAIK this is NewGRF-safe and is the way OpenTTD deals with trucks/busses internally.
• AICargo.GetRoadStopType(cargoID)

kuifware wrote: On the other hand, in roadveh_cmd.cpp I see some occurrences of

Code: Select all

RoadStopType type = IsCargoInClass(v->cargo_type, CC_PASSENGERS) ? ROADSTOP_BUS : ROADSTOP_TRUCK;

Some suggestions for the API:

• AICargo.GetCargoClasses(cargoID) + adding an enumeration for the CC_* constants (from newgrf_cargo.h). AFAIK this is NewGRF-safe and is the way OpenTTD deals with trucks/busses internally.
• AICargo.GetRoadStopType(cargoID)

TrueLight wrote:Brilliant! I just added code for that in the API. Now lets all use AICargo.HasCargoClass() to find what ever type of cargo you are looking for Tnx a bunch kuifware, glad someone knows NewGRFs better than I do Hehe!

TrueLight wrote:[
Now show us your AI and let us enjoy the moment too

GeekToo wrote: Licence:
Don't know much about that, GNU GPL is fine I think. Meaning: feel free to use or modify any of my code ( a link would be nice ), or better, improve and republish it. I think it is be possible to create a nice AI by the OTTD community, using the best open source practices.
I thank TrueLight and Zuu: I re-used some functions of Wright and Clueless ( if that's a problem, I'll rewrite them, and yeah, I know, I should have asked beforehand )

kuifware wrote:That puts up a general question about licenses: doesn't the fact that OpenTTD is licensed under the GPL imply that our AIs must be released under the GPL?

Rubidium wrote: Technically all AIs made using the NoAI framework are GPL [1]. You are however not required to release your AI [2]. When you disclose your AI to someone else that person is allowed to redistribute it, but the person is also allowed to not redistribute [3].
But I am not a lawyer, so when you need absolute certainty you need to talk to a real lawyer.