PAXLink - a PAX-only AI that uses feeder systems

[Zuu]

When I use just the Generic Cars GRF in a game it replaces the original buses. So that there is no normal buses for PAXLink to chose from. Even when I just tried to enable multiple side-by-side GRF sets in advanced settings the normal buses are gone.

If I add LongVehicles 4 for example, PAXLink picks the LV4 vehicles as they happen to get higher score in the vehicle selection.

[cmoiromain]

I enabled both generic cars and egrvts. Other AIs chose the buses from egrvts, PAXLink didn't...

[Alberth]

PAXlink 12 crashed in my game with the following message:

Code: Select all

dbg: [ai] [3] [S] Your script made an error: idx out of range
dbg: [ai] [3] [S]
dbg: [ai] [3] [S] *FUNCTION [RemoveInvalidStations()] /home/hat/.openttd/content_download/ai/PAXLink.12.tar/paxlink.12/townmanager.nut line [335]
dbg: [ai] [3] [S] *FUNCTION [ReadStatisticsData()] /home/hat/.openttd/content_download/ai/PAXLink.12.tar/paxlink.12/townmanager.nut line [342]
dbg: [ai] [3] [S] *FUNCTION [UpdateTownStatistics()] /home/hat/.openttd/content_download/ai/PAXLink.12.tar/paxlink.12/townmanager.nut line [49]
dbg: [ai] [3] [S] *FUNCTION [Start()] /home/hat/.openttd/content_download/ai/PAXLink.12.tar/paxlink.12/main.nut line [309]
dbg: [ai] [3] [S]
dbg: [ai] [3] [S] [@ITERATOR@] 3
dbg: [ai] [3] [S] [remove] 3
dbg: [ai] [3] [S] [_] 2
dbg: [ai] [3] [S] [remove_list] ARRAY
dbg: [ai] [3] [S] [this] INSTANCE
dbg: [ai] [3] [S] [this] INSTANCE
dbg: [ai] [3] [S] [@ITERATOR@] 40
dbg: [ai] [3] [S] [town_manager] INSTANCE
dbg: [ai] [3] [S] [_] 39
dbg: [ai] [3] [S] [this] INSTANCE
dbg: [ai] [3] [S] [this] INSTANCE
dbg: [ai] The AI died unexpectedly.

Screenshot of the debug window: http://devs.openttd.org/~alberth/paxlink12_crash.png
Don't take too much attention of the red text at the bottom, it looks like a repetition of the text at the top.

Save game loads at my clean r16077 trunk

[rsdworker]

i had paxlink on my map - the al didn't expand - just stuck to one station in one town

here a screenshot of it and saved the game - its shows the AL is not growing
see the al debug that reports he had stopped building = possibly crashed but no red texts

[rsdworker]

bump - anyone can solve this?

[Zutty]

The save game loads with MedievalAI for me, and it crashes almost immediately.

It could be something to do with ECS vectors. Specifically I think its related to tourists. Have you tried either...

A) Disabling the town vector
B) Using a houses set that is compatible with ECS (TTRS for instance)

I dont know about Medieval/PAXLink, but my own AI didn't like it when tourists existed as a cargo, but were not actually generated by any town.

[rsdworker]

The save game loads with MedievalAI for me, and it crashes almost immediately.

It could be something to do with ECS vectors. Specifically I think its related to tourists. Have you tried either...

A) Disabling the town vector
B) Using a houses set that is compatible with ECS (TTRS for instance)

I dont know about Medieval/PAXLink, but my own AI didn't like it when tourists existed as a cargo, but were not actually generated by any town.

so where is TTRS? could you point out for me

[Zutty]

Sorry I thought it would have been on bananas by now...

http://users.skynet.be/florisjan/ttd/ttrs.html

[Wold]

Shouldn't the AI check if the 2 cities are too close?

[Zuu]

Regarding tourists the AI has one function GetPAXCargo in helper.nut that using the available cargo class checking methods try to figure out what ID passengers has. If you want to use town vectors you are free to propose changes to that function to make it compatible with original OpenTTD as well as town vectors.

Shouldn't the AI check if the 2 cities are too close?

In the current version of PAXLink the decision to build bus stops in a town and to build an airport in that town are two somewhat independent choices. A third somewhat independent choice is to add a new air-line. In this choice if it has more than two airports to choose from, it try to pick a pair with longer distance. But if it only has two airports to choose from (most common) situations as the one you posted can happen.

Yes this is not always good, but that is what can happen with independent decisions. There are plans for expanding the town "model" to make better decisions, but I am afraid currently I don't even have time to regularly visit the forums.

[Wold]

Well the AI had a choice of 4 airports and it chose that 2, that's why I reported it.

And something for a little tweaking:

[mwyeoh]

Just posting an AI crash

Basic game
no newgrfs
single player only

screen.png

(143.27 KiB) Downloaded 62 times

[Zuu]

Just posting an AI crash

Basic game
no newgrfs
single player only

screen.png

Thanks

Hmm, that one, though I disabled it but maybe not. Was many weeks ago I sat with the code last. I've kept myself busy with traffic models at university the last weeks.

[mwyeoh]

I have observed an 'oversight' with PAX

Since the generic tram set is now part of the game, when building buses, the AI does not check whether the 'road' it is connecting to is roads or tram lines

version 0.7.0

Cundwood Transport, 6th May 2000.png

(379.18 KiB) Downloaded 80 times

[Zuu]

Thank you for your report, that is indeed something I didn't consider.

[Zuu]

I just want to tell that I've looked into PAXLink and tried to change the code so that it does no longer use call-functions nor calling DoCommands from other places where it is now forbidden.

After having spent an hour or two on that I got that part to work, but found out that the townmanager crashed for some reason which I didn't have time to debug extensively enough at that time. So I have disabled PAXLink on Bananas for now. Because it doesn't make sense to use it in the current state when it does nothing at all but spaming the log window with error messages in the latest nightlies. Not sure when I'll be able to get it back running again.

[Carnildo]

Got a situation for you where the AI has trouble: in one of my games, the AI built a town's intercity airport next to an industry that accepted passengers (a steel mill, IIRC) rather than near the town itself. All well and good, except that the industry went out of business and there are now two airports and four airplanes doing nothing but accumulate cargo.

[Zuu]

Thanks for taking your self time to report the problem. I can not say anything when it will get fixed as the problems mentioned in my previous post have to be solved first, so that PAXLink get back workning on last nightly. Then to solve your problem it will need to know how to close down an airport and do so when it loses acceptance for passengers.

[Zuu]

I'm happy to tell you that PAXLink is now again working with recent nightlies. [Edit: On 0.7.1 it seams to act strange. ] [Edit2: I couldn't reproduce the strange behavior when I had restarted OpenTTD with "-d ai=5". The strange behavior that I first noticed was that it removed grid bus-stops and many buses ended up with all orders invalid. ]

Changes:

• Don't use call/pcall for valuator replacement, instead use Yexos code from AdmiralAI that do not use call/pcall.
• Fixed the by mwyeoh reported bug related to tram tracks. PAXLink will no longer build grid stations next to tram tracks with no road. (and if the road is removed but the tram is still there PAXLink removes the road station)
• Fixed the by Carnildo reported problem of when an inter city station (airport) stops accepting passengers. First, airplanes stop servicing it, then the buses and lastly the inter city station is removed. If it is so fast that there is still a bus on one of the bus stops it delays a bit, but not forever so in some rare cases a bus stop might be left over from the inter city station. And currently PAXLink does not remove non-grid bus stops that are not part of an IC station.
• I hope I have fixed the bug mentioned by Alberth and mwyeoh above. I could not reproduce it, but I realized by reading my code what could go wrong and have rewritten it so it should be safe now. The code removed zero, one or more items from an squirrel array. I made a list of all indexes to remove and then looped over the to_remove array and removed the items from the array of stations in a town. The problem is that when one station is removed, indexes with an higher number gets wrong. As opposed to when using pointers/iterators in C++ where the pointer will still point on the correct item even if some other elements have been removed.

[fanioz]

well done zuu. It seems like morloth has been waiting for you to fix Pax-Link, to join on his small tournament.