Transport Tycoon Forums

Code: Select all

Iterator i = container.iterator();
while(i.hasNext()) {
    Object o = i.next();
    //do something with o
}

Code: Select all

for(Containerclass::iterator i = container.begin(); i != container.end(); ++i) {
    object o = *i;
    // do something with o
}

Code: Select all

for (Container::iterator i = c.begin(); i != c.end; ++i) {
    // do things with i
    if (condition) {
        c.erase(i++);
    } 
}

Code: Select all

/Users/ingo/ottd/clientpatches/src/yapf/../map_func.h:358: warning: 'class OrthIterator' has virtual functions but non-virtual destructor
/Users/ingo/ottd/clientpatches/src/yapf/../map_func.h:428: warning: 'class DiagIterator' has virtual functions but non-virtual destructor
/Users/ingo/ottd/clientpatches/src/yapf/../map_func.h:341: warning: 'class TileIterator' has virtual functions but non-virtual destructor

Code: Select all

 - if(TileX(current) > x_max) {
 + if ((TileX(current) > x_max) || (TileX(current) == 0)) {
		current += TileDiffXY(0, 1) - (w);
			if (TileY(current) > y_max) {
				current = INVALID_TILE;
			}
		}

Code: Select all

/src/station_cmd.cpp:519: void GetAcceptanceAroundTiles(uint*, TileIndex, int, int, int): Assertion `w > 0' failed.

Code: Select all

static inline bool DraggingDiagonal()
{
	return _ctrl_pressed && _thd.select_method == VPM_X_AND_Y &&
			_cursor.sprite != SPR_CURSOR_DOCK && //Hack
			(_thd.select_proc == DDSP_DEMOLISH_AREA || _thd.select_proc == DDSP_LEVEL_AREA ||
			_thd.select_proc == DDSP_RAISE_AND_LEVEL_AREA || _thd.select_proc == DDSP_LOWER_AND_LEVEL_AREA);
}

Code: Select all

//In the case causing the assert, either x2 == x1, y2 == y1 or both.
_thd.new_size.x = x2 - x1;
_thd.new_size.y = y2 - y1;
if (!_thd.new_diagonal) {
	//These lines would make size greater than zero, 
	//but they don't get executed because DraggingDiagonal returned true.
	_thd.new_size.x += TILE_SIZE;
	_thd.new_size.y += TILE_SIZE;
}
//As a result, _thd.size.(x | y) is zero. This will cause the described assert later.