Transport Tycoon Forums

The place to talk about Transport Tycoon
https://www.tt-forums.net/

JGR's Patch Pack

https://www.tt-forums.net/viewtopic.php?t=73469

Page 140 of 243

Re: JGR's Patch Pack

Posted: 08 May 2020 17:02
by BW89
I can not give you a finished program, but if you tell me what distribution you are using i can write you some commands you just have to paste into the terminal and execute.

Re: JGR's Patch Pack

Posted: 08 May 2020 18:00
by BeSt-Com
oh,that's a good idea, thx

Linux Version 4.19.97-v7+ (dom@buildbotjcc version 4.9.3 (3 (crosstool-NG crosstool-ng-1.22.0-88-g8460611)) #1294 SMP

Re: JGR's Patch Pack

Posted: 08 May 2020 19:02
by BW89

Code: Select all

sudo apt build-dep openttd
sudo apt install git
git clone https://github.com/JGRennison/OpenTTD-patches
cd OpenTTD-patches
./configure
sudo make install

that should be it

Re: JGR's Patch Pack

Posted: 08 May 2020 19:36
by BeSt-Com
I will try, thx a lot!

Re: JGR's Patch Pack

Posted: 08 May 2020 19:56
by kamnet
Digging back a few years, any thoughts about implementing Organized Ship Docking and Buoys as Docks from Cirdan's and HackALittleBit's patches?

viewtopic.php?p=1206331#p1206331

I would particularly be interested in seeing buoys as docks, they would be extremely useful on OpenTTD rivers and lakes without needing to build out ugly and ill-fitting sea docks. One could instead build a buoy and then an eyecandy dock next to it, flush to the shore and ship.

Re: JGR's Patch Pack

Posted: 09 May 2020 03:27
by wallyweb
kamnet wrote: 08 May 2020 19:56 Digging back a few years, any thoughts about implementing Organized Ship Docking and Buoys as Docks from Cirdan's and HackALittleBit's patches?

viewtopic.php?p=1206331#p1206331

I would particularly be interested in seeing buoys as docks, they would be extremely useful on OpenTTD rivers and lakes without needing to build out ugly and ill-fitting sea docks. One could instead build a buoy and then an eyecandy dock next to it, flush to the shore and ship.
They are also particularly good for off-shore oil tanker loading/unloading and for fishing grounds (saves very expensive raising of ground at sea). I used these often in TTDPatch although cirdan's implementation is more elegant (build a dock on water as opposed to Ctrl-click on the buoy icon).

Re: JGR's Patch Pack

Posted: 13 May 2020 09:31
by MagicBuzz
Hello,

I'm trying to compile the lastest source (763a2826b60e0bcafa2ec3e65c6cf4560f5f6cf4 the 11/05/2020) with Visual Studio 2019 16.5.4 and I'm getting many errors (some are just amazing, like the "'string': is not a member of 'std'")

Code: Select all

1>------ Build started: Project: strgen, Configuration: Debug Win32 ------
2>------ Build started: Project: settingsgen, Configuration: Debug Win32 ------
3>------ Build started: Project: version, Configuration: Debug Win32 ------
4>------ Build started: Project: basesets, Configuration: Debug Win32 ------
5>------ Skipped Build: Project: generate, Configuration: Debug Win32 ------
5>Project not selected to build for this solution configuration 
4>Generating no_music.obm baseset metadata file
3>Microsoft (R) Windows Script Host Version 5.812
3>Copyright (C) Microsoft Corporation. Tous droits r�serv�s.
3>
2>alloc_func.cpp
1>alloc_func.cpp
1>strgen_base.cpp
1>strgen.cpp
1>string.cpp
1>getoptdata.cpp
2>getoptdata.cpp
2>ini_load.cpp
2>F:\Projets\OpenTTD JGR\src\ini_type.h(65,68): error C2039: 'string': is not a member of 'std'
2>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\memory(24): message : see declaration of 'std'
2>F:\Projets\OpenTTD JGR\src\ini_type.h(65,75): error C2061: syntax error: identifier 'string'
2>F:\Projets\OpenTTD JGR\src\ini_load.cpp(211,1): error C2511: 'void IniLoadFile::LoadFromDisk(const char *,Subdirectory,std::string *)': overloaded member function not found in 'IniLoadFile'
2>F:\Projets\OpenTTD JGR\src\ini_type.h(52): message : see declaration of 'IniLoadFile'
2>F:\Projets\OpenTTD JGR\src\ini_load.cpp(212,2): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
2>F:\Projets\OpenTTD JGR\src\ini_load.cpp(222,13): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
2>F:\Projets\OpenTTD JGR\src\ini_load.cpp(264,5): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
2>F:\Projets\OpenTTD JGR\src\ini_load.cpp(269,25): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
2>F:\Projets\OpenTTD JGR\src\ini_load.cpp(269,40): error C2664: 'IniGroup::IniGroup(const IniGroup &)': cannot convert argument 1 from 'char *' to 'IniLoadFile *'
2>F:\Projets\OpenTTD JGR\src\ini_load.cpp(269,31): message : Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
2>F:\Projets\OpenTTD JGR\src\ini_load.cpp(59,11): message : see declaration of 'IniGroup::IniGroup'
2>F:\Projets\OpenTTD JGR\src\ini_load.cpp(317,4): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
2>F:\Projets\OpenTTD JGR\src\ini_load.cpp(322,3): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
2>settingsgen.cpp
2>string.cpp
2>Generating Code...
2>Done building project "settingsgen_vs142.vcxproj" -- FAILED.
6>------ Build started: Project: settings, Configuration: Debug Win32 ------
6>'..\objs\settings\settings_gen.exe' n'est pas reconnu en tant que commande interne
6>ou externe, un programme ex�cutable ou un fichier de commandes.
6>F:\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.MakeFile.Targets(44,5): error MSB3073: The command "
6>F:\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.MakeFile.Targets(44,5): error MSB3073: ..\objs\settings\settings_gen.exe -o ..\objs\settings\table\settings.h -b ..\src\table\settings.h.preamble -a ..\src\table\settings.h.postamble ..\src\table\company_settings.ini ..\src\table\currency_settings.ini ..\src\table\gameopt_settings.ini ..\src\table\misc_settings.ini ..\src\table\settings.ini ..\src\table\win32_settings.ini ..\src\table\window_settings.ini
6>F:\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.MakeFile.Targets(44,5): error MSB3073:     " exited with code 9009.
6>Done building project "settings_vs142.vcxproj" -- FAILED.
4>Generating no_sound.obs baseset metadata file
1>strgen_vs142.vcxproj -> F:\Projets\OpenTTD JGR\projects\..\objs\strgen\strgen.exe
7>------ Build started: Project: langs, Configuration: Debug Win32 ------
7>Generating strings.h
7>Generating english language file
[...]
4>Generating orig_win.obs baseset metadata file
8>------ Build started: Project: openttd, Configuration: Release x64 ------
8>tbtr_template_gui_main.cpp
8>tbtr_template_gui_create.cpp
8>tbtr_template_vehicle.cpp
8>tbtr_template_vehicle_func.cpp
8>airport.cpp
8>animated_tile.cpp
8>articulated_vehicles.cpp
8>F:\Projets\OpenTTD JGR\src\tbtr_template_vehicle_func.cpp(98,45): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
8>F:\Projets\OpenTTD JGR\src\tbtr_template_gui_main.cpp(582,1): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
8>F:\Projets\OpenTTD JGR\src\tbtr_template_gui_main.cpp(590,1): warning C4267: 'argument': conversion from 'size_t' to 'const int', possible loss of data
8>F:\Projets\OpenTTD JGR\src\tbtr_template_gui_main.cpp(644,1): warning C4267: 'argument': conversion from 'size_t' to 'const int', possible loss of data
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\airport.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\airport.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\airport.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(63,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\tbtr_template_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(54): message : while compiling class template member function 'void Pool<TemplateVehicle,TemplateID,512,64000,PT_NORMAL,false,true>::ResizeFor(size_t)' (compiling source file ..\src\tbtr_template_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(175): message : see reference to function template instantiation 'void Pool<TemplateVehicle,TemplateID,512,64000,PT_NORMAL,false,true>::ResizeFor(size_t)' being compiled (compiling source file ..\src\tbtr_template_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(31): message : while compiling class template member function 'Pool<TemplateVehicle,TemplateID,512,64000,PT_NORMAL,false,true>::Pool(const char *)' (compiling source file ..\src\tbtr_template_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\tbtr_template_vehicle.cpp(45): message : see reference to function template instantiation 'Pool<TemplateVehicle,TemplateID,512,64000,PT_NORMAL,false,true>::Pool(const char *)' being compiled
8>F:\Projets\OpenTTD JGR\src\tbtr_template_vehicle.h(71): message : see reference to class template instantiation 'Pool<TemplateVehicle,TemplateID,512,64000,PT_NORMAL,false,true>' being compiled (compiling source file ..\src\tbtr_template_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(64,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\tbtr_template_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(78,1): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\tbtr_template_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(77): message : while compiling class template member function 'size_t Pool<TemplateVehicle,TemplateID,512,64000,PT_NORMAL,false,true>::FindFirstFree(void)' (compiling source file ..\src\tbtr_template_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(146): message : see reference to function template instantiation 'size_t Pool<TemplateVehicle,TemplateID,512,64000,PT_NORMAL,false,true>::FindFirstFree(void)' being compiled (compiling source file ..\src\tbtr_template_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(79,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\tbtr_template_vehicle.cpp)
8>autoreplace.cpp
8>bmp.cpp
8>cargoaction.cpp
8>cargomonitor.cpp
8>cargopacket.cpp
8>cargotype.cpp
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(63,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\autoreplace.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(54): message : while compiling class template member function 'void Pool<EngineRenew,EngineRenewID,16,64000,PT_NORMAL,false,true>::ResizeFor(size_t)' (compiling source file ..\src\autoreplace.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(175): message : see reference to function template instantiation 'void Pool<EngineRenew,EngineRenewID,16,64000,PT_NORMAL,false,true>::ResizeFor(size_t)' being compiled (compiling source file ..\src\autoreplace.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(31): message : while compiling class template member function 'Pool<EngineRenew,EngineRenewID,16,64000,PT_NORMAL,false,true>::Pool(const char *)' (compiling source file ..\src\autoreplace.cpp)
8>F:\Projets\OpenTTD JGR\src\autoreplace.cpp(19): message : see reference to function template instantiation 'Pool<EngineRenew,EngineRenewID,16,64000,PT_NORMAL,false,true>::Pool(const char *)' being compiled
8>F:\Projets\OpenTTD JGR\src\autoreplace_base.h(33): message : see reference to class template instantiation 'Pool<EngineRenew,EngineRenewID,16,64000,PT_NORMAL,false,true>' being compiled (compiling source file ..\src\autoreplace.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(64,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\autoreplace.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(78,1): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\autoreplace.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(77): message : while compiling class template member function 'size_t Pool<EngineRenew,EngineRenewID,16,64000,PT_NORMAL,false,true>::FindFirstFree(void)' (compiling source file ..\src\autoreplace.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(146): message : see reference to function template instantiation 'size_t Pool<EngineRenew,EngineRenewID,16,64000,PT_NORMAL,false,true>::FindFirstFree(void)' being compiled (compiling source file ..\src\autoreplace.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(79,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\autoreplace.cpp)
8>cheat.cpp
8>command.cpp
8>console.cpp
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\cargoaction.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\cargoaction.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\cargoaction.cpp)
8>console_cmds.cpp
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\cargomonitor.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\cargomonitor.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\cargomonitor.cpp)
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(63,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(54): message : while compiling class template member function 'void Pool<CargoPacket,CargoPacketID,1024,16773120,PT_NORMAL,true,false>::ResizeFor(size_t)' (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(175): message : see reference to function template instantiation 'void Pool<CargoPacket,CargoPacketID,1024,16773120,PT_NORMAL,true,false>::ResizeFor(size_t)' being compiled (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(31): message : while compiling class template member function 'Pool<CargoPacket,CargoPacketID,1024,16773120,PT_NORMAL,true,false>::Pool(const char *)' (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\cargopacket.cpp(28): message : see reference to function template instantiation 'Pool<CargoPacket,CargoPacketID,1024,16773120,PT_NORMAL,true,false>::Pool(const char *)' being compiled
8>F:\Projets\OpenTTD JGR\src\cargopacket.h(46): message : see reference to class template instantiation 'Pool<CargoPacket,CargoPacketID,1024,16773120,PT_NORMAL,true,false>' being compiled (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(64,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(78,1): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(77): message : while compiling class template member function 'size_t Pool<CargoPacket,CargoPacketID,1024,16773120,PT_NORMAL,true,false>::FindFirstFree(void)' (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(146): message : see reference to function template instantiation 'size_t Pool<CargoPacket,CargoPacketID,1024,16773120,PT_NORMAL,true,false>::FindFirstFree(void)' being compiled (compiling source file ..\src\cargopacket.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(79,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\cargopacket.cpp)
8>cpu.cpp
8>crashlog.cpp
8>currency.cpp
8>date.cpp
8>F:\Projets\OpenTTD JGR\src\command.cpp(546,84): warning C4267: 'argument': conversion from 'size_t' to 'const T', possible loss of data
8>        with
8>        [
8>            T=uint
8>        ]
8>F:\Projets\OpenTTD JGR\src\command.cpp(555,38): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data
8>debug.cpp
8>dedicated.cpp
8>departures.cpp
8>depot.cpp
8>disaster_vehicle.cpp
8>F:\Projets\OpenTTD JGR\src\console_cmds.cpp(2307,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\console_cmds.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\console_cmds.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\console_cmds.cpp)
8>F:\Projets\OpenTTD JGR\src\debug.cpp(336,90): warning C4267: 'argument': conversion from 'size_t' to 'const T', possible loss of data
8>        with
8>        [
8>            T=uint
8>        ]
8>F:\Projets\OpenTTD JGR\src\debug.cpp(337,104): warning C4267: 'initializing': conversion from 'size_t' to 'unsigned int', possible loss of data
8>driver.cpp
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\date.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\date.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\date.cpp)
8>economy.cpp
8>effectvehicle.cpp
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(63,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\depot.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(54): message : while compiling class template member function 'void Pool<Depot,DepotID,64,64000,PT_NORMAL,false,true>::ResizeFor(size_t)' (compiling source file ..\src\depot.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(175): message : see reference to function template instantiation 'void Pool<Depot,DepotID,64,64000,PT_NORMAL,false,true>::ResizeFor(size_t)' being compiled (compiling source file ..\src\depot.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(31): message : while compiling class template member function 'Pool<Depot,DepotID,64,64000,PT_NORMAL,false,true>::Pool(const char *)' (compiling source file ..\src\depot.cpp)
8>F:\Projets\OpenTTD JGR\src\depot.cpp(23): message : see reference to function template instantiation 'Pool<Depot,DepotID,64,64000,PT_NORMAL,false,true>::Pool(const char *)' being compiled
8>F:\Projets\OpenTTD JGR\src\depot_base.h(19): message : see reference to class template instantiation 'Pool<Depot,DepotID,64,64000,PT_NORMAL,false,true>' being compiled (compiling source file ..\src\depot.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(64,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\depot.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(78,1): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\depot.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(77): message : while compiling class template member function 'size_t Pool<Depot,DepotID,64,64000,PT_NORMAL,false,true>::FindFirstFree(void)' (compiling source file ..\src\depot.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(146): message : see reference to function template instantiation 'size_t Pool<Depot,DepotID,64,64000,PT_NORMAL,false,true>::FindFirstFree(void)' being compiled (compiling source file ..\src\depot.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(79,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\depot.cpp)
8>F:\Projets\OpenTTD JGR\src\departures.cpp(572,47): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data
8>F:\Projets\OpenTTD JGR\src\departures.cpp(573,46): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\departures.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\departures.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\departures.cpp)
8>elrail.cpp
8>engine.cpp
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\disaster_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\disaster_vehicle.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\disaster_vehicle.cpp)
8>fileio.cpp
8>fios.cpp
8>fontcache.cpp
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(63,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(54): message : while compiling class template member function 'void Pool<CargoPayment,CargoPaymentID,512,1044480,PT_NORMAL,false,true>::ResizeFor(size_t)' (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(175): message : see reference to function template instantiation 'void Pool<CargoPayment,CargoPaymentID,512,1044480,PT_NORMAL,false,true>::ResizeFor(size_t)' being compiled (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(31): message : while compiling class template member function 'Pool<CargoPayment,CargoPaymentID,512,1044480,PT_NORMAL,false,true>::Pool(const char *)' (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\economy.cpp(64): message : see reference to function template instantiation 'Pool<CargoPayment,CargoPaymentID,512,1044480,PT_NORMAL,false,true>::Pool(const char *)' being compiled
8>F:\Projets\OpenTTD JGR\src\economy_base.h(24): message : see reference to class template instantiation 'Pool<CargoPayment,CargoPaymentID,512,1044480,PT_NORMAL,false,true>' being compiled (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(64,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(78,1): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(77): message : while compiling class template member function 'size_t Pool<CargoPayment,CargoPaymentID,512,1044480,PT_NORMAL,false,true>::FindFirstFree(void)' (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(146): message : see reference to function template instantiation 'size_t Pool<CargoPayment,CargoPaymentID,512,1044480,PT_NORMAL,false,true>::FindFirstFree(void)' being compiled (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(79,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\economy.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(63,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\engine.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(54): message : while compiling class template member function 'void Pool<Engine,EngineID,64,64000,PT_NORMAL,false,true>::ResizeFor(size_t)' (compiling source file ..\src\engine.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(175): message : see reference to function template instantiation 'void Pool<Engine,EngineID,64,64000,PT_NORMAL,false,true>::ResizeFor(size_t)' being compiled (compiling source file ..\src\engine.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(31): message : while compiling class template member function 'Pool<Engine,EngineID,64,64000,PT_NORMAL,false,true>::Pool(const char *)' (compiling source file ..\src\engine.cpp)
8>F:\Projets\OpenTTD JGR\src\engine.cpp(39): message : see reference to function template instantiation 'Pool<Engine,EngineID,64,64000,PT_NORMAL,false,true>::Pool(const char *)' being compiled
8>F:\Projets\OpenTTD JGR\src\engine_base.h(21): message : see reference to class template instantiation 'Pool<Engine,EngineID,64,64000,PT_NORMAL,false,true>' being compiled (compiling source file ..\src\engine.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(64,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\engine.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(78,1): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\engine.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(77): message : while compiling class template member function 'size_t Pool<Engine,EngineID,64,64000,PT_NORMAL,false,true>::FindFirstFree(void)' (compiling source file ..\src\engine.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(146): message : see reference to function template instantiation 'size_t Pool<Engine,EngineID,64,64000,PT_NORMAL,false,true>::FindFirstFree(void)' being compiled (compiling source file ..\src\engine.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(79,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\engine.cpp)
8>fontdetection.cpp
8>base_consist.cpp
8>gamelog.cpp
8>genworld.cpp
8>gfx.cpp
8>gfxinit.cpp
8>gfx_layout.cpp
8>goal.cpp
8>ground_vehicle.cpp
8>heightmap.cpp
8>highscore.cpp
8>infrastructure.cpp
8>hotkeys.cpp
8>ini.cpp
8>ini_load.cpp
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(63,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(54): message : while compiling class template member function 'void Pool<Goal,GoalID,64,64000,PT_NORMAL,false,true>::ResizeFor(size_t)' (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(175): message : see reference to function template instantiation 'void Pool<Goal,GoalID,64,64000,PT_NORMAL,false,true>::ResizeFor(size_t)' being compiled (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(31): message : while compiling class template member function 'Pool<Goal,GoalID,64,64000,PT_NORMAL,false,true>::Pool(const char *)' (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\goal.cpp(32): message : see reference to function template instantiation 'Pool<Goal,GoalID,64,64000,PT_NORMAL,false,true>::Pool(const char *)' being compiled
8>F:\Projets\OpenTTD JGR\src\goal_base.h(21): message : see reference to class template instantiation 'Pool<Goal,GoalID,64,64000,PT_NORMAL,false,true>' being compiled (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(64,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(78,1): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(77): message : while compiling class template member function 'size_t Pool<Goal,GoalID,64,64000,PT_NORMAL,false,true>::FindFirstFree(void)' (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(146): message : see reference to function template instantiation 'size_t Pool<Goal,GoalID,64,64000,PT_NORMAL,false,true>::FindFirstFree(void)' being compiled (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(79,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\goal.cpp)
8>F:\Projets\OpenTTD JGR\src\ini_type.h(65,68): error C2039: 'string': is not a member of 'std' (compiling source file ..\src\ini_load.cpp)
8>F:\Projets\OpenTTD JGR\src\stdafx.h(258): message : see declaration of 'std' (compiling source file ..\src\ini_load.cpp)
8>F:\Projets\OpenTTD JGR\src\ini_type.h(65,75): error C2061: syntax error: identifier 'string' (compiling source file ..\src\ini_load.cpp)
8>landscape.cpp
8>F:\Projets\OpenTTD JGR\src\ini_load.cpp(211,1): error C2511: 'void IniLoadFile::LoadFromDisk(const char *,Subdirectory,std::string *)': overloaded member function not found in 'IniLoadFile'
8>F:\Projets\OpenTTD JGR\src\ini_type.h(52): message : see declaration of 'IniLoadFile'
8>F:\Projets\OpenTTD JGR\src\ini_load.cpp(212,2): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
8>F:\Projets\OpenTTD JGR\src\ini_load.cpp(222,13): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
8>F:\Projets\OpenTTD JGR\src\ini_load.cpp(264,5): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
8>F:\Projets\OpenTTD JGR\src\ini_load.cpp(269,25): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
8>F:\Projets\OpenTTD JGR\src\ini_load.cpp(269,40): error C2664: 'IniGroup::IniGroup(const IniGroup &)': cannot convert argument 1 from 'char *' to 'IniLoadFile *'
8>F:\Projets\OpenTTD JGR\src\ini_load.cpp(269,31): message : Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
8>F:\Projets\OpenTTD JGR\src\ini_load.cpp(59,11): message : see declaration of 'IniGroup::IniGroup'
8>F:\Projets\OpenTTD JGR\src\ini_load.cpp(317,4): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
8>F:\Projets\OpenTTD JGR\src\ini_load.cpp(322,3): error C2671: 'IniLoadFile::LoadFromDisk': static member functions do not have 'this' pointers
8>demands.cpp
8>flowmapper.cpp
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\infrastructure.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\infrastructure.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\infrastructure.cpp)
8>F:\Projets\OpenTTD JGR\src\order_cmd.h(57,1): warning C4146: unary minus operator applied to unsigned type, result still unsigned (compiling source file ..\src\infrastructure.cpp)
8>F:\Projets\OpenTTD JGR\src\infrastructure.cpp(315): message : see reference to function template instantiation 'void RemoveVehicleOrdersIf<HandleSharingCompanyDeletion::<lambda_1>>(Vehicle *const ,F)' being compiled
8>        with
8>        [
8>            F=HandleSharingCompanyDeletion::<lambda_1>
8>        ]
8>F:\Projets\OpenTTD JGR\src\order_cmd.h(59,1): warning C4146: unary minus operator applied to unsigned type, result still unsigned (compiling source file ..\src\infrastructure.cpp)
8>linkgraph.cpp
8>linkgraphjob.cpp
8>linkgraphschedule.cpp
8>F:\Projets\OpenTTD JGR\src\linkgraph\demands.cpp(164,1): warning C4267: 'argument': conversion from 'size_t' to 'const T', possible loss of data
8>        with
8>        [
8>            T=uint
8>        ]
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\linkgraph\demands.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\demands.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\demands.cpp)
8>F:\Projets\OpenTTD JGR\src\linkgraph\demands.cpp(374,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data
8>F:\Projets\OpenTTD JGR\src\linkgraph\demands.cpp(466): message : see reference to function template instantiation 'void DemandCalculator::CalcMinimisedDistanceDemand<AsymmetricScalerEq>(LinkGraphJob &,const std::vector<bool,std::allocator<bool>> &,Tscaler)' being compiled
8>        with
8>        [
8>            Tscaler=AsymmetricScalerEq
8>        ]
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\linkgraph\flowmapper.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\flowmapper.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\flowmapper.cpp)
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(63,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(54): message : while compiling class template member function 'void Pool<LinkGraph,LinkGraphID,32,65535,PT_NORMAL,false,true>::ResizeFor(size_t)' (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(175): message : see reference to function template instantiation 'void Pool<LinkGraph,LinkGraphID,32,65535,PT_NORMAL,false,true>::ResizeFor(size_t)' being compiled (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(31): message : while compiling class template member function 'Pool<LinkGraph,LinkGraphID,32,65535,PT_NORMAL,false,true>::Pool(const char *)' (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\linkgraph\linkgraph.cpp(17): message : see reference to function template instantiation 'Pool<LinkGraph,LinkGraphID,32,65535,PT_NORMAL,false,true>::Pool(const char *)' being compiled
8>F:\Projets\OpenTTD JGR\src\linkgraph\linkgraph.h(39): message : see reference to class template instantiation 'Pool<LinkGraph,LinkGraphID,32,65535,PT_NORMAL,false,true>' being compiled (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(64,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(78,1): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(77): message : while compiling class template member function 'size_t Pool<LinkGraph,LinkGraphID,32,65535,PT_NORMAL,false,true>::FindFirstFree(void)' (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(146): message : see reference to function template instantiation 'size_t Pool<LinkGraph,LinkGraphID,32,65535,PT_NORMAL,false,true>::FindFirstFree(void)' being compiled (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(79,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\linkgraph\linkgraph.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(63,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(54): message : while compiling class template member function 'void Pool<LinkGraphJob,LinkGraphJobID,32,65535,PT_NORMAL,false,true>::ResizeFor(size_t)' (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(175): message : see reference to function template instantiation 'void Pool<LinkGraphJob,LinkGraphJobID,32,65535,PT_NORMAL,false,true>::ResizeFor(size_t)' being compiled (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(31): message : while compiling class template member function 'Pool<LinkGraphJob,LinkGraphJobID,32,65535,PT_NORMAL,false,true>::Pool(const char *)' (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\linkgraph\linkgraphjob.cpp(19): message : see reference to function template instantiation 'Pool<LinkGraphJob,LinkGraphJobID,32,65535,PT_NORMAL,false,true>::Pool(const char *)' being compiled
8>F:\Projets\OpenTTD JGR\src\linkgraph\linkgraphjob.h(32): message : see reference to class template instantiation 'Pool<LinkGraphJob,LinkGraphJobID,32,65535,PT_NORMAL,false,true>' being compiled (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(64,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(78,1): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(77): message : while compiling class template member function 'size_t Pool<LinkGraphJob,LinkGraphJobID,32,65535,PT_NORMAL,false,true>::FindFirstFree(void)' (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(146): message : see reference to function template instantiation 'size_t Pool<LinkGraphJob,LinkGraphJobID,32,65535,PT_NORMAL,false,true>::FindFirstFree(void)' being compiled (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(79,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\linkgraph\linkgraphjob.cpp)
8>mcf.cpp
8>refresh.cpp
8>map.cpp
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\linkgraph\linkgraphschedule.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\linkgraphschedule.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\linkgraphschedule.cpp)
8>misc.cpp
8>mixer.cpp
8>music.cpp
8>network.cpp
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\linkgraph\mcf.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\mcf.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\mcf.cpp)
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
8>        with
8>        [
8>            _Ty2=unsigned short
8>        ] (compiling source file ..\src\linkgraph\refresh.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\refresh.cpp)
8>F:\Projets\OpenTTD JGR\src\station_base.h(455): message : see reference to function template instantiation 'std::pair<Key,unsigned short>::pair<StationID&,unsigned __int64,0>(_Other1,_Other2 &&) noexcept' being compiled
8>        with
8>        [
8>            Key=StationID,
8>            _Other1=StationID &,
8>            _Other2=unsigned __int64
8>        ] (compiling source file ..\src\linkgraph\refresh.cpp)
8>network_admin.cpp
8>network_client.cpp
8>network_command.cpp
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(78,1): warning C4267: 'initializing': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(77): message : while compiling class template member function 'size_t Pool<NetworkClientSocket,ClientIndex,8,256,PT_NCLIENT,false,true>::FindFirstFree(void)' (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(146): message : see reference to function template instantiation 'size_t Pool<NetworkClientSocket,ClientIndex,8,256,PT_NCLIENT,false,true>::FindFirstFree(void)' being compiled (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(210): message : while compiling class template member function 'void Pool<NetworkClientSocket,ClientIndex,8,256,PT_NCLIENT,false,true>::CleanPool(void)' (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\network\network_server.h(24): message : see reference to class template instantiation 'Pool<NetworkClientSocket,ClientIndex,8,256,PT_NCLIENT,false,true>' being compiled (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(79,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(63,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(54): message : while compiling class template member function 'void Pool<NetworkClientInfo,ClientIndex,8,256,PT_NCLIENT,false,true>::ResizeFor(size_t)' (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(175): message : see reference to function template instantiation 'void Pool<NetworkClientInfo,ClientIndex,8,256,PT_NCLIENT,false,true>::ResizeFor(size_t)' being compiled (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(31): message : while compiling class template member function 'Pool<NetworkClientInfo,ClientIndex,8,256,PT_NCLIENT,false,true>::Pool(const char *)' (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\network\network.cpp(50): message : see reference to function template instantiation 'Pool<NetworkClientInfo,ClientIndex,8,256,PT_NCLIENT,false,true>::Pool(const char *)' being compiled
8>F:\Projets\OpenTTD JGR\src\network\network_base.h(23): message : see reference to class template instantiation 'Pool<NetworkClientInfo,ClientIndex,8,256,PT_NCLIENT,false,true>' being compiled (compiling source file ..\src\network\network.cpp)
8>F:\Projets\OpenTTD JGR\src\core\pool_func.hpp(64,1): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data (compiling source file ..\src\network\network.cpp)
8>F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility(151,1): warning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data
[...]
========== Build: 4 succeeded, 3 failed, 0 up-to-date, 2 skipped ==========

Re: JGR's Patch Pack

Posted: 13 May 2020 10:25
by JGR
MagicBuzz wrote: 13 May 2020 09:31 Hello,

I'm trying to compile the lastest source (763a2826b60e0bcafa2ec3e65c6cf4560f5f6cf4 the 11/05/2020) with Visual Studio 2019 16.5.4 and I'm getting many errors (some are just amazing, like the "'string': is not a member of 'std'")
Could you try it again now?

Re: JGR's Patch Pack

Posted: 13 May 2020 18:43
by MagicBuzz
Thank you :)

This time I have 285 warning, but it compiles :)

When I read the warning, I see many coding rules errors, but they should not have an impact to the game.

Some exemples :

Code: Select all

Severity	Code	Description	Project	File	Line	Suppression State
Warning	C26495	Variable 'SQVM::CallInfo::_etraps' is uninitialized. Always initialize a member variable (type.6).	openttd	F:\PROJETS\OPENTTD JGR\SRC\3RDPARTY\SQUIRREL\SQUIRREL\sqvm.h	51	
Warning	C26451	Arithmetic overflow: Using operator '*' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '*' to avoid overflow (io.2).	openttd	F:\PROJETS\OPENTTD JGR\SRC\BLITTER\32BPP_ANIM.CPP	42	
Warning	C26451	Arithmetic overflow: Using operator '+' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '+' to avoid overflow (io.2).	openttd	F:\PROJETS\OPENTTD JGR\SRC\BLITTER\32BPP_ANIM.CPP	520	
Warning	C26451	Arithmetic overflow: Using operator '-' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '-' to avoid overflow (io.2).	openttd	F:\PROJETS\OPENTTD JGR\SRC\BLITTER\32BPP_ANIM.CPP	520	
Warning	C6385	Reading invalid data from 'this->durations':  the readable size is '4096' bytes, but 'point' bytes may be read.	openttd	F:\PROJETS\OPENTTD JGR\SRC\FRAMERATE_GUI.CPP	156	
Warning	C4146	unary minus operator applied to unsigned type, result still unsigned (compiling source file ..\src\infrastructure.cpp)	openttd	F:\Projets\OpenTTD JGR\src\order_cmd.h	57	
Warning	C4267	'initializing': conversion from 'size_t' to '_Ty2', possible loss of data	openttd	F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility	151	
Warning	C4805	'^': unsafe mix of type 'uint' and type 'bool' in operation	openttd	F:\Projets\OpenTTD JGR\src\tunnelbridge_cmd.cpp	1557

Re: JGR's Patch Pack

Posted: 13 May 2020 19:20
by JGR
MagicBuzz wrote: 13 May 2020 18:43 Thank you :)

This time I have 285 warning, but it compiles :)

When I read the warning, I see many coding rules errors, but they should not have an impact to the game.

Some exemples :

Code: Select all

Severity	Code	Description	Project	File	Line	Suppression State
Warning	C26495	Variable 'SQVM::CallInfo::_etraps' is uninitialized. Always initialize a member variable (type.6).	openttd	F:\PROJETS\OPENTTD JGR\SRC\3RDPARTY\SQUIRREL\SQUIRREL\sqvm.h	51	
Warning	C26451	Arithmetic overflow: Using operator '*' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '*' to avoid overflow (io.2).	openttd	F:\PROJETS\OPENTTD JGR\SRC\BLITTER\32BPP_ANIM.CPP	42	
Warning	C26451	Arithmetic overflow: Using operator '+' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '+' to avoid overflow (io.2).	openttd	F:\PROJETS\OPENTTD JGR\SRC\BLITTER\32BPP_ANIM.CPP	520	
Warning	C26451	Arithmetic overflow: Using operator '-' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '-' to avoid overflow (io.2).	openttd	F:\PROJETS\OPENTTD JGR\SRC\BLITTER\32BPP_ANIM.CPP	520	
Warning	C6385	Reading invalid data from 'this->durations':  the readable size is '4096' bytes, but 'point' bytes may be read.	openttd	F:\PROJETS\OPENTTD JGR\SRC\FRAMERATE_GUI.CPP	156	
Warning	C4146	unary minus operator applied to unsigned type, result still unsigned (compiling source file ..\src\infrastructure.cpp)	openttd	F:\Projets\OpenTTD JGR\src\order_cmd.h	57	
Warning	C4267	'initializing': conversion from 'size_t' to '_Ty2', possible loss of data	openttd	F:\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\utility	151	
Warning	C4805	'^': unsafe mix of type 'uint' and type 'bool' in operation	openttd	F:\Projets\OpenTTD JGR\src\tunnelbridge_cmd.cpp	1557
I do all my building/testing with gcc/MinGW and sometimes clang.
gcc on Linux builds with no warnings here.

Some of these I'll see about mitigating.

Re: JGR's Patch Pack

Posted: 13 May 2020 20:41
by BeSt-Com
i just compiled under "Linux Version 4.19.97-v7+ (dom@buildbotjcc version 4.9.3 (3 (crosstool-NG crosstool-ng-1.22.0-88-g8460611)) #1294 SMP" without any error.
@JGR: Thanks very much for this patch pack.

And many thanks to BW89for his help
B89 wrote: sudo apt build-dep openttd
sudo apt install git
git clone https://github.com/JGRennison/OpenTTD-patches
cd OpenTTD-patches
./configure
sudo make install

Re: JGR's Patch Pack

Posted: 14 May 2020 05:26
by BeSt-Com
... it works fine, runs on my raspberry pi 2 as a server!
But if i try to connect with "openttd-custom-jgrpp-0.34.2-MINGW-win64" from my client, it says "versionskonflikt"
I thought both are the newest ones? Or mus i change the name before compiling (if so, where?)?
(Name of the compiled version is "jgrpp-0.34.2-48-g77673B731c")
Please, help me :oops:

Re: JGR's Patch Pack

Posted: 14 May 2020 05:45
by ino
BeSt-Com wrote: 14 May 2020 05:26 ... it works fine, runs on my raspberry pi 2 as a server!
But if i try to connect with "openttd-custom-jgrpp-0.34.2-MINGW-win64" from my client, it says "versionskonflikt"
I thought both are the newest ones? Or mus i change the name before compiling (if so, where?)?
(Name of the compiled version is "jgrpp-0.34.2-48-g77673B731c")
Please, help me :oops:
Run this again:

Code: Select all

cd /path/to/OpenTTD-patches
git checkout jgrpp-0.34.2
./configure
sudo make install
The version on git is newer than 0.34.2

Re: JGR's Patch Pack

Posted: 14 May 2020 06:42
by BeSt-Com
thx ino


I thought there was a bugfix and a new version ... ? "better" than 0.34.2?
Did i read that correctly?
If so ... i have to wait for a new Windows-build or do it on my own?

Re: JGR's Patch Pack

Posted: 14 May 2020 06:47
by ino
BeSt-Com wrote: 14 May 2020 06:42 thx ino


I thought there was a bugfix and a new version ... ? "better" than 0.34.2?
Did i read that correctly?
If so ... i have to wait for a new Windows-build or do it on my own?
0.34.2 is the latest release. The patch pack (and also OpenTTD) is developed continuously on the github, so you will always get the latest feature/bugfix, and also latest bug that may be in the code. These changes are periodically release by JGR into new version.

If you want to be able to multiplayer, you need to compile using the exact same commit. However, unless you are looking for specific bugfix or new features, it probably won't be that many differences.

Re: JGR's Patch Pack

Posted: 14 May 2020 08:19
by BeSt-Com
thanks for the info!

Re: Cargo Distribution Issue (JGRPP)

Posted: 21 May 2020 08:47
by JGR
mrbeanisgood wrote: 21 May 2020 01:25 I have passengers set to symmetric and mail to asymmetric. The mail is being assigned different destinations, the passengers are remaining as "to any station". Is this a known issue? I am running JGRPP 0.34.3
Could you post a savegame which shows the issue? Thanks.

Re: Cargo Distribution Issue (JGRPP)

Posted: 21 May 2020 18:18
by LaChupacabra
mrbeanisgood wrote: 21 May 2020 01:25 I have passengers set to symmetric and mail to asymmetric. The mail is being assigned different destinations, the passengers are remaining as "to any station". Is this a known issue? I am running JGRPP 0.34.3
Generally, this is how cargodist works, regardless of whether it is in the JGR version or the basic version of the game.

Cargodist doesn't set concrete destinations, but only divides the cargos between available, existing connections. Loads without a destination always appear at the beginning of the station's operation and also when the assessment of one of the connections is very bad or when you remove one or more of the connections / stations- the cargodist needs some time to calculate it again (the larger the network of connections, the longer it will take), then appears "to any station". It will be the same for mail, passengers and any other goods.
This is not a mistake but a feature. In my opinion, very unfavorable, because the expansion of the network of connections in no way affects the number of passengers or other types of loads appearing at stations. Because of this, the expansion of the connection network in this game is economically meaningless.
Of the simple (?) solutions that could change this, another way of assessing stations could be effective, where the rating would depend on the number of available connections. This was how the NWD script was supposed to work, where the number and population of cities with which it was connected were to be one of the main factors influencing the city's development. This was to alleviate this disadvantage of the cargodist. Due to the difficulty of creating such a mechanism, another has been added, which in a way less readable for the player, but also makes the development of the network of connections beneficial for the development of cities.
Today, it seems to me that a better solution would be just to change the way of stations ratings.

Re: JGR's Patch Pack

Posted: 23 May 2020 14:16
by MagicBuzz
Hello JGR :)

Thank you for the last time, your update fixed the errors with MSVC.

With last commit, there is a new error though :

Code: Select all

Severity	Code	Description	Project	File	Line	Suppression State
Error	MSB3073	The command "chcp 65001 >NUL && 
..\objs\settings\settings_gen.exe -o ..\objs\settings\table\settings.h -b ..\src\table\settings.h.preamble -a ..\src\table\settings.h.postamble ..\src\table\company_settings.ini ..\src\table\currency_settings.ini ..\src\table\gameopt_settings.ini ..\src\table\misc_settings.ini ..\src\table\settings.ini ..\src\table\win32_settings.ini ..\src\table\window_settings.ini
    " exited with code 255.	settings	F:\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.MakeFile.Targets	54
But... I don't know what actually did this, as the error is raised in a MSVC standard file : F:\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.MakeFile.targets

Re: JGR's Patch Pack

Posted: 24 May 2020 09:02
by kama5638
Good morning,

I have made a video on how to compile on linux (debian)

https://youtu.be/BMQDGR02-RM
All times are UTC
Page 140 of 243
Powered by phpBB © 2000-2025 phpBB Limited

Copyright © Owen Rudge/The Transport Tycoon Forums 2001-2025.