Page 2 of 2

Re: Polish Buildings as Objects (update to v2.0)

Posted: 27 Nov 2024 08:45
by Quast65
I hope I am not too annoying... :twisted:
But I am missing one supermarket:
Example1092.png
Example1092.png (30.11 KiB) Viewed 5080 times
Maybe you can make the shopping object 4 views?
You can then for example also add a marketsquare with the light striped groundtiles (like the one with the tank in the image) as a second version...

Re: Polish Buildings as Objects

Posted: 28 Nov 2024 00:10
by moof
chujo wrote: 26 Nov 2024 13:58 More than a year later, I deliver on my promise. :)

The NewGRF has been updated to version 2.0, which includes the buildings mentioned by you + some extras and fixes.
Hello,
first of all, let me tell you I absolutely adore your set. I love the schools, big churches, squares, hotels, parks... Central European maps would be incomplete without your buildings. Thank you very much for your effort.

Therefore, I was excited when I saw there are new buildings. And no doubt they are great.

However there is one big problem. I'm building very large maps, spending even 3-4 years on one map. I have literally thousands of villages and towns. Each one built manually.

And when the creator suddenly changes the buildings within the set, it means my complete map is destroyed. I have to choose: not to upgrade the set, or manually rebuild every tile. Because after ID changing my parks suddenly became churches, houses became tanks, hotels became the Warsaw's Palace of Culture and Science, etc.

I don't know if it's possible to add new buildings without changing the ID of old ones. If yes, please, be so kind and do it this way. If not - OK, I'm nobody to expect any additional work for you :)

Re: Polish Buildings as Objects

Posted: 28 Nov 2024 00:32
by ebla71
moof wrote: 28 Nov 2024 00:10 However there is one big problem. I'm building very large maps, spending even 3-4 years on one map. I have literally thousands of villages and towns. Each one built manually.

And when the creator suddenly changes the buildings within the set, it means my complete map is destroyed. I have to choose: not to upgrade the set, or manually rebuild every tile. Because after ID changing my parks suddenly became churches, houses became tanks, hotels became the Warsaw's Palace of Culture and Science, etc.

I don't know if it's possible to add new buildings without changing the ID of old ones. If yes, please, be so kind and do it this way. If not - OK, I'm nobody to expect any additional work for you :)
I can only second that!!!

The problem, I think, arises from the fact that - other than industries - "decorative sprites" like buildings have no fixed ID that can be assigned in the code. That means, in an industry NewGRF, you can change the order of blocks in the code but the industry remains the same, as long as the ID is not changed. However, in building NewGRFs, when you insert code in the middle of a file, the order of sprites is "shifted" and you get these strange replacements. On the other hand, if you strictly stick to the addition of new buildings to the end of the code, in the menue, buildings of the same type might not be shown together anymore in the selection menue (like all churchs grouped together).

So in the end, you have to "die one death or the other"

Re: Polish Buildings as Objects (update to v2.0)

Posted: 28 Nov 2024 10:57
by luxtram
Some people have solved this by leaving intentional empty place holder in object sets. I think the same could be done also in buildings sets, except here the usage of the building should be controlled in addition by the newgrf code.

Re: Polish Buildings as Objects (update to v2.0)

Posted: 29 Nov 2024 01:00
by chujo
Quast65 wrote: 27 Nov 2024 08:45 I hope I am not too annoying... :twisted:
But I am missing one supermarket:
You're not annoying, but to be honest, I have already spent too much time putting this together, so I plan not to touch it for a while (besides fixing potential bugs). Maybe in the future?


Now, it looks like it's time to clear some things up:
moof wrote: 28 Nov 2024 00:10 first of all, let me tell you I absolutely adore your set.
I love the love, but to be clear - I keep mentioning in Readmes and descriptions the original authors, because most of the credit goes to them.
I only drew some smaller bits, added snow sprites, modified some buildings etc.

I have literally thousands of villages and towns. Each one built manually. And when the creator suddenly changes the buildings within the set, ...
I don't know if it's possible to add new buildings without changing the ID of old ones.
Unfortunately, this is how things are and will be. But it had to be done, like I said in the first post, the code is completely reworked from scratch (because the old one was very, very not good, barely functional).
Which makes the current version not compatible with any older ones (it shouldn't even let you upgrade an existing save!) - I added a warning in the first post to emphasize this point.
I guess it has become one of those NewGRFs that you have to archive together with the save file.

ebla71 wrote: 28 Nov 2024 00:32 "decorative sprites" like buildings have no fixed ID that can be assigned in the code.
That's it, sort of.
You can give IDs to objects, so technically they are uniquely identifiable, and if "you insert code in the middle of a file", you don't shift them.
That's because the ID makes their order fixed - but then the problem is, that you can't shift them, even if you want to.
And of course, when you start changing IDs, you get just transmitters.
Ergo. whichever path you choose, compatibility breakage will occur.

luxtram wrote: 28 Nov 2024 10:57 Some people have solved this by leaving intentional empty place holder in object sets.
Sure, next time, I will ask Doc Brown. :-D

Re: Polish Buildings as Objects (update to v2.0)

Posted: 29 Nov 2024 04:09
by fridaemon
ebla71 wrote: 28 Nov 2024 00:32 "decorative sprites" like buildings have no fixed ID that can be assigned in the code.
u can release (onofficial version) the same under another ID for early players or do additional things only with new stuffs.

As I started with my objects years ago I'd like to removed or reorganize my items but I can't do that because of early games. So I'm Very careful About that.

Re: Polish Buildings as Objects (update to v2.0)

Posted: 29 Nov 2024 09:48
by Quast65
I totally understand that you want to take a break ;-)

Short answer to all issues (also mine with the supermarket) is, there is a source available.
So, it is possible to fork the GRF to suit the needs.

Thank you again for all of the hard work you put into this! :bow:

Re: Polish Buildings as Objects (update to v2.0)

Posted: 29 Nov 2024 10:34
by Mrsunman
I agree with Quast, Take a break, after all, it's natural to get tired every so often, and plus, This set is already such an amazing collection of buildings :D .

Re: Polish Buildings as Objects (update to v2.0)

Posted: 29 Nov 2024 20:07
by belgi
True, these buildings are amazing. So you can take a break and relax.
Anyway, thank you very much for these wonderful buildings (also usable in the Czech environment) :bow:

Re: Polish Buildings as Objects (update to v2.0)

Posted: 16 Dec 2024 14:03
by panswato
Great!!! gonna show them soon THANKS FOR YOUR NICE WORK