Page 8 of 10

Re: Terkhen's Personal Patch Pack [r17788-v10]

Posted: 19 Oct 2009 19:43
by petert
Bennythen00b wrote:Can't find any binaries for v9 or v10, and I can't be arsed to build it myself.
I would love to build it for you, but Terkhen has told me not to give out binaries because of the people that report bugs of Terkhen's patchpack into bugs.openttd.org

Re: Terkhen's Personal Patch Pack [r17788-v10]

Posted: 19 Oct 2009 19:53
by Benny
How 'bout a PM then? Image

Re: Terkhen's Personal Patch Pack [r17788-v10]

Posted: 19 Oct 2009 19:54
by Terkhen
Bennythen00b: I was able to reproduce the bug without the required NewGRFs in v08. This bug was present in trunk and was corrected in r17782. TPPP v10 should be free of that problem. Thank you for reporting :)

petert: That was not what I said. If you want to post binaries somewhere, I'm not going to stop you. All of the patches that make TPPP are freely available, and I'm not going to pretend that I have rights over a combination of them. What I said to you was what I already said here:
Terkhen wrote:Be warned: if compiled binaries appear and the mentioned issues keep occurring, I will erase the development page and turn TPPP into a private build again.

Re: Terkhen's Personal Patch Pack [r17788-v10]

Posted: 19 Oct 2009 19:56
by Benny
Oh, great. *waiting for a binary* :3

Re: Terkhen's Personal Patch Pack [r17788-v10]

Posted: 19 Oct 2009 20:00
by petert
Have you tried this tutorial?

Re: Terkhen's Personal Patch Pack [r17788-v10]

Posted: 19 Oct 2009 20:05
by Benny
Indeed. I failed, and it took forever to do.

Re: Terkhen's Personal Patch Pack [r17788-v10]

Posted: 19 Oct 2009 20:15
by petert
I had the tremendous help of Yexo, whom I owe many thanks to. Try this: start all over from the beginning, then post any errors in a forum topic, see if other people can tell.

Re: Terkhen's Personal Patch Pack [r17788-v10]

Posted: 19 Oct 2009 20:20
by Benny
Meh, can't be bothered. I'll just scrap that game, and start over with some other OTTD build.

Re: Terkhen's Personal Patch Pack [r17788-v10]

Posted: 30 Nov 2009 22:22
by Terkhen
New version of TPPP is ready. You can grab the diff file at the usual place.

r18353-v11: Added Diagonal level and clear and Upgrade airports. Updated Improved acceleration for road vehicles (v12) and Signals in tunnels and on bridges (v27). Removed Extra-large maps and Numbers on station list (rejects caused by GUI updates in trunk).

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 30 Nov 2009 22:25
by petert
As usual, great patch pack! Thank you for the addition of diagonal level and clear. I have a screenshot game which will be based on your patchpack. Thank you!

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 30 Nov 2009 23:00
by petert
Sorry for the double post, but I can't load my old savegame for the screenshot topic. :cry: Is there a way to get around this?

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 01 Dec 2009 07:41
by Terkhen
Savegame compatibility is not guaranteed between versions. That said: I did not remove any savegame altering patches from v10 besides Extra-large maps (and it should only affect if your map size is greater than 2048). If that's not the cause then your problem is probably caused by an incorrect update of the three savegame bumping patches. I'll give it a look when I have some free time.

Edit: The incompatibility is caused by Improved acceleration for road vehicles. I made a change to the savegame version scheme to ensure future compatibility between versions of the patch. Because of this, there is no way to send your old savegame to v11.

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 01 Dec 2009 11:27
by petert
Well thank you for looking into it. I will downgrade and play with the old version. Thanks Terkhen.

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 01 Dec 2009 15:02
by Gremnon
Terkhen, you might want to borrow the 'Save to trunk' patch made someplace in my pack's thread - it's not mine (made by sulai, IIRC) and I can't really guarantee it'll work, but it saves the game in the trunk savegame version, which in theory means it should then be loadable into the newer version - assuming trunk compatibility is still there.

I think it'll need a bit of updating to make it work correctly, though.
Also, petert, whether or not Terkhen does consider the Save to trunk patch, you might want to try it yourself, and see if it works - at least that way, there's a chance you might be able to import your old game into the new version.

Edit: Just read Terkhen's edit. I think that might sod up the Save to trunk. Haven't looked, so can't say for sure.

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 01 Dec 2009 20:40
by petert
I will try it, thanks. I didn't know that "save to trunk" was universal, I thought it was made specifically for your patchpack.

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 01 Dec 2009 20:48
by Gremnon
I think it was, actually, but if you go back, there's a patchfile available that can be adapted for pretty much any patch.

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 01 Dec 2009 22:50
by Terkhen
I don't know how a patch like that works, but I don't think it is possible to make it work correctly in all cases. For example; how do you convert vehicles with the new conditional order to trunk without destroying their intended behaviour?. Besides probably being prone to bugs (you can check a discussion about savegame compatibility earlier in this thread) it is too much work for such a small gain in my opinion: usually I just finish my game in the old build before moving to the new one.

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 02 Dec 2009 00:04
by petert
Yes. I think I will just recompile the old game and then play with that (and finish it), then start a new game.

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 02 Dec 2009 00:51
by finesse
Thought id try this pack out now that theres a new version.. just wondering why its named r18353 though? Compiled fine against r18352, so im assuming you added 1 to the revision for you PP or something?

Re: Terkhen's Personal Patch Pack [r18353-v11]

Posted: 02 Dec 2009 06:49
by Terkhen
As long as there are no conflicts, it can apply to any revision. This means that you probably can apply the diff file to revisions before and after r18353 until you reach the first reject. But the diff was made against r18353, and that is the only revision guaranteed to work with the diff file.