Traffic lights (r17455)

[Zuu]

hello,

sorry, but will you put this into trunk in the future?

That is not really in decision of Roujin. Sure while depending on how much he polish on the patch it may be more or less suitable for inclusion, it is still up to the OpenTTD devs to decide if and when they want to include it or not.

[maquinista]

I tried this patch some time ago. I don't know if my problem was fixed or not.

The problem is that sometimes the city builds trafficlights in my motorways.

It would be interesting not allow the city build traffic lights in roads built by a player, Only allow build them by the city in roads owned by the city.

[Sensation Lover]

I think the city shouldnt build traffic lights...only the player

[Roujin]

I tried this patch some time ago. I don't know if my problem was fixed or not.

The problem is that sometimes the city builds trafficlights in my motorways.

It would be interesting not allow the city build traffic lights in roads built by a player, Only allow build them by the city in roads owned by the city.

No, this problem was not "fixed" (in quotes because it's not really a bug, but game logic existing in OpenTTD I did not change). The problem is that a town may grow quite a bit into player owned roads, without taking ownership of them.
So if I would fix your problem, by making road works only appear on town owned roads, it would spawn a new problem: there might exist towns (late in the game) with only a little bit of road in their own possession, and the others are player owned (even the ones with sidewalks). Then no road works will ever appear on those roads...

Hmm, I could do it as YAAS (yet another advanced setting) though...
But I wouldn't really be happy with it.. it solves a problem while creating a new one..

One question: which one would you prefer: forbid towns to do roadworks on player owned roads, or don't create traffic lights while doing roadworks on player owned roads?


---
@Sensation Lover: great that you're thinking that, because it's already completely optional with my patch - there's a switch in the advanced settings you can use to allow/forbid towns to build traffic lights.

[Sensation Lover]

lol sorry...

[maquinista]

I tried this patch some time ago. I don't know if my problem was fixed or not.

The problem is that sometimes the city builds trafficlights in my motorways.

It would be interesting not allow the city build traffic lights in roads built by a player, Only allow build them by the city in roads owned by the city.

No, this problem was not "fixed" (in quotes because it's not really a bug, but game logic existing in OpenTTD I did not change). The problem is that a town may grow quite a bit into player owned roads, without taking ownership of them.
So if I would fix your problem, by making road works only appear on town owned roads, it would spawn a new problem: there might exist towns (late in the game) with only a little bit of road in their own possession, and the others are player owned (even the ones with sidewalks). Then no road works will ever appear on those roads...

Hmm, I could do it as YAAS (yet another advanced setting) though...
But I wouldn't really be happy with it.. it solves a problem while creating a new one..

One question: which one would you prefer: forbid towns to do roadworks on player owned roads, or don't create traffic lights while doing roadworks on player owned roads?


---
@Sensation Lover: great that you're thinking that, because it's already completely optional with my patch - there's a switch in the advanced settings you can use to allow/forbid towns to build traffic lights.

Ok, The problem is that some cities think that They owns my roads. These problems could be fixed in other patch.

About traffic lights: I think that It is a interesting patch.

[Gremnon]

Roujin,
do you mind if we put a copy of the trafficlights.grf with the precompiled builds of the Community Integrated Version?
(And if not, does it matter which one? I think there's three)

[Roujin]

Please go ahead and include it/them.
Yes, there's three, and IIRC the light ones are well visible with the default roads, I'd use that file and maybe include the others and write a note that there are alternatives (and how to use them), if the traffic lights have bad visibility on the player's preferred road set.

[Sensation Lover]

Trafic Lights is very nice feature. Adding realism and eyecandy to the game. I play Ottd with the Gremnons Patch Pack (because of the very nice, well implemendet and carefully choosen patches). and befor the last release it was included, and many people like me were happy . But now there is no more cuz it's a little bit outdated. Could you please bring it up to date with the trunk? maybe gremnon will included it back again and make us (me and many many others who like it) a very nice Christmas Present . It would be very appreciated if you could do this.

Thanks however for your work!
Cheers

[Gremnon]

...
I said maybe you could help bring it up to date...
Roujin might not be interested in maintaining it any longer, or not have the time to do it in time.

[Sensation Lover]

I asked him nicely. That's all. i've not obligated him... after all, sooner or later he will up date the patch. I don't think he will abandon such greate work. I think a lot of people don't know about the marvelous features this patch gives. for example, in my games, i give a lot of importance to public transport in a city. and with this patch is possible to have very nice and realistic trafic. even when behind the trafic light formes queues, it s so nice (sometimes). can you immagine all that tiny people in the cars honking and yelling .

[Anon]

Against the stable version.

[Comm Cody]

Word of Advice. I think merging a patch against the stable causes it to still display that it is a stable on online games when in reality it's not.

[Roujin]

Word of Advice. I think merging a patch against the stable causes it to still display that it is a stable on online games when in reality it's not.

Nope, except if you specifically tell the compiler to do so on compiling.

[Anon]

Intended use of the patch against stable — patchpacks. I don't think that in such case it is crucial to change the OpenTTD version in the rev.cpp.in.

[planetmaker]

It is especially in that case important to change it. This patch makes the game incompatible as it changes the game behaviour. So saying that it is the same as one of the stable versions is lying into your own pocket and will produce unuseful bug reports where devs waste their time on for no good reason instead of bringing us real bug reports or other new features (for example by reviewing patches).

That said: a patch needs not change the version itself as it *should* be done automatically by the version detection upon compiling - unless that is tempered with.

[Roujin]

That said: a patch needs not change the version itself as it *should* be done automatically by the version detection upon compiling - unless that is tempered with.

... which is exactly what I meant with my last post, only in better words

[eliberatorM]

I think its a great patch, and whats the problem of towns building traffic lights on player owned roads?

[maquinista]

I think its a great patch, and whats the problem of towns building traffic lights on player owned roads?

The problem is that sometimes these roads are motorways and They can't have traffic lights. It's a detail that should be fixed.

It like this patch.

[rileyper]

this is great, hope to see more improvements in the future, and i'll report any bugs if any when i see them thanks