Salut folks,
there's are now new binaries available thanks to OpenTTD's compile farm which produced them for us for all major platforms (thanks Rubidium for providing them). They're found at the usual place
http://bundles.openttdcoop.org/is2/IS2.0-beta5/ (and no one noticed that they're there already for two days... without any announcement
) The repository is up to trunk r17973.
Please test the patch extensively and report any errors which you find in this thread or at the corresponding project at the DevZone. Most of all though: enjoy!
What did change (wrt beta4)?
13761: [IS] Fix: Properly set the sharing window capacity in all cases, fixing what used to be an assertion failure.
13760: [IS] Doc: More documentation added and existing documentation cleaned up.
13759: [IS] Doc: (closes #607) Document all stuff that wasn't already documented in the infrastructure* files. Fix some line endings in the process.
13758: [IS] Codechange: Use true/false instead of 1/0 in SetFill().
13629: [IS] Fix: (fixed #608) Removing a company could, in some cases, create an invalid state, causing an assertion failure later.
13628: [IS] Codehange/Fix: Compute the scroll count of the sharing window in a separate function. Call this function in the constructor, so the scroll count is set correctly when opening the window.
13627: [IS] Fix: (fix #609) Crash when opening the sharing window.
13626: [IS] Fix: Depot view would cause hang. Better always check things twice after a merge...
and between beta4 and beta3:
13358: [IS] Codechange: Remove some unneeded code.
13357: [IS] Codechange: Use SetStringParameters instead of DrawWidget when appropriate.
13356: [IS] Codechange: Use Window::GetWidget instead of directly referencing window::nested_array.
13195: [IS] Change: use the new shiny toy ScrollBar::IsVisible.
13194: [IS] Cleanup some minor stuff.
13193: [IS] Fix: line endings of company_gui.cpp.
13192: [IS] Add: GPL license text to all IS files.
12958: [IS] Change: Move strings around in english.txt and rename them to stay compatible with the latest changes in trunk.
12832: [IS] Feature: Make the line height in the sharing window dependant on font height.
12831: [IS] Fix: Orders of type OT_GOTO_WAYPOINT now always have a Waypoint as their destination.
12638: [IS] Add: /* $Id$ */ to the top of each new file (infrastructure_xxx).
12637: [IS] Cleanup: some minor cleanups here and there.
12636: [IS] Fix: SharingMOde contained an unneccessary capital.
12635: [IS] Fix: The string 'Changes will take effect in:' should also influence the minimum width of the sharing window.
12634: [IS] Codechange: HandleSharingChange only needs to know whether trains were removed, their number is irrelevant. Therefore some code can be simplified.
12633: [IS] Doc: A "hack" that is used in trunk is not a hack, so do not document it as such.
12632: [IS] Fix: Stations can never be owned by OWNER_WATER, so checking for it is not needed.
12631: [IS] Cleanup: Use MemSetT instead of a for-loop when setting all items in an array to 0.
12630: [IS] Cleanup: don't use this->windownumber when a local variable can be accessed with the same value.
12629: [IS] Fix: Missing IsHangarTile() in CmdBuildAircraft.
12628: [IS] Codechange: move the sharing 'block' in table/settings.h to a different location.
12627: [IS] Codechange: Enumify the possible values for the sharing mode.
12626: [IS] Codechange: a bit of cleanup in UpdateSharingEnabled.
12625: [IS] Codechange: FORCEINLINE the most-used functions of the sharing struct.
12624: [IS] Codechange: Add a break statement when continuing the loop is pointless.
12623: [IS] Don't store pointers to sharing_current and sharing_future in the sharing window class, as we can easily fetch those when we need them. They are now locally cached in OnPaint since that is the place we require them the most.
12622: [IS] Feature: Implement GetWidgetContentSize for the sharing window. In layman's terms, it means that the window now adjusts itself to the size of the text (horizontally at least).
12621: [IS] Fix: Adjust the nested widgets of the sharing window, so it looks better when using a non-standard font size.
12613: [IS] Fix: Remove trailing whitespace.
12612: [IS] Fix: Line endings of smallmap_gui.cpp.
12611: [IS] Change: Improve the doxygen comment for IsStationUsageAllowed.
12610: [IS] Codechange: More codestyle fixes and deduplication in infrastructure_func.h.
12609: [IS] Codechange: Unify IsStationUsageAllowed, removing duplication of code and comments and increasing clarity.
12608: [IS] Fix: The OT_WAYPOINT change for ships made some further adjustments neccesary which I initially missed.
12607: [IS] Revert: (partially) the last commit. IsStationUsageAllowed may not be needed, but it doesn't hurt either and provides some future compatibility.
12606: [IS] Fix: (rLastCommit) Don't commit at 2 am. Buoys have no owner and are always allowed, calling IsStationUsageAllowed() for them is pointless.
12605: [IS] Change: Since buoy orders are now of type OT_WAYPOINT, adjust the IS code code to accommodate that.
12558: [IS] Codechange: Use the new shiny toy Window::DrawWidget a bit.
12512: [IS] Codechange: some signed variables made unsigned in the GUI code.
12511: [IS] Fix: [Bug #289] missing return statement in smallmap code, causing a compile warning.
12510: [IS] Silence some compile warnings. This partially fixes issue #289
12509: [IS] Codechange: [YAPF] Store the owner of the track in the TILE struct.
12508: [IS] Fix: Make the track follower always return EC_OWNER instead of EC_NO_WAY when the tile cannot be accessed due to ownership issues.
12507: [IS] Fix: Use INVALID_TILE and INVALID_TRACK where appropriate.
12482: [IS] Fix: Only sell ships that are *stopped* in a depot on a sharing change, since ships can move through others' depots.
12481: [IS] Codechange: remove some superfluous newlines.
12480: [IS] Fix: move a comment to the appropriate location.
12342: [IS] Codechange: update scroll information on data invalidation instead of on paint. When invalidating a window, invalidate its data where applicable.
12341: [IS] Codechange: Enable/disable buttons in the sharing window only when required.