Terkhen's Personal Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Post Reply
User avatar
Sensation Lover
Transport Coordinator
Transport Coordinator
Posts: 338
Joined: 26 Feb 2009 09:17
Skype: Aron Bogdan Silviu
Location: Torino, Italy
Contact:

Re: Terkhen's Personal Patch Pack [r17206-v07]

Post by Sensation Lover »

Terkhen wrote:The binary provided should work in all windows platforms from XP onwards (never tested Windows 2000)... Or your problem is that the binary is compressed in rar?

Edit: Corrected

works great! thanks a lot pal!
I was in:
Austria,Belgium,Brazil,China,France,Germany,Hungary,Indonesia,Italy,Luxemburg,Malaysia,Mexico,Netherlands,Norway,Panamà,Poland,Romania,
Saudi Arabia,Singapore,Slovenia,Spain,Switzerland,Thailand,U.K.,Ukraine,U.S.A.
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Terkhen's Personal Patch Pack [r17206-v07]

Post by 2007Alain2007 »

Hi there

There has been an update to Station Listing Patch i looked at this atch and it seem to meet your rules

Changes are

Code: Select all

Index: src/station_gui.cpp
===================================================================
--- src/station_gui.cpp	(revision 17288)
+++ src/station_gui.cpp	(working copy)
@@ -377,6 +377,7 @@
 
 		int max = min(this->vscroll.pos + this->vscroll.cap, this->stations.Length());
 		y = 40; // start of the list-widget
+		int x_max = this->widget[SLW_LIST].right;
 
 		for (int i = this->vscroll.pos; i < max; ++i) { // do until max number of stations of owner
 			const Station *st = this->stations[i];
@@ -395,8 +396,11 @@
 			/* show cargo waiting and station ratings */
 			for (CargoID j = 0; j < NUM_CARGO; j++) {
 				if (!st->goods[j].cargo.Empty()) {
-					StationsWndShowStationRating(x, this->widget[SLW_LIST].right, y, j, st->goods[j].cargo.Count(), st->goods[j].rating);
-					x += 20;
+					if (x + 33 > x_max) break;
+					SetDParam(0, st->goods[j].cargo.Count());
+					x = 2 + DrawString(x, x_max, y, STR_TINY_BLACK_COMA);
+					StationsWndShowStationRating(x, x_max, y, j, st->goods[j].cargo.Count(), st->goods[j].rating);
+					x += 23;
 				}
 			}
 			y += 10;
The file can be found here http://www.tt-forums.net/viewtopic.php? ... 9&start=40

thanks to adf88 for his update
For Community Integrated Version http://code.google.com/p/civopenttd/
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Terkhen's Personal Patch Pack [r17206-v07]

Post by Terkhen »

2007Alain2007: As I already told you (three times with this one, if I am not mistaken) I check all patches in this forum and at flyspray very frequently. There is no need to notify me about new patches in these places, as I'll already know about them at the time you post. If a new patch is made public, wait until next release of TPPP before suggesting it. Since right now I'm busy with more important issues (I am coding two complicated features and facing my resit exams) don't expect it soon.

I can (and will) download the diff myself: having to scroll code that I can find elsewhere don't help me. Besides that, since I made an update of that patch to an old trunk revision myself, you could guess that I already knew the code.
fatgit
Engineer
Engineer
Posts: 2
Joined: 29 Aug 2009 15:02

Re: Terkhen's Personal Patch Pack [r17206-v07]

Post by fatgit »

would love to try this compilation, but I can't get it to patch onto the stable or latest nightly (need to compile on linux) as quite a few hunks fail, where would I find r17206 ?

Cheers
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Terkhen's Personal Patch Pack [r17206-v07]

Post by planetmaker »

fatgit wrote:would love to try this compilation, but I can't get it to patch onto the stable or latest nightly (need to compile on linux) as quite a few hunks fail, where would I find r17206 ?
Same place as you'd get all the source code of an arbitrary revision: the source repository, either via svn, mercurial or git. Check the development section of the OpenTTD manual /wiki (see my signature)
User avatar
Ammler
President
President
Posts: 953
Joined: 18 Jun 2006 18:18
Location: Switzerland
Contact:

Re: Terkhen's Personal Patch Pack [r17206-v07]

Post by Ammler »

fatgit
Engineer
Engineer
Posts: 2
Joined: 29 Aug 2009 15:02

Re: Terkhen's Personal Patch Pack [r17206-v07]

Post by fatgit »

Heh cheers to both of you, my mistake was an obvious one, too obvious for me it seems, I was only looking in http://vcs.openttd.org/svn/browser and http://svn.openttd.org/

*smacks forehead*
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Terkhen's Personal Patch Pack [r17531-v08]

Post by Terkhen »

Here is a new version:

r17513-v08: Added Close tools with middle mouse click, Improved acceleration for road vehicles, Numbers on station list, Pathfinder penalty for road vehicles and Persistent clone. Included Shade windows again. NewGRF GUI has been removed until GUI related changes in trunk are finished. Build rail stations over tracks and Leave tracks when removing station have been removed, as they are now in trunk. Savegames can't be loaded in trunk anymore.

This is the last version of TPPP that is released with a win32 binary (you can find it at the development page). The first motive for this is that from now on I will be developing my projects in linux (I'm starting my final year project), and that includes compiling (and of course playing) OpenTTD. I could cross compile a win32 build, but I won't: the other motive for my decision is that providing binaries has been causing issues with users annoying the wrong people with problems related only to TPPP, even when I posted a detailed way of reporting these errors to me. I knew from the start that I would end doing this, but since I already do the work of updating and compiling a custom build for myself, I had to try releasing this work for the people that can't compile by themselves.

The development page is still going to be active, as I will keep using it to store the patches. I will also upload TPPP diff files to the downloads section, so anyone able to compile can still use TPPP. Be warned: if compiled binaries appear and the mentioned issues keep occurring, I will erase the development page and turn TPPP into a private build again.
Timmaexx
Transport Coordinator
Transport Coordinator
Posts: 301
Joined: 03 Jan 2009 17:55

Re: Terkhen's Personal Patch Pack [r17531-v08]

Post by Timmaexx »

Terkhen wrote:Here is a new version:
...The first motive for this is that from now on I will be developing my projects in linux (I'm starting my final year project), and that includes compiling (and of course playing) OpenTTD. I could cross compile a win32 build, but I won't!.
Am I allowed to ask which distro you're using?
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Terkhen's Personal Patch Pack [r17531-v08]

Post by Terkhen »

Ubuntu 9.04.
User avatar
Sensation Lover
Transport Coordinator
Transport Coordinator
Posts: 338
Joined: 26 Feb 2009 09:17
Skype: Aron Bogdan Silviu
Location: Torino, Italy
Contact:

Re: Terkhen's Personal Patch Pack [r17531-v08]

Post by Sensation Lover »

hi terk,

i noticed that in the patch, when abilitate magic buldozer, is not possible to demolish anymore industries and the "comunication towers" and i think "towerlights too". i have the OpenTTD r17206M ...
I was in:
Austria,Belgium,Brazil,China,France,Germany,Hungary,Indonesia,Italy,Luxemburg,Malaysia,Mexico,Netherlands,Norway,Panamà,Poland,Romania,
Saudi Arabia,Singapore,Slovenia,Spain,Switzerland,Thailand,U.K.,Ukraine,U.S.A.
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Terkhen's Personal Patch Pack [r17531-v08]

Post by Terkhen »

Thanks for the bug report, Sensation Lover. The patch causing the bug has been found (diagonal level and clear) and the bug has been reported.
User avatar
Sensation Lover
Transport Coordinator
Transport Coordinator
Posts: 338
Joined: 26 Feb 2009 09:17
Skype: Aron Bogdan Silviu
Location: Torino, Italy
Contact:

Re: Terkhen's Personal Patch Pack [r17531-v08]

Post by Sensation Lover »

wish to be more useful than that...
you are welcome!... and thank's for everything!
I was in:
Austria,Belgium,Brazil,China,France,Germany,Hungary,Indonesia,Italy,Luxemburg,Malaysia,Mexico,Netherlands,Norway,Panamà,Poland,Romania,
Saudi Arabia,Singapore,Slovenia,Spain,Switzerland,Thailand,U.K.,Ukraine,U.S.A.
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Terkhen's Personal Patch Pack [r17744-v09]

Post by Terkhen »

You are welcome, Sensation Lover. Patches and patch packs are always in need of testing and bug reporting.

New version of TPPP, here is the changelog:

r17744-v09: Added Filter sign list. Updated Close airports, Improved acceleration for road vehicles (to v11) and Autoload face (caused problems with AI company faces). Close tools with middle mouse click reverted to v1. Removed Shade windows and Signals GUI: Indicate CTRL state (incompatibilities with trunk). Removed Diagonal level and clear because of (http://www.tt-forums.net/viewtopic.php?p=817887#p817887).

Get the diff file and the README at the TPPP development page.
User avatar
Sensation Lover
Transport Coordinator
Transport Coordinator
Posts: 338
Joined: 26 Feb 2009 09:17
Skype: Aron Bogdan Silviu
Location: Torino, Italy
Contact:

Re: Terkhen's Personal Patch Pack [r17744-v09]

Post by Sensation Lover »

is it possible to have a "ready for windows" .zip archive please. i know you said you wont compile binaries anymore, but... i can't make it by myself...
can you PM me the .zip?... sorry and thanks anyway!
I was in:
Austria,Belgium,Brazil,China,France,Germany,Hungary,Indonesia,Italy,Luxemburg,Malaysia,Mexico,Netherlands,Norway,Panamà,Poland,Romania,
Saudi Arabia,Singapore,Slovenia,Spain,Switzerland,Thailand,U.K.,Ukraine,U.S.A.
hwndmaster
Engineer
Engineer
Posts: 4
Joined: 16 Jul 2009 10:09

Re: Terkhen's Personal Patch Pack [r17744-v09]

Post by hwndmaster »

Sensation Lover wrote:is it possible to have a "ready for windows" .zip archive please. i know you said you wont compile binaries anymore, but... i can't make it by myself...
can you PM me the .zip?... sorry and thanks anyway!
I think it would be very convenient to have "ready for windows" version for public use. Could anyone make a build of current version and put it to code.google.com/p/tppp site?
Also it would be nice to see new builds(versions) there periodically.
User avatar
Sensation Lover
Transport Coordinator
Transport Coordinator
Posts: 338
Joined: 26 Feb 2009 09:17
Skype: Aron Bogdan Silviu
Location: Torino, Italy
Contact:

Re: Terkhen's Personal Patch Pack [r17744-v09]

Post by Sensation Lover »

since i saw your TPPP Terkhen, i play only with it. so i think you will do a great favour to us "newbies" that don't know to patch.

thanks again for your GREAT work!

Cheers amigo :mrgreen:
I was in:
Austria,Belgium,Brazil,China,France,Germany,Hungary,Indonesia,Italy,Luxemburg,Malaysia,Mexico,Netherlands,Norway,Panamà,Poland,Romania,
Saudi Arabia,Singapore,Slovenia,Spain,Switzerland,Thailand,U.K.,Ukraine,U.S.A.
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Terkhen's Personal Patch Pack [r17744-v09]

Post by Terkhen »

The motives for my decision of not providing windows binaries for TPPP are explained at the v08 release post. I didn't had any answers to my decision then, probably because a windows binary was provided and nobody bothered in asking about future problems.

My first problem for not providing windows binaries could be easily solved: Instaling MinGW and compiling OpenTTD with it is really easy. I doubt that anything can change my mind about the second issue, though. Some people kept reporting problems where they didn't belong (even after I stated the obvious at the README and at the first post). This kind of behaviour annoyed people that is working with OpenTTD related stuff at the forums, and I can't allow that to happen. Since I'm not willing to read everything at the forums to tell these people to report TPPP problems to me (specially difficult since they usually don't say that they are playing with custom builds or patched versions), I have no choice but to limit access to TPPP.

Compiling OpenTTD is really easy and you have a step by step tutorial at the wiki. For Windows, in my opinion the easiest way of compiling MinGW (http://wiki.openttd.org/Compiling_on_MinGW). Once that you can compile a normal version without patches, you only have to do this to apply the TPPP diff file:

Using MSYS at the trunk folder, use this command:

Code: Select all

svn update -r(Revision)
Where revision is a number that is always found at the diff file name (in TPPP v09 case, it is r17744). After doing this, you must apply the diff file to the source code. Copy the TPPP diff file to the trunk folder and execute:

Code: Select all

patch -p0 -i (diff_file)
After that, you just compile the patched source as described in the wiki. If you have any problems with compiling or applying patches, the correct place to ask about them is at the Howto apply a patch / diff file thread.
User avatar
Sensation Lover
Transport Coordinator
Transport Coordinator
Posts: 338
Joined: 26 Feb 2009 09:17
Skype: Aron Bogdan Silviu
Location: Torino, Italy
Contact:

Re: Terkhen's Personal Patch Pack [r17744-v09]

Post by Sensation Lover »

can you place some screenshots with the way you do please... for me isn't that simple hombre. i understand very little about computers. it took me almost a year to understand how to play with grfs...
I was in:
Austria,Belgium,Brazil,China,France,Germany,Hungary,Indonesia,Italy,Luxemburg,Malaysia,Mexico,Netherlands,Norway,Panamà,Poland,Romania,
Saudi Arabia,Singapore,Slovenia,Spain,Switzerland,Thailand,U.K.,Ukraine,U.S.A.
User avatar
adf88
Chief Executive
Chief Executive
Posts: 644
Joined: 14 Jan 2008 15:51
Location: PL

Re: Terkhen's Personal Patch Pack [r17744-v09]

Post by adf88 »

Terkhen wrote:Compiling OpenTTD is really easy...
Most of game players have never used command line at all. They have icons, they click, they play. They are not interested in how the computers/operating systems works, the just want to have some fun and play a nice game.
Extracting files into proper directory can be difficult (find a directory!). Compilation can be too much difficult.
:] don't worry, be happy and checkout my patches
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: Baidu [Spider], Semrush [Bot] and 13 guests