KGAT PATCHPACK R16183 32 patchs crashes

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Trying to make a new Patchpack

Post by 2007Alain2007 »

i am trying to use station_build_gui_r15142 and It dosnt seem to want to work all the things are red :( any ideas
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Trying to make a new Patchpack

Post by planetmaker »

Hi,
2007Alain2007 wrote:i am trying to use station_build_gui_r15142
MeusH wrote:However, if you're experiencing problems (marked red) ask patch developer and tell him what's wrong. Tell him what diff file have you downloaded and what revision have you downloaded using "SVN Checkout")
Well?

btw, did clean trunk compile for you?

EDIT: and if a patch fails to apply an error description like "it didn't work" is not sufficient to solve anything. You usually get a more detailed error output. I don't use windows, thus cannot help you with tortoise.

I don't expect it to work without a few adaptions to current trunk anymore. Attached my current raw hg queue version (needs -p1, don't now how that works with tortoise). The patch is against r15438
Attachments
station_build_gui.diff
(22.27 KiB) Downloaded 209 times
Last edited by planetmaker on 13 Feb 2009 07:25, edited 3 times in total.
User avatar
Zuu
OpenTTD Developer
OpenTTD Developer
Posts: 4553
Joined: 09 Jun 2003 18:21
Location: /home/sweden

Re: Trying to make a new Patchpack

Post by Zuu »

Indeed, try to learn compiling clean trunk before you add any patches. Making and maintaining a patch pack is quite some work. Doable if you have a lot of time on your hand, but then you have to break down the work into pieces. Compile after every patch being applied to know that there are no obvious conflicts. (There can be logical conflicts that the compiler can't know of but will result in an unstable/multifunctional build) So take small steps.
My OpenTTD contributions (AIs, Game Scripts, patches, OpenTTD Auto Updater, and some sprites)
Junctioneer (a traffic intersection simulator)
flowover
Engineer
Engineer
Posts: 61
Joined: 24 Jun 2008 05:51

Re: Trying to make a new Patchpack

Post by flowover »

Tortoise SVN is a nice way to sort out patches. When you apply a patch against your copy, it will download the version that the patch is made for as well. The 3 views then shows the patch against the version its supposed to be for, your working copy against the patched version, and the merged of all 3. It is up to you to sort out which differences you want to keep and in what order. Conflicts are highlighted in the awesome scroll bar it uses. I wish all scroll bars acted this way.
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Re: Trying to make a new Patchpack

Post by DaleStan »

planetmaker wrote:(needs -p1, don't now how that works with tortoise).
It doesn't. TortoiseMerge only accepts the output of svn diff or equivalent tools.
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Trying to make a new Patchpack

Post by planetmaker »

So I guess, tortoise misses at least one nice way to sort out patches :P
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Trying to make a new Patchpack

Post by dihedral »

just edit the patch file directly :-)

edit: also, tortoise has a help or chm file + documentation on their website.... read that!
http://wiki.openttd.org/wiki/index.php/Development <- also worth reading! please do
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Trying to make a new Patchpack

Post by 2007Alain2007 »

Am i Doing some thing wrong here I am useing TortoiseSVN and i am doing as it says and i anit getting any were :(
For Community Integrated Version http://code.google.com/p/civopenttd/
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Trying to make a new Patchpack

Post by dihedral »

alain - lets have a chat on irc!
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Trying to make a new Patchpack

Post by 2007Alain2007 »

I would but i got to pay for it have you not got msn at all
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Trying to make a new Patchpack

Post by planetmaker »

This is better posted here than elsewhere, I guess:

Well, as already pointed out in your thread, take a step-wise approach:
1) please make sure that you can compile clean trunk.
2a) choose a patch with revision <xyz>
2b) update trunk to revision <xyz>
2c) patch that trunk with the chosen patch
2d) compile it

Now you may consider to learn updating patches.
3a) make a clean trunk checkout
3b) choose a patch with a revision close to trunk
3c) apply the patch to trunk
3d) fix any issues which might occur by looking at the files where there are issues (if there are)
3e) compile
3f) test the binary, if it works as intended, especially concerning the patched feature. If not go back to 3d)
3g) create an updated diff for that patch
3h) post the patch in the forums

4) Now, if you completed 3) successfully, for all patches which you desire you can start here:
4a) make a clean trunk checkout
4b) apply first patch (it is now a patch made for trunk, you did it in 3)
4c) apply 2nd patch
4d) fix any errors which occur doing so
4e) compile
4f) test the binary, if it works as intended, especially concerning the patched feature. If not go back to 3d)
4g) create an updated diff for that patch
4h) go back to 4c and add another patch, if desired
4i) post patch in forums

Making a patch pack is not as simple as to collect all patches made for the same revision. They're sure to conflict somewhere. Learning how to do that is best done with steps 1-3. We're certainly willing to help. But we won't make the patch pack. It can be serious work - depending upon the patches, their size and how many modify the same spot in the sources and the same aspects of the game.
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: Trying to make a new Patchpack

Post by Roest »

To emphasize on that i'll quote it again. When you are able to do steps 1-3 on your own, then you can start thinking about making a patch pack. Until that you are just wasting your time (and most likely ours). Sorry to be that blunt here. But after a certain amount of patches added things tend to get messy and you should at least have some basic understanding on what's going on.
planetmaker wrote:This is better posted here than elsewhere, I guess:

Well, as already pointed out in your thread, take a step-wise approach:
1) please make sure that you can compile clean trunk.
2a) choose a patch with revision <xyz>
2b) update trunk to revision <xyz>
2c) patch that trunk with the chosen patch
2d) compile it

Now you may consider to learn updating patches.
3a) make a clean trunk checkout
3b) choose a patch with a revision close to trunk
3c) apply the patch to trunk
3d) fix any issues which might occur by looking at the files where there are issues (if there are)
3e) compile
3f) test the binary, if it works as intended, especially concerning the patched feature. If not go back to 3d)
3g) create an updated diff for that patch
3h) post the patch in the forums

4) Now, if you completed 3) successfully, for all patches which you desire you can start here:
4a) make a clean trunk checkout
4b) apply first patch (it is now a patch made for trunk, you did it in 3)
4c) apply 2nd patch
4d) fix any errors which occur doing so
4e) compile
4f) test the binary, if it works as intended, especially concerning the patched feature. If not go back to 3d)
4g) create an updated diff for that patch
4h) go back to 4c and add another patch, if desired
4i) post patch in forums

Making a patch pack is not as simple as to collect all patches made for the same revision. They're sure to conflict somewhere. Learning how to do that is best done with steps 1-3. We're certainly willing to help. But we won't make the patch pack. It can be serious work - depending upon the patches, their size and how many modify the same spot in the sources and the same aspects of the game.
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Trying to make a new Patchpack

Post by 2007Alain2007 »

How do i compile it i cant see it were is the buton in TortoiseSVN to compile open ttd
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: Trying to make a new Patchpack

Post by Roest »

2007Alain2007 wrote:How do i compile it i cant see it were is the buton in TortoiseSVN to compile open ttd
This would be step 1 in the list
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Trying to make a new Patchpack

Post by 2007Alain2007 »

What prgrame do i need to do this with i might ask my g/fs dad if he knows becuse i do not get this
For Community Integrated Version http://code.google.com/p/civopenttd/
Timmaexx
Transport Coordinator
Transport Coordinator
Posts: 301
Joined: 03 Jan 2009 17:55

Re: Trying to make a new Patchpack

Post by Timmaexx »

2007Alain2007 wrote:I would but i got to pay for it have you not got msn at all
IRC is more free than MSN, ICQ, etc. You just need a gratis Client like Chatzilla(Add-On for Mozilla Firefox) X-Chat Kopete Pidgin etc.
And you can "chat" with more people your MSN List will ever have.
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Trying to make a new Patchpack

Post by 2007Alain2007 »

I have justed started to install Chatzilla add on for firefox once its installed is there any thing esle i need to do

But i Have to go work now
For Community Integrated Version http://code.google.com/p/civopenttd/
Conditional Zenith
Chief Executive
Chief Executive
Posts: 697
Joined: 10 Jun 2003 00:19
Location: Australia

Re: Trying to make a new Patchpack

Post by Conditional Zenith »

I hate to be negative, but I tend to agree with Roest. You don't seem to understand how much work is involved in what you are doing, nor do you even seem to understand what you are doing. First you need to be able to compile a clean trunk, the instructions to do that are all at the wiki. To get this patch pack to work, you will need to understand C++ (as you will get some conflicts, and you will need to understand the code that is conflicting), and you will have a lot better chance if you understand the contents of a patch, and roughly what happens when you apply one.

Even if you do overcome your sizable knowledge gap (which you can do, it will take time though, and people will get sick of your questions if you don't read a lot of the information yourself), the workload involved is quite large, which is why integrated nightlies and patchpacks aren't common.

I wish you luck, but there is a lot you need to learn. Read through the stuff about compiling and applying patches on the OTTD wiki, and forget about patches until you can compile the trunk.
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Trying to make a new Patchpack

Post by dihedral »

Conditional Zenith wrote:and people will get sick of your questions if you don't read a lot of the information yourself
not true! at least i already am sick and tired of his questions and lack to google, read the wiki, search the forum.
i did not expect this patch pack to succeed from the very beginning - but i did not think it'd be this bad from the very start!
Timmaexx
Transport Coordinator
Transport Coordinator
Posts: 301
Joined: 03 Jan 2009 17:55

Re: Trying to make a new Patchpack

Post by Timmaexx »

I hate it when someone is quoted and then he edits the article so much, that the quote is'nt usefull anymore :twisted:
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: Amazon [Bot] and 1 guest