1.9.1 alpha progress

SHADOW-XIII · Post by **SHADOW-XIII** » 24 May 2003 07:26

here in windows version it works so it is only dos fault probably

SHADOW-XIII · Post by **SHADOW-XIII** » 24 May 2003 07:30

Josef can you make 'loadallgraphics' off by default ??

eis_os · Post by **eis_os** » 24 May 2003 07:30

I think we have enought crashlogs now,
Josef should know that the DOS Version 45 breakes.

spaceman-spiff · Post by **spaceman-spiff** » 24 May 2003 10:52

eis_os wrote:I think we have enought crashlogs now,
Josef should know that the DOS Version 45 breakes.

You can never have enough

eis_os · Post by **eis_os** » 24 May 2003 11:22

Please send all new crashlogs about alpha 45 dos with the new game / scenario editor problem to Spaceman-Spiff

He likes reading Crashlogs, so you could give him something back for moderating the forums.
He is surely happy about your posts

*eg*

spaceman-spiff · Post by **spaceman-spiff** » 24 May 2003 11:30

eis_os wrote:Please send all new crashlogs about alpha 45 dos with the new game / scenario editor problem to Spaceman-Spiff

He likes reading Crashlogs, so you could give him something back for moderating the forums.
He is surely happy about your posts

*eg*

Yes, please do, I will gather them and then send them to the patchman

Dinges · Post by **Dinges** » 24 May 2003 11:50

Too bad I deleted 134 crashlogs last time...

Patchman · Post by **Patchman** » 24 May 2003 16:41

eis_os wrote:I think we have enought crashlogs now,
Josef should know that the DOS Version 45 breakes.

Yes, I know. But I still haven't found out why

It works fine on my computer, all versions...

Can someone please try to fiddle with the switches and/or newgrf.txt and find out what breaks it?

eis_os · Post by **eis_os** » 24 May 2003 19:48

To inform you all, enhancegui is breaked while Josef made the code smaller. I have now tested I think around 4 different versions of my codebases. Josef seems mixed some registers. It's better you switch off the patch with off until we will fix it, or we use my orginal version of the code.

Oracle · Post by **Oracle** » 24 May 2003 20:11

I've done some testing for alpha 45 (DOS) on my Win 98 computer. (Alpha 44 works fine.)

Changing the switches does not seem to make a difference - most on (except new rvs and planes) and all off seems the same but there may be some overlap with electrified railways and new ships as they have an impact on graphics.

Normally, with my usual newgrf.txt, TTD does not start due to a 'memory protection error', but varying the newgrf.txt file produces varying results, with crashes or hangs at different points. The attached zip file contains all my newgrf.txt files, the crashlogs for each of them (if there is one), a text file listing the results of each file/set of files and the cfg file used for testing.

Hope these are useful.

Patchman · Post by **Patchman** » 24 May 2003 21:46

Oracle wrote:I've done some testing for alpha 45 (DOS) on my Win 98 computer. (Alpha 44 works fine.)

Changing the switches does not seem to make a difference - most on (except new rvs and planes) and all off seems the same but there may be some overlap with electrified railways and new ships as they have an impact on graphics.

Normally, with my usual newgrf.txt, TTD does not start due to a 'memory protection error', but varying the newgrf.txt file produces varying results, with crashes or hangs at different points. The attached zip file contains all my newgrf.txt files, the crashlogs for each of them (if there is one), a text file listing the results of each file/set of files and the cfg file used for testing.

Hope these are useful.

Unfortunately I can't reproduce any of these crashes. All of the files work fine for me. I do note that some of your newgrf.txt files start with an empty line. That forces alpha 45 to terminate processing of newgrf.txt at the empty line, so all your newgrf.txt files beginning with an empty line are equivalent to empty newgrf.txt files. In alpha 46, it'll at least complain that it can't find file "", instead of aborting silently...

However, even that worked fine for me. No crashes at all. Since TTDPatch doesn't actually load any graphics (because of the empty line), the fault can't be in the new .grf files. That makes it even more puzzling, because then the error would have to be in title.dat or something. I even tried the english language version of TTD (which you're using), but that made no difference either. Very strange.

Could you try alpha 45 on a fresh install of TTD? I'm curious if the problems stem from some changes to trg1.grf (e.g. the Euro character) perhaps.

eis_os wrote:To inform you all, enhancegui is breaked while Josef made the code smaller. I have now tested I think around 4 different versions of my codebases. Josef seems mixed some registers. It's better you switch off the patch with off until we will fix it, or we use my orginal version of the code.

I'm terribly sorry. I'm very picky about wasted bytes in the assembly code, and when I see an opportunity to reducing the size, I can't resist. Unfortunately in doing so I broke enhancegui except when you have "enhancegui 0". I didn't even test it with anything but the default either, or I would have noticed.

It'll be fixed in alpha 46.

Stylesjl · Post by **Stylesjl** » 24 May 2003 23:09

here is my config

Stylesjl · Post by **Stylesjl** » 24 May 2003 23:12

and crash log

Stylesjl · Post by **Stylesjl** » 25 May 2003 00:52

I don't think its the switchs i tried installing lastest alpha on the other computer which is also DOS Version and the scenario editor still crashes

spaceman-spiff · Post by **spaceman-spiff** » 25 May 2003 04:19

Do you always talk to yourself

Patchman · Post by **Patchman** » 25 May 2003 07:08

Good news: I managed to reproduce the crash.

It's morevehicles that's broken. If set to > 1, it crashes when starting a new game.

Bad news: I have absolutely no clue what broke this. I changed not a single byte related to morevehicles from alpha 44 to 45. I went through every line of changes, and there is none. Absolutely none.

I'm at a loss as to where to start looking now...

Stylesjl · Post by **Stylesjl** » 25 May 2003 07:29

wow more veichles hold on..........

Stylesjl · Post by **Stylesjl** » 25 May 2003 07:51

Yes thats right moreveichles did break it maybe something else interfered with the code of more veichles

Patchman · Post by **Patchman** » 25 May 2003 08:37

It was the new loader, which made it necessary to patch one thing that was automatically patched before. That was tough to find...

But now...

Here's another quick update, mostly because of crashes in alpha 45. I hope they're fixed now. I've also worked on the electrified railways yet again, now pylons are shown properly inside not outside the bridges, and not shown on tubular bridges at all. Because of this, you have to yet again download a new elrails(w).grf file... sorry about that. But finally, the game actually notifies you if you have an outdated version

Also I broke Oskar's depot GUI code when integrating it, this is fixed now. You can add up the following numbers as parameters to enhancegui:
2 Make depot windows even bigger, show 8 more cars instead of 4
4 Make almost everything in the depot window act as trash can
Note that if you use this, be careful not to accidentally sell your vehicles!
8 Put trash can horizontally on bottom of the window

And finally, Marcin has fixed a bug which prevent new airports from being constructed in some towns where the player did not already own an airport.

All changes in 1.9.1 alpha 46 (May 25, 2003):

don't abort processing of newgrf(w).txt when an empty line is encountered
I broke Oskar's depot GUI code when integrating it, now it's fixed
show pylon for track piece under bridge
show pylon inside bridge, not outside
by Marcin: fix airport counting bug preventing the construction of airports in some towns where one didn't have any airports yet
rename small to smallico in windows.c or gcc complains (?)
fixed crash when starting new game in DOS version with morevehicles > 1
remove pylons from tubular bridge again

Stylesjl · Post by **Stylesjl** » 25 May 2003 08:49

i downloaded it and the bug is fixed finally now i can use the scenario editor again

Transport Tycoon Forums

1.9.1 alpha progress

Who is online