completely shore

[BigBB]

Lepkka made a beautiful NewGRF to replace the water and shores link.

But OpenTTD don't support corner shores so the grf looks ugly (see pic.).

(temperate, sub-arctic, sub-tropical and toyland; without and with Lepkka's grf)



So I decided to make a patch to solve this problem (full action 05 0D support). Without a water-NewGRF will be still normal grass-tiles shown, but with a grf the corner have shores (see pic.).

(temperate, sub-arctic, sub-tropical and toyland; without and with Lepkka's grf)



- he docks have now with a NewWater NewGRF the shore spirit from this grf (see pic)
- and bridgeheads next to a shore tile have now shore ground tiles (see pic)



- bridgeheads on shore can flood their neighbours too
- corner shores only floods if a NewWater grf loaded (but if you deactivate this grf, the corner shores will not removed)

- industry shore tiles change their spirit if a NewWater NewGRF loaded (see pic)




Have fun,
BigBB

[Leviath.NL]

I think you have to post more information about how your patch works. Right now people can only guess what's going wrong.

[Digitalfox]

BigBB i just had to say, that what you are trying to fix, is something that annoys me a lot..

Since i also use lepkka's NewWater NewGRF..

Good luck

[BigBB]

I think you have to post more information about how your patch works. Right now people can only guess what's going wrong.

The patch isn't in a stadium to release it. However, I have found and fixed the problem and now lepkka's NewWater works errorless.


Edit: add pics, only for post one

[Digitalfox]

I think you have to post more information about how your patch works. Right now people can only guess what's going wrong.

I have found and fixed the problem and now lepkka's NewWater works errorless.

Great

[BigBB]

I have one problem: if you build a railway on an upper part of a corner slope the coast will be removed.



This is a problem for TTD-Patch too (tested with r1759). So I don't know if it is a NewGRF problem or not. Maybe anybody with NewGRF-experience can help?

Thanks,
BigBB

[XeryusTC]

That is more a limitation in the sprite that is being used. There is a special sprite for these kinds of slopes with a rail on it IIRC, and the water set only adds (or replaces, but adds seems more likely) an extra sprite for the coast tile without the rail.

[BigBB]

Ah, thanks XeryusTC.

[BigBB]

It's now downloadable (see first post). Full action 05 0D support and a flood fix.

Have fun,
BigBB

[Loop]

Wow, this is great! Good job!

[Digitalfox]

WOW great job BigBB

I really hope this get's in trunk

[Snuk the Great]

Just simply awesome!

[belugas]

It's on my radar.
Lots of goodies (comments)
Nice work (again)

[BigBB]

New version (v1.1):
- replaced all TILE_ADD() with TileAddByDiagDir()
- removed all magic numbers
- many small changes

Thanks to skidd13 for his suggestions.

Edit: update to r11266

[boekabart]

1) I personally don't like the fact that flooding also changes for games without newwater.
2) It's not turning completely into shore, see png

[BigBB]

It's not turning completely into shore, see png

Fixed (v1.2).

Todo list:
- Change ground tiles for bridges and docks

bug2and4.png (20.13 KiB) Viewed 21992 times

- fix railway on corner-shores

bug.png (3.62 KiB) Viewed 23107 times

- BigBB

[boekabart]

Very well, I hope you can get that done too!

About the 'canyon flooding': as long as it's not an option in the grf file - I'd definitely make it a patch option to change the flooding behavior like this - not everyone will like it (me! pick me!).....

[athanasios]

No canyon flooding please. It will steal our money when landscaping.

[Mchl]

Who said landscaping should be cheap?

But I also think ot should be an option, as it is diffirent from original TTD behaviour.

[BigBB]

New version (v1.3) uploaded:

• forgot in the last version, that next to a bridge a second, third, ... bridge can be ... fixed
• the docks have now with a NewWater NewGRF the shore spirit from this grf (see pic)
• and bridgeheads next to a shore tile have now shore ground tiles (see pic)

dock_bridge-ground.png (38.71 KiB) Viewed 26747 times

The fix for the railway on corner-shore-tiles will be fix by frosch, to minimize the overlapping between my patch and his halftile foundations patch.

-BigBB