New map features
Moderator: OpenTTD Developers
Re: New map features
Hi Cirdan, I've added a branch 'cirdan-blitter-scroll-fix' to https://github.com/JGRennison/OpenTTD-patches which fixes this issue.
It's caused by a signed/unsigned arithmetic issue when calculating the src point when scrolling vertically downwards (scroll_y < 0) in the Blitter_*::Surface::scroll methods.
It's caused by a signed/unsigned arithmetic issue when calculating the src point when scrolling vertically downwards (scroll_y < 0) in the Blitter_*::Surface::scroll methods.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: New map features
You were fast—I was still looking at the code, wondering why the bug did not show up on my box, but it turns out that it is masked if integers and pointers are the same size. Thank you; I have merged your patch and pushed it to the repo, along with another commit to silence this warning.
Re: New map features
cirdan wrote:I have merged your (JGR) patch and pushed it to the repo, along with another commit to silence this warning.
The bugicidal unguaranteed Win32 binaries are posted below: and for those who want bridges over stations (free-bridges.diff): Enjoy
Last edited by wallyweb on 19 Sep 2016 19:46, edited 1 time in total.
wallyweb on tt-forums: Screenshots - Wallyweb World - Projects & Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018 - May 2019
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018 - May 2019
Re: New map features
Not on my compiling machine, will use this post as dummy to provide the compiled version l8er.
Thank you so much for (hopefully) fixing the problem
Cheers
Sure i will test a few things before posting and either post the executable or a bug report
Thank you so much for (hopefully) fixing the problem
Cheers
Sure i will test a few things before posting and either post the executable or a bug report
Last edited by TrueSatan on 18 Sep 2016 18:42, edited 1 time in total.
Re: New map features
After looking at the code, the same bug could affect the smallmap. Could you test this before posting a binary?
Re: New map features
I tried the smallmap and got the result in the screenshot.cirdan wrote:After looking at the code, the same bug could affect the smallmap. Could you test this before posting a binary?
The vertical stripes seem to appear when tiles are marked dirty and redrawn. When paused the background stays black.
There aren't any crashes when scrolling though.
- Attachments
-
- Unnamed, 1945-02-05.png
- (618.16 KiB) Not downloaded yet
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: New map features
Thanks for testing. Displaying the smallmap is the problem here, not scrolling. Even if there is no crash, random locations in memory may be being written to. I am working on a fix.
Re: New map features
With my Win32 binaries I saw none of this. All was as expected.JGR wrote:I tried the smallmap and got the result in the screenshot.cirdan wrote:After looking at the code, the same bug could affect the smallmap. Could you test this before posting a binary?
The vertical stripes seem to appear when tiles are marked dirty and redrawn. When paused the background stays black.
There aren't any crashes when scrolling though.
wallyweb on tt-forums: Screenshots - Wallyweb World - Projects & Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018 - May 2019
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018 - May 2019
Re: New map features
Yes, this is normal. The bug only affects 64-bit platforms, where pointers are usually wider than integers.wallyweb wrote:With my Win32 binaries I saw none of this. All was as expected.
Re: New map features
As JGR has posted I got the same result on Minimap. Its black with strips of the normal minimap at random points.
Even tried to enabe graphs (never used before) and other windows.
Beside the minimap it runs okay so far.
Thanks and I will wait for the fix before posting a new version of the Ubuntu binary
Cheers
Even tried to enabe graphs (never used before) and other windows.
Beside the minimap it runs okay so far.
Thanks and I will wait for the fix before posting a new version of the Ubuntu binary
Cheers
Re: New map features
The attached patch should fix the smallmap on 64-bit platforms. Can you give it a try?
- Attachments
-
- blitter-fix.diff
- (6.87 KiB) Downloaded 50 times
Re: New map features
All seems to work fine for me with this applied.cirdan wrote:The attached patch should fix the smallmap on 64-bit platforms. Can you give it a try?
On an unrelated note, I get these warnings about maybe uninitialised variables when compiling:
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: New map features
Thank you, I have pushed the fix to the repository.JGR wrote:All seems to work fine for me with this applied.
Yes, I am aware of those, and they are false positives. I could silence them by initialising the relevant variables with a constant, but I am not too keen on writing worse code to appease the compiler.JGR wrote:On an unrelated note, I get these warnings about maybe uninitialised variables when compiling:
Re: New map features
cirdan wrote: I have pushed the fix to the repository.
More bugicide ...
Unguaranteed Windows 32bit binaries:
JGR's tracerestrict version is available here.
Enjoy!
Last edited by wallyweb on 19 Sep 2016 22:12, edited 2 times in total.
wallyweb on tt-forums: Screenshots - Wallyweb World - Projects & Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018 - May 2019
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018 - May 2019
Re: New map features
Looks fine over here so I post the usual 64bit version for Ubuntu 14.04
Still see no reason to switch to 16.04 haha
Thanks JGR and Cirdan for the fast fixes.
And as well JGR tracerestriction branch.
Cheers
Still see no reason to switch to 16.04 haha
Thanks JGR and Cirdan for the fast fixes.
And as well JGR tracerestriction branch.
Cheers
- Attachments
-
- openttd-custom-g95852d54-UNIX.tar.xz
- Version: g95852d54
Ubuntu 14.04 64bit - (4.66 MiB) Downloaded 39 times
-
- openttd-custom-gde262117-tracerestrict-cirdan-UNIX.tar.xz
- Version: gde262117-tracerestrict
Ubuntu 14.04 64 bit - (4.68 MiB) Downloaded 114 times
Last edited by TrueSatan on 19 Sep 2016 22:24, edited 3 times in total.
Re: New map features
wallyweb wrote:JGR's tracerestrict version will be posted here when we have his push.
This is on Github now.TrueSatan wrote:JGR tracerestriction will be posted as soon as JGR has updated the branch
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: New map features
JGR wrote:This is on Github now.
For those who want the JGR tracerestricted Windows 32 bit bugicide we have:
The original cirdan variety is available here.
Enjoy.
wallyweb on tt-forums: Screenshots - Wallyweb World - Projects & Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018 - May 2019
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018 - May 2019
Re: New map features
This might be something that's due to self-compiling/patching, but I have crashes when building a rail X crossing directly on a bridge head, and then removing only the crossing track. Works fine for roads and demolishing the entire bridge, though.
...
Kinda almost feel like this came up before, but, eh, I don't know. Maybe someone can double-check with the builds posted here?
...
Kinda almost feel like this came up before, but, eh, I don't know. Maybe someone can double-check with the builds posted here?
Re: New map features
Confirmed, the crash happens when trying to update the signals around the segment that contains the bridge head. The attached patch should fix this. Note that it may take some time until I can push this to the repository.
- Attachments
-
- crossing-bridgehead.diff
- (626 Bytes) Downloaded 49 times
Re: New map features
Now that's what I call great costumer service ... thanks.
Who is online
Users browsing this forum: No registered users and 2 guests